Message222730
| Author |
taleinat |
| Recipients |
Saimadhav.Heblikar, jesstess, taleinat, terry.reedy |
| Date |
2014年07月11日.09:08:22 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1405069703.13.0.650168637921.issue21939@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I've reviewed the patch and made my remarks in the review tool.
These tests don't test the central functionality of Percolator nearly enough. We should test, at least:
1) That the text actually went through the filter (and not directly to the Text
widget).
2) That if a filter modifies the text, the modified text appears in the Text
widget.
3) That a filter can stop the event from continuing through the following
filters.
4) That having more than one filter modify the arguments works.
5) That not having any filters works.
6) That this doesn't only work on a Text widget's "insert" and "delete" events.
There are probably more things we should test. Take a look at what this is used
for in practice in the code for ideas. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2014年07月11日 09:08:23 | taleinat | set | recipients:
+ taleinat, terry.reedy, jesstess, Saimadhav.Heblikar |
| 2014年07月11日 09:08:23 | taleinat | set | messageid: <1405069703.13.0.650168637921.issue21939@psf.upfronthosting.co.za> |
| 2014年07月11日 09:08:23 | taleinat | link | issue21939 messages |
| 2014年07月11日 09:08:22 | taleinat | create |
|