homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix test_getpass on Windows
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Thomas Fenzl, pitrou, python-dev, r.david.murray, zach.ware
Priority: normal Keywords: patch

Created on 2013年04月11日 20:29 by zach.ware, last changed 2022年04月11日 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_getpass_windows_fix.diff zach.ware, 2013年04月11日 20:29 Fix tests on Windows review
Messages (5)
msg186588 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013年04月11日 20:29
(Copied the nosy list from issue17484)
The new test module fails on Windows due to the lack of termios and pwd modules. Here's a patch that fixes things. I suspect the skip condition on UnixGetpassTest could be changed to check 'termios' rather than os.name, but I can't test that currently.
Thanks,
Zach
msg186596 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013年04月11日 21:47
New changeset c84a5e5f73c3 by R David Murray in branch 'default':
#17699: Fix the new getpass test failures on windows.
http://hg.python.org/cpython/rev/c84a5e5f73c3 
msg186597 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013年04月11日 21:48
Thanks Zachary. I forgot to check the buildbots after I pushed that patch.
msg186598 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013年04月11日 21:56
I'm going to close this because the windows buildbots currently aren't building, and I'll forget to close it if I wait for them. I trust you'll reopen it if it doesn't actually fix the problem for some reason :)
msg186674 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2013年04月12日 19:51
Buildbots look happy (with test_getpass, anyway) and my machine is happy too. Thanks for the commit :)
History
Date User Action Args
2022年04月11日 14:57:44adminsetgithub: 61899
2013年04月12日 19:51:45zach.waresetmessages: + msg186674
2013年04月11日 21:56:22r.david.murraysetstatus: open -> closed
resolution: fixed
messages: + msg186598

stage: resolved
2013年04月11日 21:48:48r.david.murraysetmessages: + msg186597
2013年04月11日 21:47:55python-devsetnosy: + python-dev
messages: + msg186596
2013年04月11日 20:29:24zach.warecreate

AltStyle によって変換されたページ (->オリジナル) /