homepage

The changeset for subtests in #16997 cause some tests in test_socket to fail on OS X.
Specifically, they cause some tests that were marked as expected failures to be run and be marked as failures.
I'm experiencing the same test failures as the OS X Mountain Lion buildbot. `Here's an example build failure (Build 1058). http://buildbot.python.org/all/builders/AMD64%20Mountain%20Lion%20%5BSB%5D%203.x/builds/1058`_
Per issue #12958 I believe these tests should be skipped on OS X.
I'm attaching a patch which skips the offending tests on OS X.

I'm making Antoine nosy since he's the author of the "faulty" changeset.
Richard, IIRC, you said somewhere that FD passing failures on OS X could be made to work by passing a FD at a time, or something like that. What do you think of those faiilures?

On 10/04/2013 6:32am, Charles-François Natali wrote:
> Richard, IIRC, you said somewhere that FD passing failures on OS X
> could be made to work by passing a FD at a time, or something like
> that. What do you think of those faiilures?
I think sending one *array* at a time works as well. These two failures 
send two arrays, so they are expected.
(Also, the sending process should wait for some sort of notification 
that the receiving process has received the fds before continuing: 
closing the socket prematurely causes problems.)

Indeed, it has been decided that @expectedFailure would only work when applied to the test methods run by unittest. In that light, the patch is a correct solution to the issue.
(I don't think expected failures are a very useful concept myself :-))

New changeset 9cfaefa58bdc by Charles-Francois Natali in branch 'default':
Issue #17684: Fix some test_socket failures due to limited FD passing support
http://hg.python.org/cpython/rev/9cfaefa58bdc 

Committed, thanks!

Charles-Francois: why did you commit this to default only, and not to 3.3?
(see also issue18651)

New changeset b7d764807343 by Charles-Francois Natali in branch '3.3':
Issue #17684: Fix some test_socket failures due to limited FD passing support
http://hg.python.org/cpython/rev/b7d764807343 

> Charles-Francois: why did you commit this to default only, and not
> to 3.3?
I overlooked it (apparently, the issue was tagged 3.4 only, and I didn't double-check that the code was present in 3.3 as well).
Should be better now!

Thanks!