homepage

Changes proposed in PEP3121 and PEP384 have now been applied to the json module!

+ // in case init is called multiple times within one interpreter,
+ // we do not have to repeat all of the initialization
First, you shouldn't use C++-style comments ("//").
Second, I find this comment a bit weird. Even if init is called a second time, surely clear would have been called in-between, and therefore the module state has to be initialized again?
Review comments from issue15653 also apply here.

Hey Antoine,
This comment describes exactly what I intended with the "dance" in issue15653. For example the json testsuite issued multiple calls to the init function before unloading and consequently clearing the module.
However it seems as if the behavior this code dealt with,
has been a bug inside the import lib.

Incidentally, I am deeply sorry for the C++-Style comments. I thought those would be detected by the patchcheck.py.

Removed C++ comment and corresponding codesnipped. Also changed bad-style macro definition.

Issue fixed in Python 3.9 with:
commit 33f15a16d40cb8010a8c758952cbf88d7912ee2d
Author: Dong-hee Na <donghee.na92@gmail.com>
Date: Fri Mar 27 19:59:59 2020 +0900
 bpo-40077: Convert _json module to use PyType_FromSpec() (GH-19177)
 
 Replace statically allocated types with heap allocated types:
 use PyType_FromSpec().
 
 Add a module state to store the Scanner and Encoder types.
 Add traverse, clear and free functions to the module.