Message 168227 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	Robin.Schreiber, loewis, pitrou
Date	2012年08月14日.19:03:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1344971003.63.0.0507585137711.issue15655@psf.upfronthosting.co.za>

Content
+ // in case init is called multiple times within one interpreter, + // we do not have to repeat all of the initialization First, you shouldn't use C++-style comments ("//"). Second, I find this comment a bit weird. Even if init is called a second time, surely clear would have been called in-between, and therefore the module state has to be initialized again? Review comments from issue15653 also apply here.

Content

+ // in case init is called multiple times within one interpreter,
+ // we do not have to repeat all of the initialization
First, you shouldn't use C++-style comments ("//").
Second, I find this comment a bit weird. Even if init is called a second time, surely clear would have been called in-between, and therefore the module state has to be initialized again?
Review comments from issue15653 also apply here.

History
Date	User	Action	Args
2012年08月14日 19:03:23	pitrou	set	recipients: + pitrou, loewis, Robin.Schreiber
2012年08月14日 19:03:23	pitrou	set	messageid: <1344971003.63.0.0507585137711.issue15655@psf.upfronthosting.co.za>
2012年08月14日 19:03:22	pitrou	link	issue15655 messages
2012年08月14日 19:03:22	pitrou	create

homepage