openstack/ironic-python-agent - ironic-python-agent - OpenDev: Free Software Needs Free Tools

These are detected as errors since the clean up was done[1] in
the requirements repository.
[1] 314734e938f107cbd5ebcc7af4d9167c11347406
Also remove the note about old pip's behavior because the resolver
in recent pip no longer requires specific order.
Change-Id: If927d65ff67527cab349e5d5249aa97ef5b0aca4

The doc8 module explicitl supports Python 3.6 starting from version
0.8.1
Also remove it from test-requirements as we already have it in tox.ini
Change-Id: Idc66758dc350d9a7a09b4295b08f4423cec288dc

* Remove pep8 dependencies from test-requirements, they're not
needed there and are hard to constraint properly.
* Add cliff to l-c (same version we have on ironic)
Change-Id: I8e7582492276db2308217460af37f691fb99c0ce

Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.
Change-Id: Ifa2af7404f4cd85cffd29ed725278d04a7c5f8c6

Now with a safe version of flake8!
Change-Id: Ic2c8e787a2857ab80d35a7bc81b8272701f99d36

flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: Iff96a7a4c8f2a0f625a47ac44158d904fa132157

Change-Id: Id7c5686cdbdc79812e06eb4a5f87eddc75005cc3

Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.
Disable openstackdocs_auto_name to use 'project' variable as name.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
This repo uses storyboard, configure the proper variables.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: Id084bfc9d5ae7a95d3cba22a00b4c03a35967ee4

Full py3 compatible version.
Add all Python3 modules to stdlib list.
Also includes fix to an enum34 dependency bug.
Change-Id: Ic50a33cf5dfa45c23dbffaee8c5d9e109fb0a734

Drop the third party mock library to use unittest mock from
standard library.
Change-Id: Ib64b661572e4869a24865c02a6c84a6603930394

Make a few cleanups:
- Remove python 2.7 stanza from setup.py
- Add requires on python >= 3.6 to setup.cfg so that pypi and pip
 know about the requirement
- Remove obsolete sections from setup.cfg:
 * Wheel is not needed for python 3 only repo
 * Some other sections are obsolete
- Update classifiers
- Update requirements, no need for python_version anymore
- Use sphinx-build
Change-Id: I8abd764d97a6711d3e6347ec3a7b8967f1512006

Change-Id: I1032ea6a2e9d79aeaecb1458c319cbeb15ac1fff

WSME is no longer maintained and Pecan is an overkill for our (purely
internal) API. This change rewrites the API in Werkzeug (the library
underneath Flask). I don't use Flask here since it's also an overkill
for API with 4 meaningful endpoints.
Change-Id: Ifed45f70869adf00e795202a53a2a53c9c57ef30

OpenStack is dropping the py2.7 support in ussuri cycle.
ironic-python-agent is ready with python 3 and ok to drop
the python 2.7 support.
Complete discussion & schedule can be found in
- http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html
- https://etherpad.openstack.org/p/drop-python2-support
Ussuri Communtiy-wide goal - https://review.opendev.org/#/c/691178/
Change-Id: Ifd0e0b99bb82a7d7e82d6c14309468196f5734fc

Some options are now automatically configured by the version 1.20:
- project
- html_last_updated_fmt
- latex_engine
- latex_elements
- version
- release.
Change-Id: I38d3f05ce9d6a32a0c4e5d44df13e527aa629b2e

Change-Id: I2144c284ffcfa696412fca30f59a66c54c3d1965
Story: 2005791
Task: 33564

Following recent changes to global requirements [1], we need
to update sphinx requirements locally.
[1] If558f184c959e4b63b56dec3ca1571d1034cfe5c
Change-Id: I6215d1a4ad72444a23bdd39d7ac7158bcb06fd21

According to Openstack summit session [1] stestr is maintained project
to which all Openstack projects should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Also adjust requiremenst to past the gate checks.
Change-Id: If7a0ebd9cca26cb67eb2ec9036d0aa2693fdffbf
Signed-off-by: Chuck Short <chucks@redhat.com>

hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: I2c84d3368bd6675c28ebba695e0c1afdd2867588

Change-Id: I6dbe9201912d5b385be3d426ed5e6a0546746c9e

Change-Id: I3036d2371698090f47830070b281b0f55137e4dd

Change-Id: I377eac62494b118231ebbad2ae5e29dcbb2dd2ae

Change-Id: If1aa9774250e1fd84cc47fdf18b939ed2dd99d9d

Change-Id: Ifbf7bdaebe362541eada2a236786614489e2f554

Change-Id: I562b667455268e491bc95b3c0c37115e4139c7c4

Use latest version of flake8-import-order package, like we do in
openstack/ironic
Fix two issues detected by new version.
Change-Id: Idb8f0fd79c3d6b34611288f77948d042cd837806

Change-Id: I9d59a5196b57fbc8af1efff3a6841410966ad260

Now, os-testr is depending on python-subunit [1], so
we don't need this any more.
[1] https://github.com/openstack/os-testr/blob/master/requirements.txt
Change-Id: I8e1022cf04b5fff665c371594dee2b827c7d77b0

Enable the following off-by-default checks:
 * [H204] Use assert(Not)Equal to check for equality.
 * [H205] Use assert(Greater|Less)(Equal) for comparison.
 * [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in
 mock.patch/mock.patch.object calls
Increase the version of hacking in test-requirements so that can use new
off-by-default checks.
No changes to code were required.
Change-Id: I98aa484dc5414ee49c281dfd40e44b3c613d53e0

Change-Id: I42c1a4d34194a3d3ae7d330ad4959155ec41d192

Change-Id: I4e0e586f9e37548c27bb0f8475999ea2567f0737

Change-Id: Id4b7336f8b441925412318a79839130babb526a5

Change-Id: I1aecf894955e8095c11b8fb82d60488e5d0aca5f

Change-Id: I30866baf4d347dfc8d0a45fbe29c444778443783

Change-Id: I8f3c7abb313a18ec8f41aefc6001392818a9ccf5

Change-Id: Ibb2590c8f12c509a9cb2fe3abde77f22fa7c1b52

Change-Id: I93d6f7bede18f43dd2117227be3fca2ebda48f2f

Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: I946457e9079ce0b54c7fe0ad554d024a1c61dce0

Change-Id: I216c039b838f0ccfb2a68ca37220d28c09e39074

Updated file tox.ini allows to check code style in all ".sh" files
included in Ironic Python Agent. Checking can be invoked by calling either
"tox" or "tox -e pep8".
Change-Id: Ie76605737c7db10a064f2aebfda388372a4c0591
Closes-Bug: #1625215 

Use hacking 0.12.0
Use the new checks that are available:
 [H106] Don’t put vim configuration in source files.
 [H203] Use assertIs(Not)None to check for None.
 [H904] Delay string interpolations at logging calls.
Fix code so tests pass.
Change-Id: If22ad272c332f30624ce10861408d377908b152b
Depends-On: I2aa44b62f900d4dfd67701b01eadd0523fbfaf07

Change-Id: I1d7f5941e927372ce5185b41efa46ac8bd4b8492

Change-Id: Ic70856a9285d0956af9ace0286e3fe001d178bde

Change-Id: I04f49177cf66aec7d4cbe484a77c4a51ce9b0fcc

Update the hacking test-requirement to match openstack/requirements
global-requirements.txt
The hacking requirement is not updated by the proposal bot.
Change-Id: I6cfbaf55abad0c33cbcbe8063d873db717f5252e

'discover' is test discovery for unittest and is only needed for
< python 2.7 (it was introduced in py 2.7), so it is no longer
needed.
Change-Id: I14dc79fe929854af6d51152815bc22e66d2273dc

Change-Id: I89a00b840a7b10a6d697064bd0f1a7b190917d03

Change-Id: Ibdebe6111177ebea20777dec175d65b13a3b3d7c

Change-Id: I5ef758226b5c5f5e61988bf49515ec94bc002522

This commit switches the tox command to use ostestr instead of calling
testr through setup.py. The primary advantage here is that it uses the
subunit-trace output filter. ostestr primarily exists as a replacement
for pretty_tox.sh bash scripts which spread like a plague through
OpenStack projects after Nova copied it from Tempest. (although ostestr
also provides some other useful features) Granted ironic wasn't using
that, but this commit makes the switch to enable getting the
subunit-trace output which is generally useful.
Note that this dramatically increases output while running tests.
However, test failures are still at the bottom of the output, so it
shouldn't cause much pain, if any.
Also remove requirements.txt from tox.ini deps
This is redundant, per lifeless email:
http://lists.openstack.org/pipermail/openstack-dev/2015-July/069663.html
Change-Id: Ia9e3000ddfe02979c26807ae5d130bfd2730c5e1