[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[bug #54307] Wrong margins especially when printing one page
From:
Yavor Doganov
Subject:
[bug #54307] Wrong margins especially when printing one page
Date:
2018年7月13日 11:45:27 -0400 (EDT)
User-agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
URL:
<http://savannah.gnu.org/bugs/?54307>
Summary: Wrong margins especially when printing one page
Project: GNUstep
Submitted by: yavor
Submitted on: Fri 13 Jul 2018 06:45:26 PM EEST
Category: Gui/AppKit
Severity: 3 - Normal
Item Group: Bug
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
Reported initially by Patrick Cardona in these threads:
http://lists.gnu.org/archive/html/discuss-gnustep/2018-07/msg00003.html
http://lists.gnu.org/archive/html/discuss-gnustep/2018-07/msg00005.html
There are several unrelated issues:
1. Some PPD files contain (valid) lines like the following:
*PrintQuality Draft/Draft:
This results in exception when parsing (example file at
http://lists.gnu.org/archive/html/discuss-gnustep/2018-07/msg00017.html).
2. In NSPageLayout -tableView:objectValueForTableColumn:row: the margins for
the standard papers are not correctly computed. imageRect already has the
printable margins but that is not taken into account so an expression like
paperSize.height - imageRect.size.height makes the topMargin twice larger than
it should be. Likewise for rightMargin. Also, the result is actually in pts
which gives funny figures; it should be converted to cm/in.
3. In NSPrintInfo -initWithDictionary: the margins should be set according to
ImageableArea as the FIXME comment says.
4. When a page with short text (few lines) has to be printed, the text does
not appear at the top of the page, as is expected, but is shifted way down
below. That's the most annoying item. There are some changes by Greg in the
"printing_fixes" branch which I think are related. I haven't tested them but
IMHO his approach is wrong and breaks printing of multiple pages (which
appears to be working correctly right now).
The attached patch fixes all 4 issues for me although I admit I'm not sure
whether it is correct. The whole repagination logic seems way too
awkward/convoluted to me and breaks reasonable WYSIWYG expectations.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 13 Jul 2018 06:45:26 PM EEST Name:
0001-Miscellaneous-printing-fixes.patch Size: 4KiB By: yavor
<http://savannah.gnu.org/bugs/download.php?file_id=44553>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?54307>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [bug #54307] Wrong margins especially when printing one page,
Yavor Doganov <=
- [bug #54307] Wrong margins especially when printing one page , Fred Kiefer, 2018年07月14日
- [bug #54307] Wrong margins especially when printing one page , Yavor Doganov, 2018年07月14日
- [bug #54307] Wrong margins especially when printing one page , Fred Kiefer, 2018年07月15日
- [bug #54307] Wrong margins especially when printing one page , Yavor Doganov, 2018年07月16日
- [bug #54307] Wrong margins especially when printing one page , Fred Kiefer, 2018年07月17日
- [bug #54307] Wrong margins especially when printing one page , Yavor Doganov, 2018年07月17日
- [bug #54307] Wrong margins especially when printing one page , Fred Kiefer, 2018年07月27日