[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[bug #52494] Does not handle exceptions when loading translations
From:
Yavor Doganov
Subject:
[bug #52494] Does not handle exceptions when loading translations
Date:
2017年11月24日 09:36:31 -0500 (EST)
User-agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.89 Safari/537.36
URL:
<http://savannah.gnu.org/bugs/?52494>
Summary: Does not handle exceptions when loading translations
Project: GNUstep
Submitted by: yavor
Submitted on: Fri 24 Nov 2017 04:36:29 PM EET
Category: Gorm
Severity: 3 - Normal
Item Group: Bug
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
I tried to translate a .gorm file using Gorm's Document->Translate feature.
Exported the strings fine but couldn't load the translated .strings file. I
selected the file in the open panel, pressed OK, the panel disappeared but
nothing happened. It took me some time to figure out what's going on...
The exported strings are unquoted when there is only one word and I simply
forgot to quote one translated string. So the exception that is rasied in
GSPropertyListFromStringsFormat is not caught by Gorm. IMHO this is not
proper behavior: Gorm should report the error, otherwise the user is left
wondering what actually happened. Also, you should not assume that
translators are aware that strings must be quoted, so I think it is a good
idea to provide them with some hint (using the established practice of
conveying information with a comment starting with "TRANSLATORS:").
Attached is a patch that fixes this issue. I see that the ChangeLog has not
been updated recently, but here is a suggested entry anyway:
2017年11月24日 Yavor Doganov <yavor@gnu.org>
* GormCore/GormDocument.m (translate:): Add exception handling
when loading translations.
(exportStrings:): Prepend notice for translators.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 24 Nov 2017 04:36:29 PM EET Name:
0001-Add-exception-handling-when-loading-translations.patch Size: 2KiB By:
yavor
<http://savannah.gnu.org/bugs/download.php?file_id=42468>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?52494>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [bug #52494] Does not handle exceptions when loading translations,
Yavor Doganov <=