[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
Re: patch suggestion for GSMime.m
From:
Fred Kiefer
Subject:
Re: patch suggestion for GSMime.m
Date:
2013年9月07日 18:13:04 +0200
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 06.09.2013 20:42, Pirmin Braun wrote:
> this was a bug for serveral years. Upload of Files with Umlaute in the
> filename didn't work.
> With this modification it works.
Hi Pirmin,
could you please give an example of a text wrongly decoded by the old
code and correctly handled by yours? By looking at the patch I don't see
how this would result in a better decoding.
There definitely is one problem with your code. After decoding with
NSISOLatin1StringEncoding failed this is no use to try
NSASCIIStringEncoding which is a strict subset.
This means the main change of your code is that you always use
NSISOLatin1StringEncoding first, where the old code only did this for
flags.isHttp == 1. The second difference is that you don't try the
_defaultEncoding. Which of these should make the difference?
Fred
- patch suggestion for GSMime.m , Pirmin Braun, 2013年09月06日
- Re: patch suggestion for GSMime.m,
Fred Kiefer <=
- Re: patch suggestion for GSMime.m , Pirmin Braun, 2013年09月07日
- Re: patch suggestion for GSMime.m , Richard Frith-Macdonald, 2013年09月08日
- Re: patch suggestion for GSMime.m , Pirmin Braun, 2013年09月08日
- Re: patch suggestion for GSMime.m , Richard Frith-Macdonald, 2013年09月09日
- Re: patch suggestion for GSMime.m , Richard Frith-Macdonald, 2013年09月09日
- Re: patch suggestion for GSMime.m , Pirmin Braun, 2013年09月09日
- better patch suggestion for GSMime.m , Pirmin Braun, 2013年09月09日
- Re: better patch suggestion for GSMime.m , Richard Frith-Macdonald, 2013年09月09日
- Re: better patch suggestion for GSMime.m , Fred Kiefer, 2013年09月09日