Re: [PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h

From: Bart Van Assche
Date: Sun Feb 28 2021 - 17:08:41 EST

Next message: kernel test robot: "drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.h:34:1: warning: no previous prototype for function 'mlx5_esw_indir_table_init'"
Previous message: syzbot: "INFO: task hung in io_sq_thread_park"
In reply to: Alexey Dobriyan: "[PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h"
Next in thread: Alexey Dobriyan: "[PATCH 06/11] pragma once: convert include/linux/cb710.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 2/28/21 9:01 AM, Alexey Dobriyan wrote:
> This file has broken include guard which is not obvious just by looking
> at the code. Convert it manually. I think I got #endif right.

Why do you think that the include guard is broken? Please mention this
in the patch description.

> -
> -#ifndef __QLA_TARGET_H
> -#define __QLA_TARGET_H
> -
> +#pragma once
> #include "qla_def.h"
> #include "qla_dsd.h"

Please insert a blank line between #pragma once and the #include directives.

Thanks,

Bart.

Next message: kernel test robot: "drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.h:34:1: warning: no previous prototype for function 'mlx5_esw_indir_table_init'"
Previous message: syzbot: "INFO: task hung in io_sq_thread_park"
In reply to: Alexey Dobriyan: "[PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h"
Next in thread: Alexey Dobriyan: "[PATCH 06/11] pragma once: convert include/linux/cb710.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]