Re: [PATCH] banalabs: Switch to using the new API kobj_to_dev()
From: Oded Gabbay
Date: Sun Feb 28 2021 - 15:14:22 EST
On Tue, Feb 23, 2021 at 11:12 AM Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:
>
>
fixed the following coccicheck:
>
./drivers/misc/habanalabs/common/sysfs.c:347:60-61: WARNING opportunity
>
for kobj_to_dev()
>
>
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
>
---
>
drivers/misc/habanalabs/common/sysfs.c | 2 +-
>
1 file changed, 1 insertion(+), 1 deletion(-)
>
>
diff --git a/drivers/misc/habanalabs/common/sysfs.c b/drivers/misc/habanalabs/common/sysfs.c
>
index 4366d8f..79c1ddf 100644
>
--- a/drivers/misc/habanalabs/common/sysfs.c
>
+++ b/drivers/misc/habanalabs/common/sysfs.c
>
@@ -344,7 +344,7 @@ static ssize_t eeprom_read_handler(struct file *filp, struct kobject *kobj,
>
struct bin_attribute *attr, char *buf, loff_t offset,
>
size_t max_size)
>
{
>
- struct device *dev = container_of(kobj, struct device, kobj);
>
+ struct device *dev = kobj_to_dev(kobj);
>
struct hl_device *hdev = dev_get_drvdata(dev);
>
char *data;
>
int rc;
>
--
>
1.8.3.1
>
Reviewed-by: Oded Gabbay <ogabbay@xxxxxxxxxx>
Applied to -next.
Thanks,
Oded