Re: [PATCH 09/11] pragma once: convert scripts/selinux/genheaders/genheaders.c
From: Alexey Dobriyan
Date: Sun Feb 28 2021 - 13:58:02 EST
On Sun, Feb 28, 2021 at 01:37:41PM -0500, Paul Moore wrote:
>
On Sun, Feb 28, 2021 at 12:04 PM Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
>
>
> From 097f2c8b2af7d9e88cff59376ea0ad51b95341cb Mon Sep 17 00:00:00 2001
>
> From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
>
> Date: Tue, 9 Feb 2021 00:39:23 +0300
>
> Subject: [PATCH 09/11] pragma once: convert scripts/selinux/genheaders/genheaders.c
>
>
>
> Generate security/selinux/flask.h and security/selinux/av_permissions.h
>
> without include guards.
>
>
>
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
>
> ---
>
> scripts/selinux/genheaders/genheaders.c | 6 ++----
>
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>
My LKML subscription must have died at some point due to mail bounces,
>
or maybe I dopped it (?), because I'm not seeing the rest of this
>
patchset for context.
>
>
However, unless the rest of the kernel transitions to this, or there
>
is some other big win that I'm missing, I don't see much of a reason
>
for this; can you provide some compelling reason for why we should
>
make this change? A quick search on "#pragma once" seems to indicate
>
it is non-standard, so why replace the simple #ifdef/#define solution
>
for this?
See
https://lore.kernel.org/lkml/CAHk-=wjFWZMVWTbvUMVxQqGKvGMC_BNrahCtTkpEjxoC0k-T=A@xxxxxxxxxxxxxx/T/#t