Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency
From: Vladimir Oltean
Date: Fri Feb 26 2021 - 16:32:20 EST
On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote:
>
From: Arnd Bergmann <arnd@xxxxxxxx>
>
>
When the ocelot driver code is in a library, the dsa tag
>
code cannot be built-in:
>
>
ld.lld: error: undefined symbol: ocelot_can_inject
>
>>> referenced by tag_ocelot_8021q.c
>
>>> dsa/tag_ocelot_8021q.o:(ocelot_xmit) in archive net/built-in.a
>
>
ld.lld: error: undefined symbol: ocelot_port_inject_frame
>
>>> referenced by tag_ocelot_8021q.c
>
>>> dsa/tag_ocelot_8021q.o:(ocelot_xmit) in archive net/built-in.a
>
>
Building the tag support only really makes sense for compile-testing
>
when the driver is available, so add a Kconfig dependency that prevents
>
the broken configuration while allowing COMPILE_TEST alternative when
>
MSCC_OCELOT_SWITCH_LIB is disabled entirely. This case is handled
>
through the #ifdef check in include/soc/mscc/ocelot.h.
>
>
Fixes: 0a6f17c6ae21 ("net: dsa: tag_ocelot_8021q: add support for PTP timestamping")
>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
---
Acked-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>