Re: [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node
From: Stephen Boyd
Date: Fri Feb 26 2021 - 13:47:54 EST
Quoting Sai Prakash Ranjan (2021年02月25日 23:51:00)
>
On 2021年02月26日 01:11, Stephen Boyd wrote:
>
> Quoting Sai Prakash Ranjan (2021年02月25日 01:30:24)
>
>> Add a DT node for the AOSS QMP on SC7280 SoC.
>
>>
>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>
>
>> ---
>
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 14 ++++++++++++++
>
>> 1 file changed, 14 insertions(+)
>
>>
>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>
>> index 65c1e0f2fb56..cbd567ccc04e 100644
>
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>
>> @@ -9,6 +9,7 @@
>
>> #include <dt-bindings/clock/qcom,rpmh.h>
>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
>> #include <dt-bindings/mailbox/qcom-ipcc.h>
>
>> +#include <dt-bindings/power/qcom-aoss-qmp.h>
>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>
>>
>
>> / {
>
>> @@ -368,6 +369,19 @@ pdc: interrupt-controller@b220000 {
>
>> interrupt-controller;
>
>> };
>
>>
>
>> + aoss_qmp: qmp@c300000 {
>
>
>
> power-domain-controller@c300000? power-controller@c300000?
>
>
>
>
Its an AOSS message RAM and all other SM* SoCs have as qmp@
>
and the dt binding as well, I see only SM8150 with power-controller,
>
that should probably be fixed?
Node name should be generic while still being meaningful. Nobody knows
what qmp is, but power-controller makes sense. Can you fix this and the
others to be power-controller?