Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
From: Andy Shevchenko
Date: Fri Feb 26 2021 - 12:07:15 EST
On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote:
>
When requesting optional GPIO echo line, bail out on error,
>
so user will know that something wrong with the existing property.
Guys, any comments on this series?
>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
---
>
drivers/pps/clients/pps-gpio.c | 10 +++++-----
>
1 file changed, 5 insertions(+), 5 deletions(-)
>
>
diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
>
index e0de1df2ede0..f89c31aa66f1 100644
>
--- a/drivers/pps/clients/pps-gpio.c
>
+++ b/drivers/pps/clients/pps-gpio.c
>
@@ -119,12 +119,12 @@ static int pps_gpio_setup(struct platform_device *pdev)
>
data->echo_pin = devm_gpiod_get_optional(&pdev->dev,
>
"echo",
>
GPIOD_OUT_LOW);
>
- if (data->echo_pin) {
>
- if (IS_ERR(data->echo_pin)) {
>
- dev_err(&pdev->dev, "failed to request ECHO GPIO\n");
>
- return PTR_ERR(data->echo_pin);
>
- }
>
+ if (IS_ERR(data->echo_pin)) {
>
+ dev_err(&pdev->dev, "failed to request ECHO GPIO\n");
>
+ return PTR_ERR(data->echo_pin);
>
+ }
>
>
+ if (data->echo_pin) {
>
ret = of_property_read_u32(np,
>
"echo-active-ms",
>
&value);
>
--
>
2.30.0
>
--
With Best Regards,
Andy Shevchenko