Re: [PATCH] [v2] spi: rockchip: avoid objtool warning
From: Pratyush Yadav
Date: Fri Feb 26 2021 - 10:55:45 EST
On 26/02/21 03:00PM, Arnd Bergmann wrote:
>
From: Arnd Bergmann <arnd@xxxxxxxx>
>
>
Building this file with clang leads to a an unreachable code path
>
causing a warning from objtool:
>
>
drivers/spi/spi-rockchip.o: warning: objtool: rockchip_spi_transfer_one()+0x2e0: sibling call from callable instruction with modified stack frame
>
>
Change the unreachable() into an error return that can be
>
handled if it ever happens, rather than silently crashing
>
the kernel.
>
>
Fixes: 65498c6ae241 ("spi: rockchip: support 4bit words")
>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Acked-by: Pratyush Yadav <p.yadav@xxxxxx>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.