Re: spdx spring cleaning
From: Greg Kroah-Hartman
Date: Fri Feb 26 2021 - 07:59:30 EST
On Fri, Feb 26, 2021 at 01:32:04PM +0100, Rasmus Villemoes wrote:
>
Hi,
>
>
I was doing some 'git grep SPDX-License-Identifier' statistics, but
>
noticed that I had to do a lot more normalization than expected (clearly
>
handling different comment markers is needed).
>
>
How about running something like the below after -rc1? The end result is
>
>
2558 files changed, 2558 insertions(+), 2558 deletions(-)
>
>
mostly from the last fixup, before that it's merely
>
>
90 files changed, 90 insertions(+), 90 deletions(-)
>
>
Rasmus
>
>
#!/bin/sh
>
>
fixup() {
>
gp="1ドル"
>
cmd="2ドル"
>
>
git grep --files-with-matches "SPDX-License-Identifier:$gp" | grep
>
-v COPYING | \
>
xargs -r -P8 sed -E -s -i -e "1,3 { /SPDX-License-Identifier/ {
>
$cmd } }"
>
git diff --stat | tail -n1
>
}
>
>
# tab->space, the first string is "dot asterisk tab"
>
fixup '.* ' 's/\t/ /g'
>
>
# trailing space
>
fixup '.* $' 's/ *$//'
>
>
# collapse multiple spaces
>
fixup '.* ' 's/ */ /g'
>
>
# or -> OR
>
fixup '.* or ' 's/ or / OR /g'
>
>
# Remove outer parenthesis - when that pair is the only set of
>
# parenthesis. Only none or */ trailing comment marker is handled.
>
fixup ' (' 's|Identifier: \(([^()]*)\)( \*/)?$|Identifier: 1円2円|'
What exactly are you trying to "clean up" here? What tool are you using
that can not properly parse the tags that we currently have?
confused,
greg k-h