Re: [PATCH v1] xen: ACPI: Get rid of ACPICA message printing
From: Boris Ostrovsky
Date: Thu Feb 25 2021 - 18:23:15 EST
On 2/24/21 1:47 PM, Rafael J. Wysocki wrote:
>
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
>
The ACPI_DEBUG_PRINT() macro is used in a few places in
>
xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug
>
messages, but that is questionable, because that macro belongs to
>
ACPICA and it should not be used elsewhere. In addition,
>
ACPI_DEBUG_PRINT() requires special enabling to allow it to actually
>
print the message and the _COMPONENT symbol generally needed for
>
that is not defined in any of the files in question.
>
>
For this reason, replace all of the ACPI_DEBUG_PRINT() instances in
>
the Xen code with acpi_handle_debug() (with the additional benefit
>
that the source object can be identified more easily after this
>
change) and drop the ACPI_MODULE_NAME() definitions that are only
>
used by the ACPICA message printing macros from that code.
>
>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>