Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused
From: Andrew Lunn
Date: Thu Feb 25 2021 - 17:55:03 EST
On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote:
>
From: Arnd Bergmann <arnd@xxxxxxxx>
>
>
When CONFIG_PM_SLEEP is disabled, the compiler warns about unused
>
functions:
>
>
drivers/net/phy/phy_device.c:273:12: error: unused function 'mdio_bus_phy_suspend' [-Werror,-Wunused-function]
>
static int mdio_bus_phy_suspend(struct device *dev)
>
drivers/net/phy/phy_device.c:293:12: error: unused function 'mdio_bus_phy_resume' [-Werror,-Wunused-function]
>
static int mdio_bus_phy_resume(struct device *dev)
>
>
The logic is intentional, so just mark these two as __maybe_unused
>
and remove the incorrect #ifdef.
>
>
Fixes: 4c0d2e96ba05 ("net: phy: consider that suspend2ram may cut off PHY power")
>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew