Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus
From: Doug Anderson
Date: Thu Feb 25 2021 - 17:27:16 EST
Hi,
On Thu, Feb 25, 2021 at 2:13 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
>
This is a trogdor variant. This is mostly a grab from the downstream
>
tree with notable exceptions:
>
- I skip -rev0. This was a super early build and there's no advantage
>
of long term support.
>
- In -rev1 I translate the handling of the USB hub like is done for
>
similar boards. See the difference between the downstream and
>
upstream 'sc7180-trogdor-lazor-r0.dts' for an example. This will
>
need to be resolved when proper support for the USB hub is figured
>
out upstream.
>
- I remove sound node since sound hasn't landed upstream yet.
>
- In incorporate the pending <https://crrev.com/c/2719075> for the
>
keyboard.
>
>
Cc: Philip Chen <philipchen@xxxxxxxxxx>
>
Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
>
Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
Cc: Tzung-Bi Shih <tzungbi@xxxxxxxxxxxx>
>
Cc: Judy Hsiao <judyhsiao@xxxxxxxxxxxx>
>
Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
---
>
>
arch/arm64/boot/dts/qcom/Makefile | 4 +
>
.../dts/qcom/sc7180-trogdor-pompom-r1-lte.dts | 14 +
>
.../dts/qcom/sc7180-trogdor-pompom-r1.dts | 26 ++
>
.../dts/qcom/sc7180-trogdor-pompom-r2-lte.dts | 14 +
>
.../dts/qcom/sc7180-trogdor-pompom-r2.dts | 44 +++
>
.../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 288 ++++++++++++++++++
>
6 files changed, 390 insertions(+)
As always I see a typo right after I hit send. ${SUBJECT} should be
"trogdor-pompom", not "lazor-pompom" for this and the next patch. I
copy/pastad from the previous patch (limozeen _is_ actually a lazor)
and didn't adjust properly.
I'm happy with any:
* to spin a -r2
* for Bjorn to fix when landing
* for this just to land since it's a harmless typo.
In any case I won't spin for now but I wanted to reply so if I do spin
for another reason I'll won't forget. ;-)
-Doug