Re: [PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
From: Alex Deucher
Date: Thu Feb 25 2021 - 16:29:58 EST
On Thu, Feb 25, 2021 at 4:02 AM Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:
>
>
Fix the following coccicheck warning:
>
./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING:
>
fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING:
>
fops_sclk_set should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
>
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
Applied. Thanks!
Alex
>
---
>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++--
>
1 file changed, 2 insertions(+), 2 deletions(-)
>
>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>
index 0a25fec..52ef488 100644
>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>
@@ -1586,10 +1586,10 @@ static int amdgpu_debugfs_sclk_set(void *data, u64 val)
>
return 0;
>
}
>
>
-DEFINE_SIMPLE_ATTRIBUTE(fops_ib_preempt, NULL,
>
+DEFINE_DEBUGFS_ATTRIBUTE(fops_ib_preempt, NULL,
>
amdgpu_debugfs_ib_preempt, "%llu\n");
>
>
-DEFINE_SIMPLE_ATTRIBUTE(fops_sclk_set, NULL,
>
+DEFINE_DEBUGFS_ATTRIBUTE(fops_sclk_set, NULL,
>
amdgpu_debugfs_sclk_set, "%llu\n");
>
>
int amdgpu_debugfs_init(struct amdgpu_device *adev)
>
--
>
1.8.3.1
>
>
_______________________________________________
>
dri-devel mailing list
>
dri-devel@xxxxxxxxxxxxxxxxxxxxx
>
https://lists.freedesktop.org/mailman/listinfo/dri-devel