Re: [PATCH] crypto/nx: add missing call to of_node_put()
From: Michael Ellerman
Date: Thu Feb 25 2021 - 06:16:49 EST
Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> writes:
>
In one of the error paths of the for_each_child_of_node() loop,
>
add missing call to of_node_put().
>
>
Fix the following coccicheck warning:
>
./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function
>
"for_each_child_of_node" should have of_node_put() before return around
>
line 936.
>
>
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
>
---
>
drivers/crypto/nx/nx-common-powernv.c | 1 +
>
1 file changed, 1 insertion(+)
>
>
diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c
>
index 13c65de..b43c457 100644
>
--- a/drivers/crypto/nx/nx-common-powernv.c
>
+++ b/drivers/crypto/nx/nx-common-powernv.c
>
@@ -933,6 +933,7 @@ static int __init nx_powernv_probe_vas(struct device_node *pn)
>
NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip);
>
>
if (ret)
>
+ of_node_put(dn);
>
return ret;
Sorry this is wrong, the if needs braces.
cheers