Re: [PATCH] ocfs2: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
From: Joseph Qi
Date: Wed Feb 24 2021 - 20:59:33 EST
On 2/24/21 4:27 PM, Yang Li wrote:
>
Fix the following coccicheck warning:
>
./fs/ocfs2/blockcheck.c:232:0-23: WARNING: blockcheck_fops should be
>
defined with DEFINE_DEBUGFS_ATTRIBUTE
>
>
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
Acked-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
>
---
>
fs/ocfs2/blockcheck.c | 2 +-
>
1 file changed, 1 insertion(+), 1 deletion(-)
>
>
diff --git a/fs/ocfs2/blockcheck.c b/fs/ocfs2/blockcheck.c
>
index 6e07ddb..dabfef9 100644
>
--- a/fs/ocfs2/blockcheck.c
>
+++ b/fs/ocfs2/blockcheck.c
>
@@ -229,7 +229,7 @@ static int blockcheck_u64_get(void *data, u64 *val)
>
*val = *(u64 *)data;
>
return 0;
>
}
>
-DEFINE_SIMPLE_ATTRIBUTE(blockcheck_fops, blockcheck_u64_get, NULL, "%llu\n");
>
+DEFINE_DEBUGFS_ATTRIBUTE(blockcheck_fops, blockcheck_u64_get, NULL, "%llu\n");
>
>
static void ocfs2_blockcheck_debug_remove(struct ocfs2_blockcheck_stats *stats)
>
{
>