Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag
From: Yicong Yang
Date: Wed Feb 24 2021 - 04:58:11 EST
On 2021年2月10日 19:42, Daniel Thompson wrote:
>
On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote:
>
> On 2021年2月8日 18:47, Greg KH wrote:
>
>> On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote:
>
>>> On 2021年2月5日 17:53, Greg KH wrote:
>
>>>> What does this offer in benefit of the existing way? What is it fixing?
>
>>>> Why do this "churn"?
>
>>>
>
>>> currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile
>
>>> of driver/base and driver/base/power, but not in the subdirectory
>
>>> driver/base/firmware_loader. we cannot turn the debug on for subdirectory
>
>>> firmware_loader if we config DEBUG_DRIVER and there is no kconfig option
>
>>> for the it.
>
>>
>
>> Is that necessary? Does that directory need it?
>
>
>
> there are several debug prints in firmware_loader/main.c:
>
>
>
> ./main.c:207: pr_debug("%s: fw-%s fw_priv=%p\n", __func__, fw_name, fw_priv);
>
> ./main.c:245: pr_debug("batched request - sharing the same struct fw_priv and lookup for multiple requests\n");
>
> <snip>
>
>
Even if these are not in scope for CONFIG_DEBUG_DRVIER there is a
>
config option that would allow you to observe them without changing
>
any code (CONFIG_DYNAMIC_DEBUG).
>
yes. they're two mechanisms of debug. i think it's the right thing to make
both work properly.
>
>
Daniel.
>
>
.
>