Commit df07459

author

Reini Urban

committed

coverity: fix write_write_typo: In asmb = asmb =

Evaluation order violation asmb is written twice with the same value. Declare all malloc results as volatile.

1 parent 962d954 commit df07459Copy full SHA for df07459

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,8 @@`
`12`	`12`
`13`	`13`	`PNAsm potion_asm_new(Potion P) {`
`14`	`14`	`int siz = ASM_UNIT - sizeof(PNAsm);`
`15`		`- PNAsm * volatile asmb = PN_FLEX_NEW(asmb, PN_TBYTES, PNAsm, siz);`
	`15`	`+ PNAsm * volatile asmb;`
	`16`	`+ PN_FLEX_NEW(asmb, PN_TBYTES, PNAsm, siz);`
`16`	`17`	`return asmb;`
`17`	`18`	`}`
`18`	`19`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,10 @@ struct Potion_State;`
`9`	`9`
`10`	`10`	`typedef unsigned char u8;`
`11`	`11`
`12`		`-#define PN_ALLOC(V,T) (T *)potion_gc_alloc(P, V, sizeof(T))`
`13`		`-#define PN_ALLOC_N(V,T,C) (T *)potion_gc_alloc(P, V, sizeof(T)+C)`
`14`		`-#define PN_CALLOC_N(V,T,C) (T *)potion_gc_calloc(P, V, sizeof(T)+C)`
`15`		`-#define PN_REALLOC(X,V,T,N) (X)=(T )potion_gc_realloc(P, V, (struct PNObject )(X), sizeof(T) + N)`
	`12`	`+#define PN_ALLOC(V,T) (T * volatile)potion_gc_alloc(P, V, sizeof(T))`
	`13`	`+#define PN_ALLOC_N(V,T,C) (T * volatile)potion_gc_alloc(P, V, sizeof(T)+C)`
	`14`	`+#define PN_CALLOC_N(V,T,C) (T * volatile)potion_gc_calloc(P, V, sizeof(T)+C)`
	`15`	`+#define PN_REALLOC(X,V,T,N) (X)=(T * volatile)potion_gc_realloc(P, V, (struct PNObject *)(X), sizeof(T) + N)`
`16`	`16`	`#define PN_DALLOC_N(T,N) potion_data_alloc(P, sizeof(T)*N)`
`17`	`17`	`#define PN_STRDUP(S) PN_STR(S)`
`18`	`18`

Comments

(0)