-
-
Notifications
You must be signed in to change notification settings - Fork 294
Remove UniqueLocks and UpgradeToUnique #220
bpmckinnon
started this conversation in
General
-
I was looking at the new ReadWriteLock change and I'm wondering if UniqueLocks and UpgradeToUnique should be removed to enforce a single mechanism for upgrading locks. Is there any plan to remove it?
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 2 comments
-
Yes, I think I should remove UpgradeToUnique and update the one location where it is used, thanks for the reminder. I'll have to think some more about UniqueLocks.
Beta Was this translation helpful? Give feedback.
All reactions
0 replies
-
UniqueLocks is still used in merge (see this). What do you think of this PR #221 for removing the unused Upgrade stuff?
Beta Was this translation helpful? Give feedback.
All reactions
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment