Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(@angular/build): fix setup files duplicate modules #31791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yjaaidi wants to merge 2 commits into angular:main
base: main
Choose a base branch
Loading
from yjaaidi:fix/fix-test-bed-usage-in-setup-files

Conversation

@yjaaidi
Copy link
Contributor

@yjaaidi yjaaidi commented Nov 13, 2025 •
edited
Loading

This includes setup files in the initial build and avoids lazy discovery and thus module duplicates.
Module duplicates can break many things such as dependency injection.

⚠️ this only handles setupFiles directly provided to the builder.
Handling setupFiles from the Vitest config requires substantial additional effort.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31732

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

 

This includes setup files in the initial build and avoids lazy discovery and thus module duplicates.
Module duplicates can break many things such as dependency injection.
Closes angular#31732
Copy link
Contributor Author

yjaaidi commented Nov 13, 2025

I tried to keep this the less intrusive possible but I wonder if the right fix wouldn't involve changes to TestRunner API.
Feel free to either pick this a quick fix and revert it after the release for a proper fix, or just see it as a spike and throw it away 😊

* @param options Configuration options for generating entry points.
* @returns A map where keys are the generated unique bundle names and values are the original file paths.
*/
export function getSetupEntrypoints(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not happy with this.
I would rather have a single getEntrypoints that returns both test files and setup files then we would have to forward the setup file names to the executor somehow.

projectSourceRoot,
workspaceRoot,
removeTestExtension,
prefix: 'setup',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces bundles named setup-test-setup which is weird.
An empty string would be better but collisions could happen with a setup file called spec-setup... or something.

@hybrist hybrist added angular/build:unit-test action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clydin clydin Awaiting requested review from clydin

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer angular/build:unit-test area: @angular/build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /