This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2007年08月25日 11:25 by larry, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| lch.py3k.curses.module.diff.1.txt | larry, 2007年08月25日 11:25 | |||
| Messages (4) | |||
|---|---|---|---|
| msg55287 - (view) | Author: Larry Hastings (larry) * (Python committer) | Date: 2007年08月25日 11:25 | |
*BEFORE* APPLYING THIS PATCH, YOU MUST % svn move Include/py_curses.h Modules/_py_curses.h (A "patch" can't convey that sort of information.) I made a pass cleaning up _curses and _curses_panel. Mainly I cleaned up the header file, moving unnecessary things into the two .c files. I also changed the way information is passed from _curses to _curses_panel. Instead of a Py_CObject which points to functions--which Neil Norwitz suspected could be a security hole--it now passes cleaner information (one type, one int * pointer). Finally, I made a code-cleanup pass as per PEP 7. |
|||
| msg55435 - (view) | Author: Guido van Rossum (gvanrossum) * (Python committer) | Date: 2007年08月29日 20:40 | |
I tried to run the various demos in Demo/curses/ with the new version. They all work except for xmas.py. Before your patch, they all ran. So I cannot apply this yet. (No time to look into it further, alas.) |
|||
| msg55866 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2007年09月12日 19:36 | |
Unfortunately, the patch is hard to review with all the whitespace cleanup distracting from semantic changes. Can you produce a patch with only those changes? |
|||
| msg99878 - (view) | Author: Larry Hastings (larry) * (Python committer) | Date: 2010年02月22日 23:49 | |
The major reason I undertook this patch was to fix the security hole of the CObject. That entire class of security holes is now fixed by the capsule object. The rest of the diffs aren't interesting enough to worry about. So I'm abandoning my patch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:26 | admin | set | github: 45360 |
| 2010年02月22日 23:49:17 | larry | set | status: open -> closed resolution: rejected messages: + msg99878 |
| 2008年01月13日 23:43:33 | akuchling | set | assignee: akuchling -> |
| 2008年01月12日 01:17:28 | akuchling | set | assignee: akuchling nosy: + akuchling |
| 2007年09月17日 10:52:19 | jafo | set | priority: low |
| 2007年09月12日 19:36:08 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg55866 |
| 2007年09月02日 20:08:07 | loewis | set | keywords: + patch |
| 2007年08月29日 20:40:27 | gvanrossum | set | nosy:
+ gvanrossum messages: + msg55435 |
| 2007年08月25日 11:25:16 | larryhastings | create | |