Re: [PATCH v4 1/4] xhci: Add host support for eUSB2 double isochronous bandwidth devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


(追記) (追記ここまで)



Hi Michał,
Thanks for the review.
On Mon, Aug 18, 2025 at 11:50:16AM +0200, Michał Pecio wrote:
> > @@ -1351,8 +1369,18 @@ static u32 xhci_get_endpoint_max_burst(struct usb_device *udev,
> > 
> > 	if (udev->speed == USB_SPEED_HIGH &&
> > 	 (usb_endpoint_xfer_isoc(&ep->desc) ||
> > -	 usb_endpoint_xfer_int(&ep->desc)))
> > +	 usb_endpoint_xfer_int(&ep->desc))) {
> > +		/*
> > +		 * eUSB2 double isoc bw endpoints max packet field service
> > +		 * opportunity bits 12:11 are not valid, so set the ctx burst to
> > +		 * max service opportunity "2" as these eps support transferring
> > +		 * over 3072 bytes per interval
> > +		 */
>
> I think a shorter comment would suffice: eUSB2 BWD uses fixed burst
> size and max packets bits 12:11 are invalid.
I'll use this:
+ * eUSB2 double isochronous BW ECN uses fixed burst size and max
+ * packets bits 12:11 are invalid.
-- 
Sakari Ailus

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

(追記) (追記ここまで)
Powered by Linux

AltStyle によって変換されたページ (->オリジナル) /