Re: [PATCH RFC 01/22] dt-bindings: usb: snps,dwc3: Allow multiple iommus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


(追記) (追記ここまで)



On 24.08.25 10:31, Krzysztof Kozlowski wrote:
On 22/08/2025 09:22, Krzysztof Kozlowski wrote:
On Thu, Aug 21, 2025 at 03:38:53PM +0000, Sven Peter wrote:
Apple's dwc3 variant requires two iommus.
Signed-off-by: Sven Peter <sven@xxxxxxxxxx>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 4380bb6fa2f08a475b557e80467abc2861f622e2..6d35dcc605c01977f4fc6fdb6f12976f1cef2b9e 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -60,7 +60,7 @@ properties:
 dma-coherent: true
iommus:
- maxItems: 1
+ maxItems: 2
Never tested. You anyway need specific constraints.
I realized that's pretty vague, so clarifying: you changed all bindings
to have two iommus and that's unexpected. All other devices have only
one IOMMU mapping here, so they need to stay like that. If these IOMMUs
differ, you should also list them, but probably that's not the case here.
Makes sense, thanks for the detailed explanation.
I don't quite understand why this controller needs two iommus but they must essentially be programmed to the same mapping for xhci to work. All of device mode goes through one of them and xhci buffers are split between the two iommus (iirc I saw the command ring using the first one and the event ring the second one and then just decided to program them the same since anything else would result in a big mess).
Thanks,
Sven

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

(追記) (追記ここまで)
Powered by Linux

AltStyle によって変換されたページ (->オリジナル) /