Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
From: Linus Walleij <linus.walleij@xxxxxxxxxx>
Date: 2025年8月19日 14:55:59 +0200
In-reply-to: <20250818-modularize-sx150x-gpio-expander-v1-1-c2a027200fed@oss.qualcomm.com>
References: <20250818-modularize-sx150x-gpio-expander-v1-0-c2a027200fed@oss.qualcomm.com> <20250818-modularize-sx150x-gpio-expander-v1-1-c2a027200fed@oss.qualcomm.com>

On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
<fange.zhang@xxxxxxxxxxxxxxxx> wrote:
> Set PINCTRL_SX150X config option as a tristate and add
> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>
> Signed-off-by: Fange Zhang <fange.zhang@xxxxxxxxxxxxxxxx>
Fair enough!
This patch 1/2 applied to the pinctrl tree.
Please funnel patch 2/2 through the SoC tree.
> subsys_initcall(sx150x_init
I seriously wonder about this. It feels like this driver should
be a pure module_init() device. But other users may disagree.
Yours,
Linus Walleij

Follow-Ups:
- Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
  - From: Fange Zhang

References:
- [PATCH 0/2] Modularize SX150X GPIO expander
  - From: Fange Zhang
- [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
  - From: Fange Zhang

Prev by Date: Re: [PATCH 1/2] powerpc/44x: Change GPIO driver to a proper platform driver
Next by Date: Re: [PATCH] gpio: mpc5200: Drop legacy-of-mm-gpiochip.h header
Previous by thread: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
Next by thread: Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
Index(es):
- Date
- Thread

[Index of Archives] [Linux SPI] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]

(追記) (追記ここまで)