On Sun, Aug 31, 2025 at 5:55 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > The fact that the call to gpio_request() is still there made me think > immediately that the conversion is incomplete. I looked into why you > didn't change that and noticed that the global GPIO number comes > through platform data, specifically: struct tlv320dac33_platform_data. > That platform data struct however is not used in the kernel -and even > the header that defines it - sound/tlv320dac33-plat.h - is never > included outside of the driver. Seems to me like the main obstacle to > completing the conversion is not even used in mainline and can be > dropped? > > Bart Since struct tlv320dac33_platform_data isn't used in the kernel and the corresponding header file it's in isn't used outside of the driver, I'll go ahead and drop them and send in a v2. Thanks for the review. -- Alex Tran