Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




El 03/09/2025 a las 9:21, Lee Jones escribió:
>> vortex_dx_sb are "struct vortex_southbridge" type, not raw MFD API data.
>
> I like your style, but nope!
>
> vortex_southbridge contains MFD data and shouldn't exist anyway.
I'm not sure if I follow.
You're suggesting not using driver_data at all and using a big "if" instead,
matching manually myself on the correct cells to register against the PCI
device ID, instead of relying on PCI matching giving me already the cells
structure inside driver_data?
That seems to increase code size and be more error prone for no reason.

[Index of Archives] [Linux SPI] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]

(追記) (追記ここまで)
Powered by Linux

AltStyle によって変換されたページ (->オリジナル) /