On Wed, Sep 03, 2025 at 12:08:27PM +0200, Krzysztof Kozlowski wrote: > On 13/08/2025 08:55, Pankaj Patil wrote: > > Add DeviceTree binding for Glymur SoC TLMM block > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > > > > Signed-off-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx> > > --- > > Changes in v5: > > Rebased on top of v6.17-rc1 > > > > + > > +properties: > > + compatible: > > + const: qcom,glymur-tlmm > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + gpio-reserved-ranges: > > + minItems: 1 > > + maxItems: 119 > > 124, I guess > > > > + > > + gpio-line-names: > > + maxItems: 250 > > + > > +patternProperties: > > + "-state$": > > + oneOf: > > + - $ref: "#/$defs/qcom-glymur-tlmm-state" > > + - patternProperties: > > + "-pins$": > > + $ref: "#/$defs/qcom-glymur-tlmm-state" > > + additionalProperties: false > > + > > +$defs: > > + qcom-glymur-tlmm-state: > > + type: object > > + description: > > + Pinctrl node's client devices use subnodes for desired pin configuration. > > + Client device subnodes use below standard properties. > > + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state > > + unevaluatedProperties: false > > + > > + properties: > > + pins: > > + description: > > + List of gpio pins affected by the properties specified in this > > + subnode. > > + items: > > + oneOf: > > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9])$" If it's up to 124, then this pattern is incorrect. > > + - enum: [ ufs_reset, sdc2_clk, sdc2_cmd, sdc2_data ] > > + minItems: 1 > > + maxItems: 36 > > + -- With best wishes Dmitry