Re: [PATCH RESEND 05/14] gpio: ts4800: use generic device properties

• Subject: Re: [PATCH RESEND 05/14] gpio: ts4800: use generic device properties
• From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
• Date: Wed, 3 Sep 2025 17:41:26 +0200
• In-reply-to: <20250825-gpio-mmio-gpio-conv-v1-5-356b4b1d5110@linaro.org>
• Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
• References: <20250825-gpio-mmio-gpio-conv-v1-0-356b4b1d5110@linaro.org> <20250825-gpio-mmio-gpio-conv-v1-5-356b4b1d5110@linaro.org>

On Mon, Aug 25, 2025 at 11:48:46AM +0200, Bartosz Golaszewski wrote:
>
> Avoid pulling in linux/of.h by using the generic device properties.
...
> -	retval = of_property_read_u32(node, "ngpios", &ngpios);
> +	retval = device_property_read_u32(dev, "ngpios", &ngpios);
> 	if (retval == -EINVAL)
> 		ngpios = DEFAULT_PIN_NUMBER;
> 	else if (retval)
Don't we have a method in GPIOLIB that does this (can be called explicitly by the drivers)?
-- 
With Best Regards,
Andy Shevchenko

• Follow-Ups:
  • Re: [PATCH RESEND 05/14] gpio: ts4800: use generic device properties
    • From: Bartosz Golaszewski

• References:
  • [PATCH RESEND 00/14] gpio: replace legacy bgpio_init() with its modernized alternative
    • From: Bartosz Golaszewski
  • [PATCH RESEND 05/14] gpio: ts4800: use generic device properties
    • From: Bartosz Golaszewski

• Prev by Date: Re: [PATCH RESEND 07/14] gpio: ts4800: use new generic GPIO chip API
• Next by Date: Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges
• Previous by thread: [PATCH RESEND 05/14] gpio: ts4800: use generic device properties
• Next by thread: Re: [PATCH RESEND 05/14] gpio: ts4800: use generic device properties
• Index(es):
  • Date
  • Thread