openstack/puppet-oslo - puppet-oslo - OpenDev: Free Software Needs Free Tools

Fix new lint errors detected when full of the voxpupili lint plugins
are enabled.
Change-Id: I8ebe256188945780f730ab51fc07ee55d2ecd508
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

The [oslo_messaging_rabbit] heartbeat_timeout_threshold option has no
longer been experimental since 9.6.0 (train)[1].
[1] 44bd971bfb134cd74d09322a6bfc7449e3be577e
Change-Id: Iccf9b7e62f86dc62b704a66ab43d608be35b04fe
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

Change-Id: I7069781a6f97beb626a8e79a03de9f4182e8372a

... because the actual option in oslo.messaging was deprecated.
Depends-on: https://review.opendev.org/925778
Change-Id: I4c6667dd4316ad3d7f40e706103b5fada215314b

Change-Id: I779ae835d29b24605c1651048a46b01c0a2587b2

Change-Id: I83db5307f526b5824e9cf3de2cfbff7abb11d443

Change-Id: I4bb86dddde72abf58359956ffd0ba9cca8281a3d

It was deprecated during the 2023.2 cycle[1], so can be removed now.
Also add validation about transport_url options to reject unsupported
drivers.
[1] e174113210
Depends-on: https://review.opendev.org/918774
Change-Id: I3c3b17b8109c84cc0cbfb4254cc969cc563265e4

... which is the option added during this cycle.
Change-Id: Ic851ec1cf8cbf85fd00dacf9637f619ed1804068

Change-Id: I2c948ae091ab6533022703afb7b5a05a278abcc0

Change-Id: Ic95ebf1128152bac120b3a3f3732c8bc5891c27b

The amqp1 driver has been deprecated in oslo.messaging because of
lack of qpid_dispatch module. This deprecates support for the driver.
Because deprecating all parameters for amqp1 driver needs large changes
in multiple modules, this change introduces the logic to detect usage
of amqp1 driver and shows the warning instead.
Depends-on: https://review.opendev.org/861070/
Change-Id: Ia176b8d881eb9bd1bb5e22b437b4e60ecd6963af

... because the latest lint no longer allows usage of legacy facts and
top scope fact.
Change-Id: Ib0bdb6329a438ac44886ee0494d0c52ad344a1bf

Change-Id: I3134bd39892f7d1412dd267e4995aaece87523c2

... because it was deprecated during Wallaby cycle[1].
[1] c08a99f05c
Change-Id: I4a76fb16e4fbb3711db5c86ab35000334e95c124

This change migrate the validation from puppet-designate/neutron to
the common place, because the requirement is valid for all components.
Change-Id: I0cbd9d22b53ae2f966f0a007231a9003dc03b36e

... and simplify how $::os_service_default, which is a String, is
handled.
Closes-Bug: #1939088
Change-Id: Iafb03a6cd57859d11713d12b1c939a9fe782ee65

The allow_insecure_clients has been deprecated[1].
[1]https://review.opendev.org/#/c/417629/
Change-Id: Id6b6ac8dd9532dd243f7b6af776a14bbb798c997
Closes-Bug: #1902158 

... because it was deprecated long ago and ZeroMQ driver was already
removed from oslo.messaging[1].
[1] f2fd8d437589d94443a137c7ca7a38d6b782d153
Change-Id: Ib66999db407f6b8872196f105e49a6296e42528a

We currently join the list into a comma-separated string.
This does not make a lot of sense because oslo messaging
notification drivers must not be passed in the driver=foo,bar form
but in the driver=foo\ndriver=bar form. See:
- https://docs.openstack.org/oslo.config/queens/configuration/format.html
multi valued (MultiStrOpt)
 A multi-valued option is a string value and can be given more than once, all values will be used.
 # Driver or drivers to handle sending notifications. (multi valued)
 notification_driver = nova.openstack.common.notifier.rpc_notifier
 notification_driver = ceilometer.compute.nova_notifier
By simply passing down the list we let all the puppet backends
that use the openstack_config:ruby backend to work correctly
(https://github.com/openstack/puppet-openstacklib#defined-provider-for-openstack_config-ruby)
This will fix the scenario where multiple notification drivers are
specified which is currently broken and will let the single driver
scenario to keep working as is.
Change-Id: If65946412b42e0919456ed92fdd8e3788ad67872
Related-Bug: #1851629 

oslo.messaging RabbitMQ driver have now a new option that allow user to
run the RabbitMQ AMQP heartbeat over a native python thread.
These change allow user to use this new option.
For further reading:
https://review.opendev.org/#/c/663074/
Change-Id: If5fb021a6864abbe95f4d23281484cb859537f3b

Adding configuration of the size of executor thread pool.
Change-Id: I36324bae39e05dde57b962948f832c22599c13d2

ZeroMQ is removed from oslo.messaging [1] so we can
remove all the behavior and just keep the interface
until the next release.
[1] https://review.openstack.org/#/c/596882/
Change-Id: I8edda9d72ed0256f8d6b5fd7a0c2fc8c297da448

Remove the deprecated options rabbit_host, rabbit_port, rabbit_hosts,
rabbit_userid, rabbit_password and rabbit_virtual_host [1].
All modules should support this change already or I have open patches
that fixes it.
Added a proper prelude notification that the functionality that
changed rabbit_ha_queues to true automatically if rabbit_hosts was
used is now removed so it has to be set explicitly.
[1] https://review.openstack.org/#/c/599912/
Depends-On: https://review.openstack.org/#/c/612190/
Depends-On: https://review.openstack.org/#/c/612191/
Change-Id: Ie151e1857e6e951c676986c6b2778db0d0a52819

The rabbit_max_retries parameter has been deprecated for one year.
We can remove it.
Change-Id: Ic6c3ae68ba30054644fde79b60b205546a3013d3

Change-Id: Ife3aec1bebe19cb1df26cb43baa55d9a07c96421

The rpc_backend configuration option has been deprecated in
oslo.messaging. The default and notitification transport_url
option defines the messaging backend and communication
parameters. Inclusion on zmq/rabbit options caused duplicate
declaration following deprecation of rpc_backend in service
modules.
This patch:
* remove parameter from zmq options
* remove parameter from rabbitmq option
* update spec test
Change-Id: Ia981f1a847a428e0f07656d0922e195982e4e2f9

Option "rabbit_max_retries" from group "oslo_messaging_rabbit" is
deprecated for removal. Its value may be silently ignored in the future.
Change-Id: I5071fdfc7ee109dfc34de7cd279e039c11cd2300
Closes-Bug: #1697350 

Change-Id: Ib301df384d271da27094376389e981fe51e39e5f

Change-Id: I4225c65f51ce8ab6c479c6fcb7362cb7f3c71370

Change-Id: I14251f9ebeae55c4b696162d8241c4e56ea125ca

Change-Id: Ida7de5b611ee74ebb86efe9c26a7e32db247dce8
Closes-Bug: #1676708 

The parameters for drivers in oslo.messaging are being standardized [1].
And part of this is also the sandarization of the TLS-related
parameters. As per a recent commit [2], the rabbitmq configuration
parameters have changed and the old names are being deprecated (although
they still work). This patch reflects that.
[1] https://etherpad.openstack.org/p/common_driver_config
[2] Ic32b2cb253fa0dc43aad7226b24919b7e588faa9
Change-Id: I8d41ec4e1a7bca3d114286a034f663c2a2c9b8d7
Depends-On: Iac788319caac7bb20b24ee1696d13b9ab15ca1c4
Depends-On: I7d69466479cc689d251665ff4a9affcd6503379a
Depends-On: I7d24d4bd2b77ef3dff8bb8ad703938399681573a
Depends-On: Ic078c7f036ce93fc91bd496884e4423b9653b1c8
Depends-On: I3472959e0be1e817caaecd36cf4c6c54485c6063
Depends-On: Ibb82146271482f6ae2db03e0e541cce8abe59409
Depends-On: I17b78a8f96b83bf647321d7096322d6e16a483c9
Depends-On: I60cc9bbe655d8dc7d08dd7a0d6466c7774b8f5a8
Depends-On: I3d56406f122299f16269cd910339ad09092bd3ab
Depends-On: Ibc69ae286d723ebecf8a86c247cf807ccf0604b4
Depends-On: I9296155ee865b35f67978fe1fc002a7feb5ab454
Depends-On: I2f0a392e4b0a7a7ab61cc1e853fca44c3b9cbe97
Depends-On: Iaa1aa2b14aa978d56a54695ddb8bbd0238ba1882
Depends-On: I26dae32b3093d25544542243697273238a18b078

This patch:
* Removes the [DEFAULT] rpc_backend as it lead to a duplicate
 declaration when dual oslo.messaging backends were used
* Removes the conversion of pre_settled as it was incorrect
 for the multiple line MultStrOpt value
Change-Id: I7ccd995ef01c2d54427684718adba054260fdd52

Change-Id: I92e6bd6ec17792ba3b2e228f024fa49ac748e4d8

As transport_url option contains rabbit_password,
it should not keep plaintext in logs.
Closes-Bug: #1640809
Change-Id: I958c51050ee48db1ee359ff75dc20ad13e14a672

Change-Id: Ib880afb93a30245940f70d51e2e4d6761ae69ecf

The rabbit connection parameters have been deprecated in oslo[0] in favor
of transport_url which is provided by oslo::messaging::default.
[0] https://review.openstack.org/#/c/317285/
Change-Id: Ia78fcca898aea28bfe436faa259544f5594a5af6

This change adds possibility to configure ZeroMQ messaging system
for openstack services.
Change-Id: Ic6a81926545fccb0945ee939c1ba69a62d6fdf5c

It is worth noting that one can specify several hosts on the
transport_url configuration options from oslo.messaging both for RPCs
and for notifications. So it will be useful for users of the module
to see the format.
Change-Id: Ia39f2e4e1ff3f02f1b14b56f985fae98446c6c10

We have different strategies in handling list
values. This patch is bringing the situation
to the consistent state in this question.
Arrays and csv-strings are allowed.
This allows to put this logic inside oslo module
and clean up code duplication in exterior modules
(which can just pass parameters to oslo).
Also patch bring a few updates to top-file docs
and tests.
Change-Id: I37a37d236e643d3cf39b46243119b8393a3feea7

* Update docs
* Update unit tests
Change-Id: I0392eb323b03d07f3e2204ff17ae7c4d02245145

* Add top-file docs
* Prepare/update unit tests
* Set "rpc_backend" in specialized resource (amqp/rabbit)
Change-Id: I87b815253b0a919e86d41434d09655930eb5aaf0

This patch adds a new class for managing oslo notifications
parameters.
[1] Ib51e2839f9035d0cc0e3f459939d9f9003a8c810
Change-Id: If2bf35c025c6c9a2a69a3f2381f0afd0dc93a2ec

Make define name more clear for users
(similar to oslo::messaging::amqp).
Change-Id: I675b4156e51a89c6a6f75e6a986dd45f51da7189

This patch aims to add a new define to manage parameters
in [oslo_messaging_amqp] which belongs to oslo.messaging.
Change-Id: If295b4375900f7f98d78deb7943d58f49fce811f