healthcheck: Add support for ignore_proxied_requests

Code Issues Proposed changes

The new ignore_proxied_requests option was added to the healthcheck
middleware which allows operators to prohibit access to healthcheck
information via load balancers. This introduces a new parameter which
corresponds to this option.
Depends-on: https://review.opendev.org/901215
Change-Id: Iaf9b40db938f998c20d6cea4b19cf09651c46bbf

This commit is contained in:

Takashi Kajinami

2024年02月22日 10:15:47 +09:00

parent 9175c459e4

commit ac79ad02bb

3 changed files with 28 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

13
spec/defines/oslo_healthcheck_spec.rb

View File

@@ -15,6 +15,7 @@ describe 'oslo::healthcheck' do

is_expected.to contain_keystone_config('healthcheck/detailed').with_value('<SERVICE DEFAULT>')

is_expected.to contain_keystone_config('healthcheck/backends').with_value('<SERVICE DEFAULT>')

is_expected.to contain_keystone_config('healthcheck/allowed_source_ranges').with_value('<SERVICE DEFAULT>')

is_expected.to contain_keystone_config('healthcheck/ignore_proxied_requests').with_value('<SERVICE DEFAULT>')

is_expected.to contain_keystone_config('healthcheck/disable_by_file_path').with_value('<SERVICE DEFAULT>')

is_expected.to contain_keystone_config('healthcheck/disable_by_file_paths').with_value('<SERVICE DEFAULT>')

end

@@ -23,14 +24,15 @@ describe 'oslo::healthcheck' do

context 'with parameters overridden' do

let :params do

{

:detailed => true,

:backends => ['disable_by_file', 'disable_by_files_ports'],

:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],

:disable_by_file_path => '/etc/keystone/healthcheck/disabled',

:disable_by_file_paths => [

:detailed => true,

:backends => ['disable_by_file', 'disable_by_files_ports'],

:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],

:disable_by_file_path => '/etc/keystone/healthcheck/disabled',

:disable_by_file_paths => [

'5000:/etc/keystone/healthcheck/public-disabled',

'35357:/etc/keystone/healthcheck/admin-disabled'

],

:ignore_proxied_requests => false,

}

end

@@ -42,6 +44,7 @@ describe 'oslo::healthcheck' do

is_expected.to contain_keystone_config('healthcheck/allowed_source_ranges').with_value(

'10.0.0.0/24,10.0.1.0/24'

)

is_expected.to contain_keystone_config('healthcheck/ignore_proxied_requests').with_value('false')

is_expected.to contain_keystone_config('healthcheck/disable_by_file_path').with_value(

'/etc/keystone/healthcheck/disabled'

)

healthcheck: Add support for ignore_proxied_requests

13 spec/defines/oslo_healthcheck_spec.rb Unescape Escape View File

13
spec/defines/oslo_healthcheck_spec.rb

View File