openstack/puppet-openstack-integration - puppet-openstack-integration - OpenDev: Free Software Needs Free Tools

Fix new lint errors detected when full of the voxpupili lint plugins
are enabled.
Depends-on: https://review.opendev.org/958040
Change-Id: I17970da9dd2878eafe268be10cf7e913b35cbdb1
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

This fixes a few lint warnings/errors detected by the following plugins
we aim to enable soon.
 - puppet-lint-file_ensure-check
 - puppet-lint-trailing_comma-check
 - puppet-lint-topscope-variable-check
Change-Id: I7f19f9ce7ceca9e9f237defd4e60f696303f090e
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

... to make the manifest more robust with the changes in underlying
modules.
Change-Id: Icf3bf402e694db0f2dcabffbfdfd2f639585e9de

httpd + mod_wsgi is now widely used to deploy api services.
This updates the deployment pattern of Magnum api service to follow
that standard.
Change-Id: Id6cf3384fc3f667142be61b2ba9ec0a27c1a218d

This adds a few more parameters so that we spawn less processes from
each service, to reduce resource footprint in our CI.
Change-Id: I30f32b6414960c341d64282d91b8f958c8996772

This enables usage of service user token for interaction with nova and
barbican to avoid failure caused by token expiration during operations.
This also enables service_token_roles_required option in authtoken
middleware to allow only users with the service role to use this
feature.
Change-Id: Id6b0aad7aa24af2b6d03d484ada23357828c4325

Change-Id: Ia4276ef65947c36c5d3712859381bd7536018b0c

... because the latest lint no longer allows usage of legacy facts and
top scope fact.
Change-Id: I25d27829f66c4ee56e2755579dad21530ef09c3a

Currently we always use IPv4 for MySQL even in the test cases which are
supposed to use IPv6. This fixes that and ensures the expected ip
version is used.
Change-Id: I483f04376f29b75dcca20061ae381c7e71f26caf

Currently idempotency in Ubuntu is broken because of the below change
detected in collate in MySQL.
```
/Stage[main]/Keystone::Db::Mysql/Openstacklib::Db::Mysql[keystone]/
Mysql_database[keystone]/collate: collate changed 'utf8mb3_general_ci'
to 'utf8_general_ci'
```
Similarly to what we observed in the past about charset[1], it seems
MySQL in Ubuntu is automatically converting the collate value and that
is causing the "unexpected" change detected in the 2nd puppet run.
This fixes the idempotency by using utf8mb3_general_ci in Ubuntu to
avoid the mismatch caused by internal translation.
[1] 085d356902
Change-Id: I56f31397669d3d7b08aa2e9808947141e003ab0b

Change-Id: Ibbffc177c7ea74f9182c08fcfa56f8d27ea23fc6

Change-Id: Id4945d93c03c2a397a5759ea77fe1e42bb4f40f2

We are observing the failure in Ubuntu integration job caused by
broken idempotency. It seems current mysql/mariadb in Ubuntu replaces
utf8 with uft8mb3 automatically and this behavior results in unexpected
change in second run.
This change ensures that we use utf8mb3 in Ubuntu to avoid such
mismatch caused by internal translation. Note this change is intended
to be a quick gate fix and the charset would be updated to utf8mb4
later.
Closes-Bug: #1929073
Change-Id: I7742120758057b5a00f1d093f355fda3791f4e02

Change-Id: Idcf2a889baede92d4522537a192295bae6cde950