openstack/nova - nova - OpenDev: Free Software Needs Free Tools

Fix bug 817872.
This patch modifies the behavior of removing security groups via the EC2
API to better match the EC2 API spec. The EC2 documentation says that a
group that is still in use can not be removed.
A new function has been added to the db API to find out whether a
particular security group is still in use. "In use" is defined as
applied to an active instance, or applied to another group that has not
been deleted.
Unit tests have been updated to ensure that an error is raised when
these conditions are hit.
Change-Id: I5b3fdf1da213b04084fe266c1a6ed92e01cf1e19

Fixes bug #912650.
Fixes the following test cases in
smoketests/test_netadmin.py:SecurityGroupTests:
 'test_004_can_access_metadata_over_public_ip'
 'test_005_validate_metadata'
 'test_999_tearDown'
Change-Id: Iefa8034a364e13243d06200e8af1840df896baf3

Change-Id: I96344eaccd2f42b70223b3c155a4793ab00d09d5

for instance-type metadata.

of test_netadmin to return an error code which we can then check for
and handle properly. This should allow calling functions to properly
retry and timout if an actual test failure happens.

smoke test function. This should help troubleshoot an intermittent failure.