openstack/nova - nova - OpenDev: Free Software Needs Free Tools

When using a test runner that runs tests in a different order than
nosetests it is possible that IPv6AccountIdentiferTestCase tests run
before CommonNetworkTestCase. If this happens
IPv6AccountIdentiferTestCase sets the ipv6_backend to account_identifier
which causes the regexes in
CommonNetworkTestCase.test_get_instance_uuids_by_ipv6_regex to not
match.
Explicitly set the ipv6_backend to rfc2462 in CommonNetworkTestCase's
setUp() to ensure the regex's match the addresses in the fake network
DB.
Part of blueprint grizzly-testtools
Change-Id: I0fdb5c3d4130c6cf23b22bca6645581f603a79c5

Defensive logic to stop creation of extraneous resource trackers.
Change-Id: I8d190990c4020eff85584cdb39d4b91104b7450e

If a network gateway of multi hosted network is unsed by any VM on the
host, we tear down it.
It is implemented only with the VLAN manager.
Fixes LP bug #1084651
Change-Id: Ia7e399de5b8ddf6ec252d38dfbb8762c4f14e3a5

This patch removes direct database accesses for looking up
migrations by id, and instead queries conductor.
Related to blueprint no-db-compute
Change-Id: Ia7df121971b14b1eb4ce65063246968b3603309d

bug 1087760
Change-Id: I8c50543de1efc48b9dde0dc045fcd52bc89b727b

Resolves bug 1087028.
Change-Id: Ife7ec43cf76cf04a98f1db2135f9149a2eefb55d

It is possible that instance faults have the same created_at values so
ordering on that field alone is not deterministic. Add an additional
order by clause to order descending on id as well.
I am not sure if the order by exists to make tests pass; however,
without the additional "id" the tests do occasionally fail. See
http://logs.openstack.org/15078/18/check/gate-nova-python26/10709/console.html
for an example failure. If order does not actually matter we may want to
make the test smarter instead.
Part of blueprint grizzly-testtools
Change-Id: I1c7a07669846c832270631c1734dae509dba7586

These are the RPC common changes for squelching exception
logging, oslo change I4e7b19dc730342091fd70a717065741d56da4555
Change-Id: I8b5040d0ec2e70b8cc1e784151df60ac2bf3f457

This fixes two related issues in nova/tests/test_migrations.py.
First, the snake_walk flag was only set to True for the first test run
out of TestMigrations. setUp() always set snake_walk to False initially
then would only update the value if TEST_DATABASES was empty.
TEST_DATABASES was only empty during the setUp() of the first test.
Fix this by resetting test_databases before each test.
Second, because snake_walk was always False when test_walk_versions
performing the snake walk version of the database migrations was never
tested and broken. When downgrading from version X to version X -1 of a
database version X must be passed to the migration tool as version X
contains the downgrade path for that particular version. Set the correct
versions when snake walking the DB migrations.
Part of blueprint grizzly-testtools
Change-Id: I8d4d9ee8efe46b4690dd6cbe95879e88aaeb0b5a

Change-Id: I9c7dfa7664badcafb800c02ee608699e56b344ab
Fixes: bug #1084261 

Prevent nova-manage from stack tracing when the wrong number of
arguments are passed in.
Fixes bug 1083315
Change-Id: I7b9a237a82b4255d88c01c6a56ad0ccd4a6ee984

Change-Id: I03d93c5024965d4252a18d8cb564a7512b728994

Change-Id: Ib141553017aa88d6edb65b5d51c06740699a2480

* With pep8 1.3.3 the exclude logic monkey patch broke causing
 tools/hacking to run on openstack/common code
* Also add .git to exclude list
Fix bug 1086410
Change-Id: Ifc50ac1963c50c338432bbb4b1e15cdf58ed2128

Occasionally when nova uses libvirt lib to query hypervisor
xen the instance state of vm_power_state may end up
with a NOSTATE value. Existing code shuts down the instance
when we hit this state. Remove the check for NOSTATE
to avoid shutting down the instance.
Fixes LP #1085771.
Change-Id: I0025f6800b6ca9cd3d7c7e6119b9a819571bd13c

Fixes bug #1060884
Host actions like enable/disable, maintenance mode and power management
are not implemented in most virt drivers.
In the case of set_host_enabled() in the libvirt driver, we have a no-op
implementation. In other cases we have an implementation which raises
NotImplementedError. Since the default implementation is to do this, we
should just remove the redundant methods from the drivers which don't
actually implement these actions. This ensures NotImplementedError is
consistently raised.
On the API side, rather than looking at the return value of these
methods to determine whether they're implemented, we should just catch
NotImplementedError and return a sensible error message.
In order to do this, we need to ensure the NotImplementedError is
properly deserialized from the RemoteError which will encapsualte
it. The fix for bug #1086798 ensures this happens.
Finally, add some tests to make sure we properly respond with 501
when the virt driver doesn't implement these actions.
Change-Id: I2d4fc51a4b16d5230e61bde75915142ea450557d

The update() method in the hosts extension is decorated with @check_host
but the function returned by decorator takes a kwarg which shadows the
'body' positional arg of the update() method.
i.e. if you call:
 controller.update(req, id, body)
then the body arg gets passed to the wrapper as its service kwarg and
never passed through to update(). We can see how the tests are all
passing body as a kwarg to avoid this.
Remove the service arg from check_host() but also from _list_hosts()
since the only place it is used is in the tests.
Change-Id: I12aab582c15c25fd35ecda005341291450c7efdc

Fix commonly used methods like parse_line and qualify to return
lower case strings. Review incoming method arguments to make sure
we are using comparisons where both strings are in lower case.
Fix a few spots where the input parameters were not in lower case
Added a test case for a specific problem that showed up in
the devstack gate job.
Change-Id: Ia204bde26cee5a1b22e8240a5310c5d45ffafb32

This change refactors two methods of blockdev.py in the
interest of better naming. run_command() and run_command_as_root()
have been refactored as run_vios_command() and
run_vios_command_as_root() respectively to better indicate that these
run commands on a remote system, the VIOS.
bp powervm-compute-enhancements
Change-Id: If65b4ff08e058443c7d10fcdf98e13c7aa207c56

Changes since last sync:
 202f568 Use json instead of jsonutils in rpc.impl_fake.
 6d102bc Provide i18n to those messages without _()
 8695285 Qpid H/A cluster support
 faeafe1 Fixes import order
 cf705c5 Make project pyflakes clean.
 05f8ec7 Fix common rpc to use common logging instead of python logging
 b6d24bb updating sphinx documentation
 33fbd87 Added initialize_service_hook for rpc.Service.
 cf849e0 Clean up dictionary use in RPC drivers
Change-Id: I4fbade51390e159bd9cccd2afc918a4f07740993

This should fix the unit test failures observed in:
 https://review.openstack.org/#/c/17539/
Change-Id: I75463a9ea9557f669b701c778bf24eb00502f47a

get_backdoor_port() in the network api doesn't have
a host parameter. However, if there are more than one
network service running on multiple hosts then you will
only be able to get the backdoor port for one of those
services. So the host field is needed to target the rpc
call.
Also, the RPC_API_VERSION number was incremented because this was
overlooked in change id: I95fdb5ca9bce9f3128300e3b5601fb2b2fc5e82f
Change-Id: I90357548c0483559982469b7c26d40511755924e

This adds an extension that provides REST API for list/create/delete/
modify agent build. The interface is accessed via
GET /v2/{tenant_id}/os-agents
PUT /v2/{tenant_id}/os-agents/id
POST /v2/{tenant_id}/os-agents
DELETE /v2/{tenant_id}/os-agents
And this patch also create tests to get agent build API Samples.
DocImpact
Implements one workitem of blueprint apis-for-nova-manage
The agent is talking about guest agent.The host can use this for
things like accessing files on the disk, configuring networking,
or running other applications/scripts in the guest while it is
running. Typically this uses some hypervisor-specific transport
to avoid being dependent on a working network configuration.
Xen, VMware, and VirtualBox have guest agents,although the Xen
driver is the only one with an implementation for managing them
in openstack. KVM doesn't really have a concept of a guest agent
(although one could be written).
You can find the design of agent update in this link:
http://wiki.openstack.org/AgentUpdate
and find the code in nova.virt.xenapi.vmops.VMOps._boot_new_instance.
In this design We need update agent in guest from host, so we need
some interfaces to update the agent info in host.
You can find more information about the design of the GuestAgent in
the following link:
http://wiki.openstack.org/GuestAgent
http://wiki.openstack.org/GuestAgentXenStoreCommunication
DocImpact
Change-Id: I5830388a894efce5b13680fc6916e0cd81a16624

Partially implements blueprint nova-api-samples
Fixes bug 1070160
Change-Id: Ide7119a308a03ded101ae76faf8204352ffc8566

Change-Id: I41b8274775241f6005b279199d1841e0b1025748