Merge "Add autopep8 to tox and pre-commit"

openstack/nova

Code Issues Proposed changes

This commit is contained in:

Zuul

2021年11月08日 23:54:03 +00:00

committed by Gerrit Code Review

parent c62616963a f3d48000b1

commit 0e0196d979

83 changed files with 154 additions and 3 deletions

@@ -47,14 +47,29 @@ commands =

description =

Run style checks.

envdir = {toxworkdir}/shared

deps =

{[testenv]deps}

autopep8

commands =

{[testenv:mypy]commands}

# check if autopep8 would alter the formatting but don't actually change it

# so we can gate on this in the ci

autopep8 --exit-code --max-line-length=79 --diff -r nova doc setup.py

# since autopep8 only tries to make minimal changes to conform to pep8 we still need to run

# our hacking and flake8 check to keep our existing code style consistent.

# The full list of issues addressable by autopep8 can be found here

# https://pypi.org/project/autopep8/#features

bash tools/flake8wrap.sh {posargs}

# Check that all JSON files don't have \r\n in line.

bash -c "! find doc/ -type f -name *.json | xargs grep -U -n $'\r'"

# Check that all included JSON files are valid JSON

bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'

[testenv:autopep8]

deps = autopep8

commands =

autopep8 --exit-code --max-line-length=79 --in-place -r nova doc setup.py

[testenv:fast8]

description =

Run style checks on the changes made since HEAD~. For a full run including docs, use 'pep8'