openstack/nova - nova - OpenDev: Free Software Needs Free Tools

This website requires JavaScript.

openstack/nova

Code Issues Proposed changes

Files

c4b28a5496e9e679c72cd6fa403fd6b82b0eceb1

nova /mypy-files.txt

11 lines

237 B

Plaintext

Raw Normal View History

Add type hints to 'nova.compute.manager' As with previous changes, we're going to be doing some surgery to this file shortly so enable type hints now. These are *super* incomplete but at least we have a starting point. Part of blueprint add-emulated-virtual-tpm Change-Id: Iee44ea525deb0b43ae43df3ba08c95ea8a4e317c Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年07月24日 12:04:15 +01:00

nova/compute/manager.py

crypto: Add type hints Nothing to complicated here, other than working around mypy's dislike of changing variable types and inability to process 'if six.PY3' conditional blocks because it doesn't run the code. Part of blueprint add-emulated-virtual-tpm Change-Id: I805eaa8b6fb55ce9cbc8f6b8b777af48302ba2ba Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年07月02日 14:12:47 +01:00

nova/crypto.py

privsep: Add support for recursive chown, move_tree operations We'll need these shortly to handle shuffling of vTPM files during cold migrations and resizes. Part of blueprint add-emulated-virtual-tpm Change-Id: I7c8dedc9e74117838db5d418dda1dcbe7143ad08 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年07月24日 12:08:29 +01:00

nova/privsep/path.py

Enable mypy on scheduler/utils.py A couple of extra hints was needed. A later patch will add type hints for some functions that is being refactored Change-Id: I9886270dea092e28a8123245a2c70c8d8c7127f3 Blueprint: support-interface-attach-with-qos-ports

2021年01月08日 14:13:49 +01:00

nova/scheduler/utils.py

virt: Add 'context', drop 'network_info' parameters for 'unrescue' In a future change, we'll want access to this so that it's possible to retrieve vTPM data during the unrescue operation. While we're here, it seems nothing is using the 'network_info' argument anymore, presumably since the demise of nova-network, and this can and should be dropped. Resolve both issues in one go, adding the 'context' parameter, dropping the 'network_info' one, and updating the various callers and tests for same. Maintainers of out-of-tree drivers have been notified of these changes [1]. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015824.html Part of blueprint add-emulated-virtual-tpm Change-Id: Id5e4b0f26d5a2a93db6a7d96555a2cff29d9a2cf Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年05月18日 13:45:41 +01:00

nova/virt/driver.py

hardware: Update and correct typing information This is going to be used extensively in forthcoming patches. Lay the groundwork now. This requires some minor tweaks of code that mypy found confusing along with unit tests for coverage gaps it exposed. Part of blueprint use-pcpu-and-vcpu-in-one-instance Change-Id: Ied35762c353a084398ab8032a8efe6eada69dd9b Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年04月06日 17:27:51 +01:00

nova/virt/hardware.py

tox: Integrate mypy mypy is an experimental optional static type checker for Python that aims to combine the benefits of dynamic (or "duck") typing and static typing. While still in development, most features are supported and it's already being used by real world projects like Sphinx. Let's start small by integrating it into some of the interfaces that nova exposes. We can further build upon this if it works out. This change sets up the boilerplate necessary to use mypy in nova. Type annotations are not included for any module - these will be added separately. We're calling mypy by way of a script, as this allows us to store a list of files that we have converted while we're in the process of adding type annotations where necessary. Change-Id: I75ab46a6768c4ca2050fdde2b7f8eeb90724c8c6 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

2017年06月02日 16:45:41 +01:00

nova/virt/libvirt/__init__.py

libvirt: Add typing information As with the 'nova.virt.hardware' module, add typing information here now so that we can use it during development of later features. This requires some minor tweaks of code that mypy found confusing. Part of blueprint use-pcpu-and-vcpu-in-one-instance Change-Id: Icc7b3d250bb9dd3d162731959185d9e962727247 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年03月16日 13:00:15 +00:00

nova/virt/libvirt/driver.py

Lookup nic feature by PCI address In some environments the libvirt nodedev list can become out of sync with the current MAC address assigned to a netdev, As a result the nodedev lookup can fail. This results in an uncaught libvirt exception which breaks the update_available_resource function resultingin an incorrect resource view in the database. e.g. libvirt.libvirtError: Node device not found: no node device with matching name 'net_enp7s0f3v1_ea_60_77_1f_21_50' This change removes the dependency on the nodedev name when looking up nic feature flags. Change-Id: Ibf8dca4bd57b3bddb39955b53cc03564506f5754 Closes-Bug: #1883671

2020年07月03日 15:58:02 +00:00

nova/virt/libvirt/host.py

Add type hints to 'nova.virt.libvirt.utils' The ROI for these util modules is pretty high, given how they are used. Part of blueprint add-emulated-virtual-tpm Change-Id: I46846627311beb21946fd4d24048e0e3ea7ac942 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

2020年07月24日 12:45:43 +01:00

nova/virt/libvirt/utils.py

Copy Permalink