openstack/nova - nova - OpenDev: Free Software Needs Free Tools

 constraints: pip install -U --force-reinstall -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}

pip install -U --force-reinstall {opts} {packages}

Add missing directive to tox.ini. Change-Id: Ib6d178af62f631de76e66c2bb6c07fd6b277fa97

2012年02月25日 12:25:56 -08:00

setenv = VIRTUAL_ENV={envdir}

move all tests to nova/tests/unit As part of the split of functional and unit tests we need to isolate the unit tests into a separate directory for having multiple test targets in a sane way. Part of bp:functional-tests-for-nova Change-Id: Id42ba373c1bda6a312b673ab2b489ca56da8c628

2014年11月07日 14:27:03 +01:00

OS_TEST_PATH=./nova/tests/unit

Force LANGUAGE=en_US in test runs If your native locale is not en_US and you run tests, some will fail due to the message translation that happens since the assertion messages are in en_US (not translated, just hard-coded in the tests). I recreated the bug by setting LANGUAGE=en_GB in my tox.ini and tested against nova.tests.unit.api.openstack.test_wsgi. Note that setting LANG=en_US had no effect. Closes-Bug: #1427745 Change-Id: Ib1c71d0d4170ba1a7ed2fe3eaf0e2d8071ec01d6

2015年03月03日 08:58:42 -08:00

LANGUAGE=en_US

Force the value of LC_ALL to be en_US.UTF-8 On Python 3, if LC_ALL is not passed then the interpreter will assume it is C (which causes the interpreter to use ASCII). This, in turn, causes the unicode in the README.rst for rfc3986 to trigger a UnicodeDecodeError exception. jlvillal (John Villalovos) pointed out I340c88ea7d098ca5943d60adc73f63a0af79a405 in IRC as the fix to this bug. Closes-bug: 1460206 Change-Id: If05e3fe76450c06431413f63e46e154cf44fc1cf

2015年05月29日 16:41:44 -05:00

LC_ALL=en_US.utf-8

Have tox install via setup.py develop tox 1.6 was released, which means that we can now take advantage of the feature we added to it - which is using setup.py develop to install the code into the virtualenv. The logic was taken from run_tests.sh - so the performance issues around using tox vs. using install_venv should now be gone. run_tests.sh is still needed to handle the ui switching between parallel, single and debug modes to testr. Change-Id: Ida5e440d1bdb9f8e9031277ea53a02d2ef171438

2013年08月15日 14:36:40 -03:00

deps = -r{toxinidir}/requirements.txt

Rename requires files to standard names. Rename tools/pip-requires to requirements.txt and tools/test-requires to test-requirements.txt. These are standard files, and tools in the general world are growing intelligence about them. Change-Id: I68ece8406fb1d4e082a42db8e76e17b1aaa7e775 Fixes: bug #1179008

2013年05月22日 20:12:08 +00:00

-r{toxinidir}/test-requirements.txt

Update tox.ini to support RHEL 6.x. In order to support running unit tests on RHEL 6.x we need to patch eventlet with contrib/redhat-eventlet.patch. We already have support for this in the tools/install_venv_common.py but we need to make a couple changes to allow tox to consume this: 1) Sync in the latest intall_venv_common.py from oslo. This changes patch to use the -N option (ignore already applied patches) and makes it safe to call the patching function more than once. 2) Add a new patch_tox_venv.py script in tools. 3) Update tox.ini to call patch_tox_venv.py before it runs tests and coverage. Change-Id: I3e2b07c3f718e4aede5c5f231ff0cdb7721ec885

2013年03月06日 16:00:37 -05:00

commands =

delete python bytecode before every test run Bring over the cleaning line from run_tests.sh for the pyc files to all the tox runs. This should eliminate the need to clean -x -i to kill pyc files in your local directory to get tests to pass. Closes-Bug: #1368661 Change-Id: Idf3a46d8c95806f2d2ce28ce84ced12b625e53df

2014年09月12日 05:47:03 -04:00

find . -type f -name "*.pyc" -delete

bring over pretty_tox.sh from tempest Tempest developed a set of wrappers around testr to print out tests as they are running through using the subunit stream. This also displays which workers the various tests are running on. Adapted for nova's need for loading the locking. I expect that the needs of nova will diverge this over time, especially what's displayed during tracing, as such I think it's fine to just do a transplant and not try to turn this into some external repo. Change-Id: Ied1708515fc49f4e18cd8dbb7b2cd821f85e1966

2014年09月16日 11:49:11 -04:00

bash tools/pretty_tox.sh '{posargs}'

pass environment variables of proxy to tox When a development environment is under a proxy, tox is failed even if environment variables of the proxy are set. This patch fix this problem. Change-Id: If0bc42891a0714cc9b37b9c211388db20555ea7e

2015年06月09日 15:30:59 +09:00

passenv = http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY

support TRACE_FAILONLY env variable In order to get similar behavior to the way testr out of the box works, only displaying failing results, all the user to define TRACE_FAILONLY environment variable (any value will do). After this point only failures, and things leaking out of stderr will end up on the screen. We also need to remove the suppression of the inline fail dumps for this to have the impact that you'd expect. Change-Id: I72911adc8a03450522429c52db661ec0a1bc4678

2014年09月24日 13:56:49 -04:00

# there is also secret magic in pretty_tox.sh which lets you run in a fail only

# mode. To do this define the TRACE_FAILONLY environmental variable.

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

Allow sitepackages on jenkins. Since our overall environment on the jenkins slaves is controlled, it's safe to allow site-packages. BUT - more importantly, it's the only way to get python-libvirt to be accessed. Change-Id: I1181127a134afdfc1de58d0ab819395bb8995647

2012年05月05日 13:51:32 -07:00

[tox:jenkins]

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

downloadcache = ~/cache/pip

[testenv:pep8]

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

commands =

tox: make it possible to run pep8 on current patch only The 'tox -epep8' command takes a long time as it checks every single file in the Nova git repository (~1,400 at time of writing). This makes tox use a simple wrapper around flake8 which can be told to restrict the check to only files changed in the current command. This can be invoked in a simple manner with 'tox -epep8 -- -HEAD'. Since most commits only touch a handful of files, this will usually be far faster than checking all 1,400 source files. To check an entire branch for bisectability it can be automated via git rebase -i master -x 'tox -epep8 -- -HEAD' Change-Id: I157d1ccb883ca02402eee51fd7d6a50f86079389

2015年07月24日 16:05:49 +01:00

bash tools/flake8wrap.sh {posargs}

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

Run tests with PyMySQL on Python 3 Add test-requirements-py3.txt to use PyMySQL, instead of MySQL-python, on Python 3. Add a py34 test environment to tox.ini which uses test-requirements-py3.txt and sets OS_TEST_DBAPI_ADMIN_CONNECTION to use the PyMySQL connector instead of the MySQL-python connector. This change is based on Ironic tox.ini, so I added Victor Sergeyev as the coauthor of the patch. Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com> Blueprint nova-python3 Change-Id: I5a27c7d627105b614da3cab3a87296a8e186b555

2015年05月22日 10:17:27 -07:00

[testenv:py34]

Remove unneeded OS_TEST_DBAPI_ADMIN_CONNECTION The desired OS_TEST_DBAPI_ADMIN_CONNECTION string is now reflected in the oslo.db 1.12.0 release's default behavior, and so does not need to be set any longer to achieve the same opportunistic backend discovery for tests. Change-Id: I1af372f6f18038e8fc63076b4e399d0ae86f5a23

2015年07月03日 23:06:13 +00:00

setenv = {[testenv]setenv}

Run tests with PyMySQL on Python 3 Add test-requirements-py3.txt to use PyMySQL, instead of MySQL-python, on Python 3. Add a py34 test environment to tox.ini which uses test-requirements-py3.txt and sets OS_TEST_DBAPI_ADMIN_CONNECTION to use the PyMySQL connector instead of the MySQL-python connector. This change is based on Ironic tox.ini, so I added Victor Sergeyev as the coauthor of the patch. Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com> Blueprint nova-python3 Change-Id: I5a27c7d627105b614da3cab3a87296a8e186b555

2015年05月22日 10:17:27 -07:00

deps = -r{toxinidir}/requirements.txt

Remove python3 specific test-requirements file. With environment markers this is not needed, and it should fix requirement syncing. Change-Id: I9e32764417852ea65b28efe3c05d39865ebc5744

2015年06月30日 15:18:18 +12:00

-r{toxinidir}/test-requirements.txt

Fix version unit test on Python 3 With this change, "tox -e py34" now pass. Changes: * Replace unichr() with six.unichr() * Replace StringIO.StringIO() with six.Bytes() in nova.crypto.generate_key_pair() * On Python 3, replace UserDict.IterableUserDict with collections.UserDict * Replace __builtin__.open with six.moves.builtins.open * Replace ConfigParser import with six.moves.configparser * On Python 3, get the original "queue" module instead of the "Queue" module in nova/virt/libvirt/host.py * Replace urllib2 with six.moves.urllib * tox.ini: "tox -e py34" now only runs nova.tests.unit.test_versions Blueprint nova-python3 Change-Id: I056769c7c5b32276894f7aade8c0a27af81c42ae

2015年05月25日 13:22:29 +02:00

commands =

find . -type f -name "*.pyc" -delete

Get py34 subunit.run test discovery to work Currently the tox py34 target uses testtools.run to run a subset of our test harness. We need to be able to use pretty_tox.sh just like py27 as we make progress with py34 support. The first step is to make sure we can discover all the tests using: python -m subunit.run discover -t . ./nova/tests/ --list So, we need to fix a bunch of things for the discovery to work including updating to a new version of websockify. In the xen code, we should keep the original import and add except for py34 as xen uses an older python that does not work with six.moves. Depends-On: Ib4ef2e79b28b7180e564b3d6dc2188456c66c08a Change-Id: I88b6746da6136a7386a173f6cacd42f0b470deee

2015年07月22日 13:38:28 -05:00

python -m subunit.run discover -t . ./nova/tests/ --list

Fix Python 3 issues in nova.db.sqlalchemy * Replace dict(obj.iteritems()) with dict(obj) where obj is a dictionary or an oslo.db object * Replace obj.iteritems() with obj.items() where obj is a dictionary: obj.items() works on Python 2 and Python 3. * Replace filter() and map() with list-comprehension using if when a list is expected. On Python 3, filter() and map() return an iterator. * Replace obj.keys() with list(obj.keys()) when a list is expected. Replace obj.keys()[0] with list(obj.keys())[0]. On Python 3, dict.keys() now returns an iterator. * Replace (int, long) with six.integer_types * Get the name of a function using the __name__ attribute, instead of the func_name attribute. The func_name attribute was removed in Python 3. * InstanceTypeTestCase: use dict.update() to combine dictionaries instead of using dict.items()+reduce()+dict() * matchers.py: replace StringIO.StringIO with six.StringIO. * tox.ini: add nova.tests.unit.db.test_db_api to Python 3.4 Blueprint nova-python3 Change-Id: Iae4f6d971818d5b38e838a83753a0707e954bb04

2015年06月24日 15:42:51 +02:00

python -m testtools.run \

Re-write way of compare APIVersionRequest's `cmp` method was removed in Python 3, so it would be nice to use __lt__, __le__, __eq__, __ne__, __gt__ and __ge__ instead, which are Py2 and Py3 compatible. Change-Id: I1c89da0831b77b73f55d8681fd7d946535cc89b5

2015年08月14日 17:40:30 +03:00

nova.tests.unit.api.openstack.test_api_version_request \

Port crypto to Python 3 Fix bytes vs Unicode issues: * ssh_encrypt_text() now encodes text to UTF-8 if text type is Unicode. * Encode Unicode to ASCII before encoding it to base64 * On Python 3, decode binascii.hexlify() and base64.encodestring() output from ASCII to get Unicode (str type in Python 3) is required. * convert_from_sshrsa_to_pkcs8(): reuse binascii.hexlify() instead of a loop using struck.unpack() and "%02X" format. * Replace str.encode('hex') with binascii.hexlify(str) * Replace string.strip(text) with text.strip() * Replace StringIO.StringIO with six.StringIO * Add test on the output type of ssh_encrypt_text() and decrypt_text() * Call utils.execute() with binary=True to not decode stdout/stderr (to get them as raw bytes). * Replace reduce() with six.moves.reduce() * convert_version_to_str(): replace a/b with a//b to get integer division * tox.ini: add the following tests to Python 3.4 - nova.tests.unit.compute.test_keypairs - nova.tests.unit.test_crypto Blueprint nova-python3 Change-Id: I83d927166c0864020b205ac7495473795da7830d

2015年07月01日 17:48:54 +02:00

nova.tests.unit.compute.test_keypairs \

Fix Python 3 issues in nova.db.sqlalchemy * Replace dict(obj.iteritems()) with dict(obj) where obj is a dictionary or an oslo.db object * Replace obj.iteritems() with obj.items() where obj is a dictionary: obj.items() works on Python 2 and Python 3. * Replace filter() and map() with list-comprehension using if when a list is expected. On Python 3, filter() and map() return an iterator. * Replace obj.keys() with list(obj.keys()) when a list is expected. Replace obj.keys()[0] with list(obj.keys())[0]. On Python 3, dict.keys() now returns an iterator. * Replace (int, long) with six.integer_types * Get the name of a function using the __name__ attribute, instead of the func_name attribute. The func_name attribute was removed in Python 3. * InstanceTypeTestCase: use dict.update() to combine dictionaries instead of using dict.items()+reduce()+dict() * matchers.py: replace StringIO.StringIO with six.StringIO. * tox.ini: add nova.tests.unit.db.test_db_api to Python 3.4 Blueprint nova-python3 Change-Id: Iae4f6d971818d5b38e838a83753a0707e954bb04

2015年06月24日 15:42:51 +02:00

nova.tests.unit.db.test_db_api \

Enable python34 tests for nova/tests/unit/scheduler/test*.py nova/pci/stats.py: need to specify a key parameter which is a function that returns a sorting key. since the original intention with pool_cmp was to sort by number of items in each pool, we just use key parameter with a lambda nova/scheduler/filters/trusted_filter.py nova/scheduler/host_manager.py needed list() so we could delete stuff inside the loop in py3 nova/tests/unit/scheduler/test_filter_scheduler.py needed the import of test as some tests were failing in py3, added noqa as test is not explicitly referenced within the module nova/tests/unit/scheduler/test_scheduler_options.py need BytesIO for py3, StringIO will fail in many tests nova/tests/unit/scheduler/test_scheduler_utils.py message is not available in py3, so we need to adjust use test.nested already added in a previous commit nova/test.py if we have a key which is a list, treat it just like a set nova/utils.py use reduce from six and explicitly typcast version_int as an integer Change-Id: Ic862873f38767f12b990a030b5812ae50a44c4d0

2015年06月03日 07:55:04 -04:00

nova.tests.unit.scheduler.filters.test_affinity_filters \

nova.tests.unit.scheduler.filters.test_aggregate_image_properties_isolation_filters \

nova.tests.unit.scheduler.filters.test_aggregate_instance_extra_specs_filters \

nova.tests.unit.scheduler.filters.test_aggregate_multitenancy_isolation_filters \

nova.tests.unit.scheduler.filters.test_availability_zone_filters \

nova.tests.unit.scheduler.filters.test_compute_capabilities_filters \

nova.tests.unit.scheduler.filters.test_compute_filters \

nova.tests.unit.scheduler.filters.test_core_filters \

nova.tests.unit.scheduler.filters.test_disk_filters \

nova.tests.unit.scheduler.filters.test_exact_core_filter \

nova.tests.unit.scheduler.filters.test_exact_disk_filter \

nova.tests.unit.scheduler.filters.test_exact_ram_filter \

nova.tests.unit.scheduler.filters.test_extra_specs_ops \

nova.tests.unit.scheduler.filters.test_image_props_filters \

nova.tests.unit.scheduler.filters.test_io_ops_filters \

nova.tests.unit.scheduler.filters.test_isolated_hosts_filter \

nova.tests.unit.scheduler.filters.test_json_filters \

nova.tests.unit.scheduler.filters.test_metrics_filters \

nova.tests.unit.scheduler.filters.test_num_instances_filters \

nova.tests.unit.scheduler.filters.test_numa_topology_filters \

nova.tests.unit.scheduler.filters.test_pci_passthrough_filters \

nova.tests.unit.scheduler.filters.test_ram_filters \

nova.tests.unit.scheduler.filters.test_retry_filters \

nova.tests.unit.scheduler.filters.test_trusted_filters \

nova.tests.unit.scheduler.filters.test_type_filters \

nova.tests.unit.scheduler.filters.test_utils \

nova.tests.unit.scheduler.test_caching_scheduler \

nova.tests.unit.scheduler.test_chance_scheduler \

nova.tests.unit.scheduler.test_client \

nova.tests.unit.scheduler.test_filter_scheduler \

nova.tests.unit.scheduler.test_filters \

nova.tests.unit.scheduler.test_host_filters \

nova.tests.unit.scheduler.test_host_manager \

nova.tests.unit.scheduler.test_ironic_host_manager \

nova.tests.unit.scheduler.test_rpcapi \

nova.tests.unit.scheduler.test_scheduler \

nova.tests.unit.scheduler.test_scheduler_options \

nova.tests.unit.scheduler.test_scheduler_utils \

nova.tests.unit.scheduler.weights.test_weights_hosts \

nova.tests.unit.scheduler.weights.test_weights_ioopsweight \

nova.tests.unit.scheduler.weights.test_weights_metrics \

nova.tests.unit.scheduler.weights.test_weights_ram \

Enable python34 tests for nova/tests/unit/objects/test*.py All tests in nova/tests/unit/objects/test*.py now run with python3.4 tox target. * Fix imports in limits.py and urlmap.py * Add a list() as keys()/values() return iterator in availability_zones.py, flavors.py and instance_numa_topology.py * contextlib.nested is not present in python3, so whip up an alternative using ExitStack(). Directly using ExitStack() wont work for us. * Add a few assertJsonEqual in the test cases * Ensure fingerprinting generates the same exact value in both python27 and python34 Blueprint nova-python3 Change-Id: I848c48475189c4b4ad8151e14509020ae7d110a4

2015年06月02日 17:53:35 -04:00

nova.tests.unit.objects.test_agent \

nova.tests.unit.objects.test_aggregate \

nova.tests.unit.objects.test_bandwidth_usage \

nova.tests.unit.objects.test_block_device \

nova.tests.unit.objects.test_cell_mapping \

nova.tests.unit.objects.test_compute_node \

nova.tests.unit.objects.test_dns_domain \

nova.tests.unit.objects.test_ec2 \

nova.tests.unit.objects.test_external_event \

nova.tests.unit.objects.test_fields \

nova.tests.unit.objects.test_fixed_ip \

nova.tests.unit.objects.test_flavor \

nova.tests.unit.objects.test_floating_ip \

nova.tests.unit.objects.test_hv_spec \

nova.tests.unit.objects.test_instance \

nova.tests.unit.objects.test_instance_action \

nova.tests.unit.objects.test_instance_fault \

nova.tests.unit.objects.test_instance_group \

nova.tests.unit.objects.test_instance_info_cache \

nova.tests.unit.objects.test_instance_mapping \

nova.tests.unit.objects.test_instance_numa_topology \

nova.tests.unit.objects.test_instance_pci_requests \

nova.tests.unit.objects.test_keypair \

nova.tests.unit.objects.test_migration \

nova.tests.unit.objects.test_network \

nova.tests.unit.objects.test_network_request \

nova.tests.unit.objects.test_numa \

nova.tests.unit.objects.test_objects \

nova.tests.unit.objects.test_pci_device \

nova.tests.unit.objects.test_pci_device_pool \

nova.tests.unit.objects.test_quotas \

nova.tests.unit.objects.test_security_group \

nova.tests.unit.objects.test_security_group_rule \

nova.tests.unit.objects.test_service \

nova.tests.unit.objects.test_tag \

nova.tests.unit.objects.test_vcpu_model \

nova.tests.unit.objects.test_virt_cpu_topology \

Port crypto to Python 3 Fix bytes vs Unicode issues: * ssh_encrypt_text() now encodes text to UTF-8 if text type is Unicode. * Encode Unicode to ASCII before encoding it to base64 * On Python 3, decode binascii.hexlify() and base64.encodestring() output from ASCII to get Unicode (str type in Python 3) is required. * convert_from_sshrsa_to_pkcs8(): reuse binascii.hexlify() instead of a loop using struck.unpack() and "%02X" format. * Replace str.encode('hex') with binascii.hexlify(str) * Replace string.strip(text) with text.strip() * Replace StringIO.StringIO with six.StringIO * Add test on the output type of ssh_encrypt_text() and decrypt_text() * Call utils.execute() with binary=True to not decode stdout/stderr (to get them as raw bytes). * Replace reduce() with six.moves.reduce() * convert_version_to_str(): replace a/b with a//b to get integer division * tox.ini: add the following tests to Python 3.4 - nova.tests.unit.compute.test_keypairs - nova.tests.unit.test_crypto Blueprint nova-python3 Change-Id: I83d927166c0864020b205ac7495473795da7830d

2015年07月01日 17:48:54 +02:00

nova.tests.unit.objects.test_virtual_interface \

nova.tests.unit.test_crypto \

nova.tests.unit.test_exception \

Fix Python 3 issues in nova.utils and nova.tests * Fix sort(): dictionaries are no more comparable on Python 3, use a key function building a sorted list of the dictionary items * Replace __builtin__ with six.moves.builtins * get_hash_str() now accepts Unicode: Unicode is encoded to UTF-8 before hashing the string. Mention also the hash method (MD5) in the docstring. * LastBytesTestCase: use binary files instead of text files. Use also a context manager on the TemporaryFile to ensure that the temporary file is closed (even on error). * Functions: use the __code__ attribute instead of func_code, and __closure__ instead of func_closure. These attributes are also available on Python 2.6. * Replace unichr() with six.unichr() * SafeTruncateTestCase(): write directly the chinese Unicode character instead of using safe_decode() (which is not reliable, it depends on the locale encoding!) * sanitize_hostname(): On Python 3, decode the hostname from Latin1 to get back Unicode. Add also a comment explaining the purpose of the conversion to Latin1. * last_bytes(): replace the hardcoded constant 22 with errno.EINVAL and add a comment explaining how the function works. * tox.ini: add nova.tests.unit.test_utils to Python 3.4 Blueprint nova-python3 Change-Id: I96d9b0581ceaeccf9c35e0c9bada369e9d19fd15

2015年07月02日 15:05:12 +02:00

nova.tests.unit.test_utils \

Port crypto to Python 3 Fix bytes vs Unicode issues: * ssh_encrypt_text() now encodes text to UTF-8 if text type is Unicode. * Encode Unicode to ASCII before encoding it to base64 * On Python 3, decode binascii.hexlify() and base64.encodestring() output from ASCII to get Unicode (str type in Python 3) is required. * convert_from_sshrsa_to_pkcs8(): reuse binascii.hexlify() instead of a loop using struck.unpack() and "%02X" format. * Replace str.encode('hex') with binascii.hexlify(str) * Replace string.strip(text) with text.strip() * Replace StringIO.StringIO with six.StringIO * Add test on the output type of ssh_encrypt_text() and decrypt_text() * Call utils.execute() with binary=True to not decode stdout/stderr (to get them as raw bytes). * Replace reduce() with six.moves.reduce() * convert_version_to_str(): replace a/b with a//b to get integer division * tox.ini: add the following tests to Python 3.4 - nova.tests.unit.compute.test_keypairs - nova.tests.unit.test_crypto Blueprint nova-python3 Change-Id: I83d927166c0864020b205ac7495473795da7830d

2015年07月01日 17:48:54 +02:00

nova.tests.unit.test_versions

Run tests with PyMySQL on Python 3 Add test-requirements-py3.txt to use PyMySQL, instead of MySQL-python, on Python 3. Add a py34 test environment to tox.ini which uses test-requirements-py3.txt and sets OS_TEST_DBAPI_ADMIN_CONNECTION to use the PyMySQL connector instead of the MySQL-python connector. This change is based on Ironic tox.ini, so I added Victor Sergeyev as the coauthor of the patch. Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com> Blueprint nova-python3 Change-Id: I5a27c7d627105b614da3cab3a87296a8e186b555

2015年05月22日 10:17:27 -07:00

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

[testenv:functional]

usedevelop = True

install_command = pip install -U --force-reinstall {opts} {packages}

setenv = VIRTUAL_ENV={envdir}

OS_TEST_PATH=./nova/tests/functional

Force LANGUAGE=en_US in test runs If your native locale is not en_US and you run tests, some will fail due to the message translation that happens since the assertion messages are in en_US (not translated, just hard-coded in the tests). I recreated the bug by setting LANGUAGE=en_GB in my tox.ini and tested against nova.tests.unit.api.openstack.test_wsgi. Note that setting LANG=en_US had no effect. Closes-Bug: #1427745 Change-Id: Ib1c71d0d4170ba1a7ed2fe3eaf0e2d8071ec01d6

2015年03月03日 08:58:42 -08:00

LANGUAGE=en_US

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

deps = -r{toxinidir}/requirements.txt

-r{toxinidir}/test-requirements.txt

commands =

find . -type f -name "*.pyc" -delete

move the integrated tests into the functional tree This moves the integrated tests into the functional tree as an initial seed for the functional tests. It was agreed to as an early step at the design summit. Work on cleaning these up will happen after the move. PYTHON_HASH_SEED=0 is needed because these tests apparently remain order dependent. Also remove the use of test.ReplaceModule, which is an untested mocking system in the nova tree that doesn't seem to reliably work. Use stubs instead for the time being, as this will ensure repeatability of the code. Part of bp:functional-tests-for-nova Change-Id: I742c487dd7bca9de3e811c545de477367fff112c

2014年11月24日 09:34:30 -05:00

bash tools/pretty_tox.sh '{posargs}'

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

Remove the nova.config.sample file This file is not gated anymore and therefore it gets out of date. Replacing it with a README that explains how to generate it DocImpact Closes-Bug: 1294774 Change-Id: I2a72a005208a2c86d69ac461d72e54c53bd395cf

2014年03月19日 10:56:49 -07:00

[testenv:genconfig]

Use oslo-config-generator instead of generate_sample.sh Oslo team is actively getting rid of the old style generator.py in openstack/common/config. So we should switch to the newer oslo-config-generator which is the way forward. For simplicity's sake, i used one single list_opts in opts.py. However we can split this up and add entrypoints in setup.cfg if we decide to do that instead. blueprint oslo-config-generator Change-Id: Ib7c72af7be47df08983708ac6da0ce103518b78c

2015年05月04日 23:00:25 -04:00

commands = oslo-config-generator --config-file=etc/nova/nova-config-generator.conf

Remove the nova.config.sample file This file is not gated anymore and therefore it gets out of date. Replacing it with a README that explains how to generate it DocImpact Closes-Bug: 1294774 Change-Id: I2a72a005208a2c86d69ac461d72e54c53bd395cf

2014年03月19日 10:56:49 -07:00

Run coverage tests via xcover for jenkins. In the jenkins jobs, we need to run coverage with xunit output so that jenkins can parse it. Change-Id: Ie4cfec6f89d6b37554b5345cde92f982397915e2

2012年05月25日 15:27:03 -04:00

[testenv:cover]

Use testrepository setuptools support. The previous false-positive bug was fixed upstream in 0.0.13. Change-Id: Iceb07a511992249c104bbc7c34b7c35e01bd9fbd

2013年01月15日 06:40:47 +00:00

# Also do not run test_coverage_ext tests while gathering coverage as those

# tests conflict with coverage.

commands =

Add better coverage support under tox For those in the community who don't use run_tests.sh but want tox to have coverage support this small change should help. It adds coverage erase, combine, html reporting. It also fixes the coverage unit tests in two ways. The first is adding the locking like normal unit tests. The second is adding substring regular expression matching to pick a subset of tests. This brings it up to closer par with run_tests.sh. Change-Id: If9ea229425dc9a191fa7c5cc073cf5da412a69b7

2014年05月20日 14:01:53 -05:00

coverage erase

Switch Nova to use oslo.concurrency Let's switch to the newly released oslo library for the processutils and lockutils. We use the config fixture(s) to specify disable_process_locking and lock_path in the CONF variable of oslo.concurrency library for correctly setting the flags. The previous attempt at updating nova to use oslo.concurrency was reverted as it stopped running any tests. lockutils-wrapper should have been used in ini/shell scripts instead of lockutils.py module as the the module is no longer runnable (__main__ has been removed). In this review we use lockutils-wrapper correctly. The test harness has since been updated to bail out if 0 tests are run as well for additional insurance. Change-Id: I14c75ef2196fd08c9465d648e5cd53777bd9c7d1 Co-Authored-By: Nikola Dipanov <ndipanov@redhat.com> Co-Authored-By: Corey Wright <corey.wright@rackspace.com>

2014年10月24日 14:18:30 -04:00

python setup.py testr --coverage \

Remove exclude coverage regex from coverage job This commit removes the regex to exclude the coverage extension from the tox coverage job. The regex was needed for the unit tests on the coverage extension, (which would mock out coverage) however that extension has since been removed from nova. So we no longer need to exclude tests that don't exist anymore. Change-Id: I45685b1113ecc78eda92f13755ff2274ff517829

2014年09月09日 17:24:22 -04:00

--testr-args='{posargs}'

Add better coverage support under tox For those in the community who don't use run_tests.sh but want tox to have coverage support this small change should help. It adds coverage erase, combine, html reporting. It also fixes the coverage unit tests in two ways. The first is adding the locking like normal unit tests. The second is adding substring regular expression matching to pick a subset of tests. This brings it up to closer par with run_tests.sh. Change-Id: If9ea229425dc9a191fa7c5cc073cf5da412a69b7

2014年05月20日 14:01:53 -05:00

coverage combine

coverage html --include='nova/*' --omit='nova/openstack/common/*' -d covhtml -i

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

[testenv:venv]

Undo tox -e docs pip install sphinx workaround Now that we require at least pbr 1.3 and that has commit 61a3a1ecdf99c680e509742fdc6c441b499af130 in it, let's remove the workaround. Change-Id: I4074b05a823d32f5db0051062527b0db4d379b62 Related-Bug: #1473401

2015年07月15日 06:41:21 -07:00

commands = {posargs}

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

Add specific doc build option to tox Add doc venv to align with other OpenStack projects (such as keystone, heat and nova-specs) who are using 'docs' for there doc builds. Change-Id: I37771db339d864b2b938d1c02d15d38b07093493

2014年04月16日 16:56:00 -07:00

[testenv:docs]

Cleanup bad JSON files - Add missing commas - Replace single quote with double quote - events field contains a list of events (event-create-req.json) - Remove empty files - Adds a JSON validation test to the docs pipeline Co-Authored-By: Nicolas Simonds <nic@metacloud.com> Change-Id: I9a4a9b6b8e2da73b5f25145be3b2faa44ebdb340

2015年01月21日 22:25:10 -05:00

commands =

Remove doc/source/api and doc/build before building docs doc/source/api and doc/build are build artifacts from building the docs using the tox -e docs target. These are ignored in .gitignore since we don't care about them from build to build - but leaving them around can actually make the docs build fail if modules no longer exist but are still sitting in these directories. So this change just cleans those up each time you run tox -e docs. Closes-Bug: #1488637 Change-Id: I646ae0b77a472c425d23815316e804b09bbe867d

2015年08月25日 13:08:31 -07:00

rm -rf doc/source/api doc/build

Cleanup bad JSON files - Add missing commas - Replace single quote with double quote - events field contains a list of events (event-create-req.json) - Remove empty files - Adds a JSON validation test to the docs pipeline Co-Authored-By: Nicolas Simonds <nic@metacloud.com> Change-Id: I9a4a9b6b8e2da73b5f25145be3b2faa44ebdb340

2015年01月21日 22:25:10 -05:00

python setup.py build_sphinx

bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'

Gate on nova.conf.sample generation If someone makes a change that breaks "tox -e genconfig" it is not caught today by any of the gate/check jobs. We should fail at least the docs job by running oslo-config-generator to make sure it works. Change-Id: I63fede4a7b5f358f2212383e2870cc64c4f9f1e4

2015年08月21日 13:20:23 -04:00

oslo-config-generator --config-file=etc/nova/nova-config-generator.conf

Add specific doc build option to tox Add doc venv to align with other OpenStack projects (such as keystone, heat and nova-specs) who are using 'docs' for there doc builds. Change-Id: I37771db339d864b2b938d1c02d15d38b07093493

2014年04月16日 16:56:00 -07:00

Add bandit for security static analysis testing This change adds a basic bandit config for Nova. It can be invoked by running the tox environment for bandit; tox -e bandit This is intended as a starting point for using bandit with Nova and it should be revisited to improve the testing as more is learned about the specific needs of the Nova code base. Tox is configured to only show results for high and medium severity results. https://wiki.openstack.org/wiki/Security/Projects/Bandit Change-Id: I3026b81317f0a6322acfc94784899a7453af586f

2015年05月01日 23:52:34 -07:00

[testenv:bandit]

deps = -r{toxinidir}/test-requirements.txt

commands = bandit -c bandit.yaml -r nova -n 5 -ll

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

[flake8]

Don't gate on E125 E125 overreaches on what pep8 specifies. See https://github.com/jcrocholl/pep8/issues/126 In practice E125 can be a pain as compliance requires manual indenting if using emacs and refactoring tools don't always get it right. There's a bit of a discussion about it here (on a tempest changeset): https://review.openstack.org/#/c/36788/ Change-Id: Ic73ab3c4a47f33de9145e0c7db2d8674230c2fe0

2013年11月20日 22:35:08 +10:30

# E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126

Cleanup the flake8 section of tox.ini * Stop ignoring F403 as we have no cases of it anyway * Cleanup the comments to make it clear what is ignored on purpose and what is ignored until we clean up the code. Change-Id: I2500e2db70b9c71fbed781d8f7b7c80eee45140f

2013年12月11日 19:18:53 +01:00

# The rest of the ignores are TODOs

Move to hacking 0.10 Release notes: http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0 * Remove references in tox.ini to removed rules * Fix minor changes (H501) * Clarify that H306 (imports in alphabetical order shouldn't be skipped) * Ignore H238: check for old style class declarations * Temporary skip W292, fix in next patch. Change-Id: I6d990a564df6a312bd09b2a152315bbdba732082

2015年01月07日 12:09:54 -08:00

# New from hacking 0.9: E129, E131, H407, H405

Cleanup and gate on pep8 rules that are stricter in hacking 0.9 Fix up pep8 failures for rules we previously gated on, but that are now stricter in there enforcement. Ignore E251 due to https://github.com/jcrocholl/pep8/issues/301 Change-Id: I62b33e97c44c4a5be436b381cfbdaeb31cd2638b

2014年06月09日 14:45:26 -07:00

# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301

Cleanup the flake8 section of tox.ini * Stop ignoring F403 as we have no cases of it anyway * Cleanup the comments to make it clear what is ignored on purpose and what is ignored until we clean up the code. Change-Id: I2500e2db70b9c71fbed781d8f7b7c80eee45140f

2013年12月11日 19:18:53 +01:00

Revert : Switch off oslo.* namespace check temporarily In I7033847bab82b6d3cd8f2bdb66c553fec93d7acb, we disabled N333 to allow changes in flight to still mix up oslo_ and oslo. based imports. We should revert the change and enforce every review use just the oslo_ version from now on. Change-Id: I1db83048c569bcdd62538cce9df076fc355f7b26

2015年02月09日 17:34:09 -05:00

ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405

Pep8 didn't check api/openstack/common.py flake8 rule in tox.ini has following exclude rule is exclude = .venv,.git,.tox,dist,doc,*openstack/common* which excludes api/openstack/common.py Change-Id: I39b82cf90048970e7bfc6be77de2e1543130f81b Closes-Bug: 1498634

2015年09月19日 22:58:14 +08:00

exclude = .venv,.git,.tox,dist,doc,*openstack/common/*,*lib/python*,*egg,build,tools/xenserver*

Drop max-complexity to 47 Now that we fixed the two worst offenders, drop the mccabe max-complexity setting in flake8 to 47. Add note explaining how to generate a list of functions that are too 'complex'. Change-Id: I44000e9e95c457ae9000c428460b5825d8ad3f92

2014年10月29日 12:22:29 -07:00

# To get a list of functions that are more complex than 25, set max-complexity

# to 25 and run 'tox -epep8'.

Tox: reduce complexity level to 35 The max-complexity is now set at 35. We are unable to lower this due to the following offenders: ./nova/virt/xenapi/vmops.py:431:1: C901 'VMOps._spawn' is too complex (34) ./nova/network/manager.py:1226:1: C901 'NetworkManager._do_create_networks' is too complex (34) ./nova/network/neutronv2/api.py:370:1: C901 'API.allocate_for_instance' is too complex (34) Change-Id: I6101dcb594b88d346edd72eea2ef2250c4e2891f

2015年03月18日 01:58:30 -07:00

# 34 is currently the most complex thing we have

Put a cap on our cyclomatic complexity flake8 has support for cyclomatic complexity (Mccabe) currently our worst offender has a complexity of 67 (25 is considered very bad). So set our max-complexity to 68 so we at least don't make things any worse. This is the first step in bringing this number down to 25 or so. https://github.com/flintwork/mccabe Change-Id: I5117ca58ad28888e24c16251aa5e92084ead97ca

2014年10月16日 21:04:08 -07:00

# TODO(jogo): get this number down to 25 or so

Tox: reduce complexity level to 35 The max-complexity is now set at 35. We are unable to lower this due to the following offenders: ./nova/virt/xenapi/vmops.py:431:1: C901 'VMOps._spawn' is too complex (34) ./nova/network/manager.py:1226:1: C901 'NetworkManager._do_create_networks' is too complex (34) ./nova/network/neutronv2/api.py:370:1: C901 'API.allocate_for_instance' is too complex (34) Change-Id: I6101dcb594b88d346edd72eea2ef2250c4e2891f

2015年03月18日 01:58:30 -07:00

max-complexity=35

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

[hacking]

local-check-factory = nova.hacking.checks.factory

Use oslo.i18n oslo.i18n provides the i18n functions that were provided by oslo-incubator's gettextutils module. Some tests that were using internal details of the library were removed. Change-Id: I44cfd5552e0dd86af21073419d31622f5fdb28e0

2014年07月11日 21:03:15 -04:00

import_exceptions = nova.i18n

Check requirements.txt files for missing (used) requirements Invoke the pip-missing-reqs tool to find packages used by nova but not explicitly included in its requirements.txt file. Add simplejson to the requirements to fix the failing check. Change-Id: Ia90416c613c0acea04f3d4ab4898f550cb702a49

2014年08月14日 15:06:00 +10:00

[testenv:pip-missing-reqs]

# do not install test-requirements as that will pollute the virtualenv for

# determining missing packages

# this also means that pip-missing-reqs must be installed separately, outside

# of the requirements.txt files

deps = pip_missing_reqs

-rrequirements.txt

2015年05月14日 11:37:28 -07:00

commands=pip-missing-reqs -d --ignore-file=nova/tests/* --ignore-file=nova/test.py nova

openstack/nova - nova - OpenDev: Free Software Needs Free Tools

196 lines 8.2 KiB INI Raw Normal View History Unescape Escape

196 lines

8.2 KiB

INI

Raw Normal View History