openstack/nova - nova - OpenDev: Free Software Needs Free Tools

This website requires JavaScript.

openstack/nova

Code Issues Proposed changes

Files

2ffdf2e9173ca2ad0f95ac7f565da64b8b62691f

nova /tools /flake8wrap.sh

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

28 lines

682 B

Bash

Raw Normal View History

tox: make it possible to run pep8 on current patch only The 'tox -epep8' command takes a long time as it checks every single file in the Nova git repository (~1,400 at time of writing). This makes tox use a simple wrapper around flake8 which can be told to restrict the check to only files changed in the current command. This can be invoked in a simple manner with 'tox -epep8 -- -HEAD'. Since most commits only touch a handful of files, this will usually be far faster than checking all 1,400 source files. To check an entire branch for bisectability it can be automated via git rebase -i master -x 'tox -epep8 -- -HEAD' Change-Id: I157d1ccb883ca02402eee51fd7d6a50f86079389

2015年07月24日 16:05:49 +01:00

#!/bin/sh

#

# A simple wrapper around flake8 which makes it possible

# to ask it to only verify files changed in the current

# git HEAD patch.

#

# Intended to be invoked via tox:

#

# tox -epep8 -- -HEAD

#

if test "x1ドル" = "x-HEAD" ; then

shift

files=$(git diff --name-only HEAD~1 | tr '\n' ' ')

echo "Running flake8 on ${files}"

Integrate 'pre-commit' This nifty tool provides a extensible way to configure pre-commit hooks to do everything from running linters to spellchecking [1] and has already been adopted by a few OpenStack projects [2]. Let's start using it as a faster, more automatic alternative to the 'fast8' tox target and iterate on it as we find more things to use it for. The 'fast8' target is not deprecated though a note is included for end-users to alert them to this great new tool. Note that the 'check-executables-have-shebangs' actually failed and highlighted that the 'contributor/development-environment.rst' document was marked as executable when it shouldn't have been. This is corrected. [1] https://pre-commit.com/ [2] https://review.opendev.org/#/q/file:.pre-commit-config.yaml Change-Id: I256e75eceeb3495dce04885ca42d16adb4160cf3 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

2019年06月15日 16:50:35 +01:00

echo ""

echo "Consider using the 'pre-commit' tool instead."

echo ""

echo " pip install --user pre-commit"

echo " pre-commit install --allow-missing-config"

echo ""

tox: make it possible to run pep8 on current patch only The 'tox -epep8' command takes a long time as it checks every single file in the Nova git repository (~1,400 at time of writing). This makes tox use a simple wrapper around flake8 which can be told to restrict the check to only files changed in the current command. This can be invoked in a simple manner with 'tox -epep8 -- -HEAD'. Since most commits only touch a handful of files, this will usually be far faster than checking all 1,400 source files. To check an entire branch for bisectability it can be automated via git rebase -i master -x 'tox -epep8 -- -HEAD' Change-Id: I157d1ccb883ca02402eee51fd7d6a50f86079389

2015年07月24日 16:05:49 +01:00

diff -u --from-file /dev/null ${files} | flake8 --diff "$@"

else

echo "Running flake8 on all files"

Integrate 'pre-commit' This nifty tool provides a extensible way to configure pre-commit hooks to do everything from running linters to spellchecking [1] and has already been adopted by a few OpenStack projects [2]. Let's start using it as a faster, more automatic alternative to the 'fast8' tox target and iterate on it as we find more things to use it for. The 'fast8' target is not deprecated though a note is included for end-users to alert them to this great new tool. Note that the 'check-executables-have-shebangs' actually failed and highlighted that the 'contributor/development-environment.rst' document was marked as executable when it shouldn't have been. This is corrected. [1] https://pre-commit.com/ [2] https://review.opendev.org/#/q/file:.pre-commit-config.yaml Change-Id: I256e75eceeb3495dce04885ca42d16adb4160cf3 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

2019年06月15日 16:50:35 +01:00

echo ""

tox: make it possible to run pep8 on current patch only The 'tox -epep8' command takes a long time as it checks every single file in the Nova git repository (~1,400 at time of writing). This makes tox use a simple wrapper around flake8 which can be told to restrict the check to only files changed in the current command. This can be invoked in a simple manner with 'tox -epep8 -- -HEAD'. Since most commits only touch a handful of files, this will usually be far faster than checking all 1,400 source files. To check an entire branch for bisectability it can be automated via git rebase -i master -x 'tox -epep8 -- -HEAD' Change-Id: I157d1ccb883ca02402eee51fd7d6a50f86079389

2015年07月24日 16:05:49 +01:00

exec flake8 "$@"

fi

Copy Permalink