openstack/nova - nova - OpenDev: Free Software Needs Free Tools

install_command = pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}

Add missing directive to tox.ini. Change-Id: Ib6d178af62f631de76e66c2bb6c07fd6b277fa97

2012年02月25日 12:25:56 -08:00

setenv = VIRTUAL_ENV={envdir}

move all tests to nova/tests/unit As part of the split of functional and unit tests we need to isolate the unit tests into a separate directory for having multiple test targets in a sane way. Part of bp:functional-tests-for-nova Change-Id: Id42ba373c1bda6a312b673ab2b489ca56da8c628

2014年11月07日 14:27:03 +01:00

OS_TEST_PATH=./nova/tests/unit

Force LANGUAGE=en_US in test runs If your native locale is not en_US and you run tests, some will fail due to the message translation that happens since the assertion messages are in en_US (not translated, just hard-coded in the tests). I recreated the bug by setting LANGUAGE=en_GB in my tox.ini and tested against nova.tests.unit.api.openstack.test_wsgi. Note that setting LANG=en_US had no effect. Closes-Bug: #1427745 Change-Id: Ib1c71d0d4170ba1a7ed2fe3eaf0e2d8071ec01d6

2015年03月03日 08:58:42 -08:00

LANGUAGE=en_US

Force the value of LC_ALL to be en_US.UTF-8 On Python 3, if LC_ALL is not passed then the interpreter will assume it is C (which causes the interpreter to use ASCII). This, in turn, causes the unicode in the README.rst for rfc3986 to trigger a UnicodeDecodeError exception. jlvillal (John Villalovos) pointed out I340c88ea7d098ca5943d60adc73f63a0af79a405 in IRC as the fix to this bug. Closes-bug: 1460206 Change-Id: If05e3fe76450c06431413f63e46e154cf44fc1cf

2015年05月29日 16:41:44 -05:00

LC_ALL=en_US.utf-8

tox: Don't create '.pyc' files There's no reason to create these files and cleaning them up takes precious time during each test run. Don't do it. The benefits of this can be seen in running both the full test suite and part of the test suite. For the former case - running the full test suite: $ time ( tox -e py27 ) Without this change: real 12m48.003s user 38m27.039s sys 1m2.786s With this change: real 11m53.921s user 39m33.360s sys 1m1.686s For the latter case - running part of the full test suite: $ time ( tox -e py27 -- nova.tests.unit.test_configdrive2 ) Without this change: real 2m0.686s user 1m3.080s sys 0m12.950s With this change: real 1m37.098s user 1m16.559s sys 0m11.846s The actual results can vary massively, but this change is always faster. Change-Id: Iffd759e368878f39c015258935d8b37de09d9745

2016年07月06日 13:27:42 +01:00

PYTHONDONTWRITEBYTECODE=1

Remove redundant deps in tox.ini. Tox installs the current tree (either via an sdist or as a develop install) always. Our requirements.txt are reflected into the metadata of that tree, so we shouldn't use requirements.txt directly - it just means that we'd be hiding from ourselves issues like e.g. using URLs which can't be reflected properly. Change-Id: Id096f1d1971cb8a19f9e86ba57957b39e00bd6f5

2015年10月16日 14:30:59 +13:00

deps = -r{toxinidir}/test-requirements.txt

Update tox.ini to support RHEL 6.x. In order to support running unit tests on RHEL 6.x we need to patch eventlet with contrib/redhat-eventlet.patch. We already have support for this in the tools/install_venv_common.py but we need to make a couple changes to allow tox to consume this: 1) Sync in the latest intall_venv_common.py from oslo. This changes patch to use the -N option (ignore already applied patches) and makes it safe to call the patching function more than once. 2) Add a new patch_tox_venv.py script in tools. 3) Update tox.ini to call patch_tox_venv.py before it runs tests and coverage. Change-Id: I3e2b07c3f718e4aede5c5f231ff0cdb7721ec885

2013年03月06日 16:00:37 -05:00

commands =

bring over pretty_tox.sh from tempest Tempest developed a set of wrappers around testr to print out tests as they are running through using the subunit stream. This also displays which workers the various tests are running on. Adapted for nova's need for loading the locking. I expect that the needs of nova will diverge this over time, especially what's displayed during tracing, as such I think it's fine to just do a transplant and not try to turn this into some external repo. Change-Id: Ied1708515fc49f4e18cd8dbb7b2cd821f85e1966

2014年09月16日 11:49:11 -04:00

bash tools/pretty_tox.sh '{posargs}'

Pass OS_DEBUG to the tox test environment The StandardLogging fixture defaults to log level INFO and has the ability to log at level DEBUG if the OS_DEBUG environment variable is set to a true value. Let tox copy OS_DEBUG to the test environment to allow debug log capture for a command line like: OS_DEBUG=True tox -epy27 Change-Id: Ibe51653f652c99aee56f702be571130cbb7f913d

2016年05月21日 01:44:58 +00:00

passenv = http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY OS_DEBUG

support TRACE_FAILONLY env variable In order to get similar behavior to the way testr out of the box works, only displaying failing results, all the user to define TRACE_FAILONLY environment variable (any value will do). After this point only failures, and things leaking out of stderr will end up on the screen. We also need to remove the suppression of the inline fail dumps for this to have the impact that you'd expect. Change-Id: I72911adc8a03450522429c52db661ec0a1bc4678

2014年09月24日 13:56:49 -04:00

# there is also secret magic in pretty_tox.sh which lets you run in a fail only

# mode. To do this define the TRACE_FAILONLY environmental variable.

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

[testenv:pep8]

always use python2.7 for pep8 pep8 doesn't work with python3 on our codebase. If someone is on a platform that defaults to python => python3, pep8 won't work for them. This is actually really easy to fix with a single line in tox. Change-Id: I7a888e4f7cc828638a9d61d2249a854ba1f3cb7b Closes-Bug: #1456955

2016年02月19日 21:10:42 -05:00

basepython = python2.7

reduce pep8 requirements to just hacking Because we are constrained by the constraints mechanism we no longer need to install all of test-requirements to get hacking at the right version, because we'll only install the upper-constraints version. Change-Id: I877ffec045cc43a32f97be8afe453d4755507217

2016年01月13日 13:49:13 -05:00

deps = hacking

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

commands =

tox: make it possible to run pep8 on current patch only The 'tox -epep8' command takes a long time as it checks every single file in the Nova git repository (~1,400 at time of writing). This makes tox use a simple wrapper around flake8 which can be told to restrict the check to only files changed in the current command. This can be invoked in a simple manner with 'tox -epep8 -- -HEAD'. Since most commits only touch a handful of files, this will usually be far faster than checking all 1,400 source files. To check an entire branch for bisectability it can be automated via git rebase -i master -x 'tox -epep8 -- -HEAD' Change-Id: I157d1ccb883ca02402eee51fd7d6a50f86079389

2015年07月24日 16:05:49 +01:00

bash tools/flake8wrap.sh {posargs}

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

Run tests with PyMySQL on Python 3 Add test-requirements-py3.txt to use PyMySQL, instead of MySQL-python, on Python 3. Add a py34 test environment to tox.ini which uses test-requirements-py3.txt and sets OS_TEST_DBAPI_ADMIN_CONNECTION to use the PyMySQL connector instead of the MySQL-python connector. This change is based on Ironic tox.ini, so I added Victor Sergeyev as the coauthor of the patch. Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com> Blueprint nova-python3 Change-Id: I5a27c7d627105b614da3cab3a87296a8e186b555

2015年05月22日 10:17:27 -07:00

[testenv:py34]

Add a note about fixing "db type could not be determined" with py34 Due to testrepository bug 1212909, if you run py27 before py34, py34 fails with "db type could not be determined". The workaround is to delete the .testrepository directory and try again. As long as you run py34 before py27 you're OK. Change-Id: I13c4f9a39b97573e78fe397efc7d87f78bac4a58

2015年12月08日 14:38:10 -08:00

# NOTE(mriedem): If py34 fails with "db type could not be determined", delete

# .testrepository and try again. Running py34 before py27 is OK, but not the

# other way around. See: https://bugs.launchpad.net/testrepository/+bug/1212909

Remove unneeded OS_TEST_DBAPI_ADMIN_CONNECTION The desired OS_TEST_DBAPI_ADMIN_CONNECTION string is now reflected in the oslo.db 1.12.0 release's default behavior, and so does not need to be set any longer to achieve the same opportunistic backend discovery for tests. Change-Id: I1af372f6f18038e8fc63076b4e399d0ae86f5a23

2015年07月03日 23:06:13 +00:00

setenv = {[testenv]setenv}

Fix version unit test on Python 3 With this change, "tox -e py34" now pass. Changes: * Replace unichr() with six.unichr() * Replace StringIO.StringIO() with six.Bytes() in nova.crypto.generate_key_pair() * On Python 3, replace UserDict.IterableUserDict with collections.UserDict * Replace __builtin__.open with six.moves.builtins.open * Replace ConfigParser import with six.moves.configparser * On Python 3, get the original "queue" module instead of the "Queue" module in nova/virt/libvirt/host.py * Replace urllib2 with six.moves.urllib * tox.ini: "tox -e py34" now only runs nova.tests.unit.test_versions Blueprint nova-python3 Change-Id: I056769c7c5b32276894f7aade8c0a27af81c42ae

2015年05月25日 13:22:29 +02:00

commands =

Add ability to select specific tests for py34 For py27 you can simply run specific tests by calling tox -e py27 nova.tests.unit.test_something Add a similiar option for the py34 environment. This will skip the blacklist of tests that would otherwise be ignored for python3. Change-Id: I9bf5901afed4abf592e1aaff2f4820b9e3abc671

2016年06月23日 10:51:04 +02:00

bash tools/pretty_tox3.sh '{posargs}'

Run tests with PyMySQL on Python 3 Add test-requirements-py3.txt to use PyMySQL, instead of MySQL-python, on Python 3. Add a py34 test environment to tox.ini which uses test-requirements-py3.txt and sets OS_TEST_DBAPI_ADMIN_CONNECTION to use the PyMySQL connector instead of the MySQL-python connector. This change is based on Ironic tox.ini, so I added Victor Sergeyev as the coauthor of the patch. Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com> Blueprint nova-python3 Change-Id: I5a27c7d627105b614da3cab3a87296a8e186b555

2015年05月22日 10:17:27 -07:00

Add a py35 environment to tox Infra will start running python35 jobs soon [1], targeting to replace the current python34 jobs. This is due to the change from Ubuntu Trusty to Xenial, where only python3.5 will be available. So we add a py35 environment with the same definitions for skipping not-yet-working checks as we have in place for py34 already. [1] https://review.openstack.org/336272 Change-Id: I017478fafa31121f40c95d73e49ac4dced80c7a2

2016年07月01日 10:40:08 +02:00

[testenv:py35]

setenv = {[testenv]setenv}

commands =

bash tools/pretty_tox3.sh '{posargs}'

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

[testenv:functional]

usedevelop = True

setenv = VIRTUAL_ENV={envdir}

OS_TEST_PATH=./nova/tests/functional

Force LANGUAGE=en_US in test runs If your native locale is not en_US and you run tests, some will fail due to the message translation that happens since the assertion messages are in en_US (not translated, just hard-coded in the tests). I recreated the bug by setting LANGUAGE=en_GB in my tox.ini and tested against nova.tests.unit.api.openstack.test_wsgi. Note that setting LANG=en_US had no effect. Closes-Bug: #1427745 Change-Id: Ib1c71d0d4170ba1a7ed2fe3eaf0e2d8071ec01d6

2015年03月03日 08:58:42 -08:00

LANGUAGE=en_US

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

commands =

move the integrated tests into the functional tree This moves the integrated tests into the functional tree as an initial seed for the functional tests. It was agreed to as an early step at the design summit. Work on cleaning these up will happen after the move. PYTHON_HASH_SEED=0 is needed because these tests apparently remain order dependent. Also remove the use of test.ReplaceModule, which is an untested mocking system in the nova tree that doesn't seem to reliably work. Use stubs instead for the time being, as this will ensure repeatability of the code. Part of bp:functional-tests-for-nova Change-Id: I742c487dd7bca9de3e811c545de477367fff112c

2014年11月24日 09:34:30 -05:00

bash tools/pretty_tox.sh '{posargs}'

Add tox -e functional Provide a tox -e functional stub, as a place for functional tests to migrate to. This will allow us to write a zuul test configuration for this environment. Part of bp:functional-tests-for-nova Change-Id: I8a1107beab151f9bf574cfbae1d4dc18400fd74e

2014年11月06日 11:32:34 +01:00

add api-samples tox target api-samples generation is no longer straight forward, now that tox is blocking environment changes, and that PYTHONHASHSEED is randomized in each run. This creates a tox target to make it easy to generate the api-samples. Change-Id: Ie88597fecee5ce81fb29ce2cfb73b15d60f3f389

2015年12月03日 17:24:53 -05:00

[testenv:api-samples]

usedevelop = True

setenv = VIRTUAL_ENV={envdir}

GENERATE_SAMPLES=True

PYTHONHASHSEED=0

OS_TEST_PATH=./nova/tests/functional/api_sample_tests

LANGUAGE=en_US

commands =

bash tools/pretty_tox.sh '{posargs}'

Remove the nova.config.sample file This file is not gated anymore and therefore it gets out of date. Replacing it with a README that explains how to generate it DocImpact Closes-Bug: 1294774 Change-Id: I2a72a005208a2c86d69ac461d72e54c53bd395cf

2014年03月19日 10:56:49 -07:00

[testenv:genconfig]

Use oslo-config-generator instead of generate_sample.sh Oslo team is actively getting rid of the old style generator.py in openstack/common/config. So we should switch to the newer oslo-config-generator which is the way forward. For simplicity's sake, i used one single list_opts in opts.py. However we can split this up and add entrypoints in setup.cfg if we decide to do that instead. blueprint oslo-config-generator Change-Id: Ib7c72af7be47df08983708ac6da0ce103518b78c

2015年05月04日 23:00:25 -04:00

commands = oslo-config-generator --config-file=etc/nova/nova-config-generator.conf

Remove the nova.config.sample file This file is not gated anymore and therefore it gets out of date. Replacing it with a README that explains how to generate it DocImpact Closes-Bug: 1294774 Change-Id: I2a72a005208a2c86d69ac461d72e54c53bd395cf

2014年03月19日 10:56:49 -07:00

Add policy sample generation This adds the entry point and config file necessary for using the oslo.policy sample generation script. It also adds a tox target to simplify the usage of it. The command is also run in the docs tox target since the sample file can be considered documentation. Change-Id: I18a1fa567fc04b0e0a37c02f20024b2ce483f060 Partially-Implements: bp policy-in-code

2016年06月21日 16:53:57 -04:00

[testenv:genpolicy]

commands = oslopolicy-sample-generator --config-file=etc/nova/nova-policy-generator.conf

Run coverage tests via xcover for jenkins. In the jenkins jobs, we need to run coverage with xunit output so that jenkins can parse it. Change-Id: Ie4cfec6f89d6b37554b5345cde92f982397915e2

2012年05月25日 15:27:03 -04:00

[testenv:cover]

Use testrepository setuptools support. The previous false-positive bug was fixed upstream in 0.0.13. Change-Id: Iceb07a511992249c104bbc7c34b7c35e01bd9fbd

2013年01月15日 06:40:47 +00:00

# Also do not run test_coverage_ext tests while gathering coverage as those

# tests conflict with coverage.

always use pip constraints This flips the tox.ini to always use constraints installation for all targets. It drops the extra -constraints targets in the process. This makes it so there is no developer change required to operate in our new world order. Change-Id: I857032002c2ca873510ce7c39138e0e35cc5d3b3

2016年01月13日 13:46:40 -05:00

# NOTE(sdague): this target does not use constraints because

# upstream infra does not yet support it. Once that's fixed, we can

# drop the install_command.

install_command = pip install -U --force-reinstall {opts} {packages}

Add -constraints sections for CI jobs Tox does not currently support using factors with sections, and work towards enabling this has stalled, as such we will need to duplicate sections adding -constraints to facilitate running sections with the constrained install_command. Implements Blueprint: Requirements-Management Change-Id: Icbbb78cfcd074b0050e60c54557637af723f9b92

2015年10月19日 17:38:17 +11:00

commands =

coverage erase

python setup.py testr --coverage \

--testr-args='{posargs}'

coverage combine

Nuke cliutils from oslo-incubator Oslo team won't create new libary to include functions of module cliutils. Nova only use two methods in cmd/manage.py, so copy these two methods to nova/utils.py and clean up oslo-incubator related stuff. Note:There is tiny change of method validate_args to make it Python 3 compatible. Change-Id: Ibef5076f9556fa3224c2ca32e8c7fe2c4c1f739b

2016年03月03日 20:13:16 +08:00

coverage html --include='nova/*' -d covhtml -i

Add -constraints sections for CI jobs Tox does not currently support using factors with sections, and work towards enabling this has stalled, as such we will need to duplicate sections adding -constraints to facilitate running sections with the constrained install_command. Implements Blueprint: Requirements-Management Change-Id: Icbbb78cfcd074b0050e60c54557637af723f9b92

2015年10月19日 17:38:17 +11:00

Support tox-based unittests. Change-Id: I6a0a616a979688595762e6b772d77a14f1968070

2012年01月07日 19:34:41 -08:00

[testenv:venv]

Do not use constraints for venv The venv environment is used by infra scripts to build tarballs and documents - and used by both check and post jobs. In post jobs, we currently do not support constraints, so add the non-constraints install command here so that nova-docs (publishing of documents to docs.openstack.org) and the tarball jobs work again. Change-Id: I2e5c0a4d739296b8b9d4ef7f58b69e1eff3c9575

2016年02月28日 19:06:50 +01:00

# NOTE(jaegerandi): This target does not use constraints because

# upstream infra does not yet support it. Once that's fixed, we can

# drop the install_command.

install_command = pip install -U --force-reinstall {opts} {packages}

Undo tox -e docs pip install sphinx workaround Now that we require at least pbr 1.3 and that has commit 61a3a1ecdf99c680e509742fdc6c441b499af130 in it, let's remove the workaround. Change-Id: I4074b05a823d32f5db0051062527b0db4d379b62 Related-Bug: #1473401

2015年07月15日 06:41:21 -07:00

commands = {posargs}

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

Add specific doc build option to tox Add doc venv to align with other OpenStack projects (such as keystone, heat and nova-specs) who are using 'docs' for there doc builds. Change-Id: I37771db339d864b2b938d1c02d15d38b07093493

2014年04月16日 16:56:00 -07:00

[testenv:docs]

Cleanup bad JSON files - Add missing commas - Replace single quote with double quote - events field contains a list of events (event-create-req.json) - Remove empty files - Adds a JSON validation test to the docs pipeline Co-Authored-By: Nicolas Simonds <nic@metacloud.com> Change-Id: I9a4a9b6b8e2da73b5f25145be3b2faa44ebdb340

2015年01月21日 22:25:10 -05:00

commands =

Final warnings removals for api-ref This removes the final warnings from the api-ref code base, and flips the sphinx switch to enforce warnings as errors. It also adds code to the rest_parameters extension to make it more clear where a problem is when it comes to included parameters. This puts us in a place where we can start doing the file per file look at content. Part of bp:api-ref-in-rst Change-Id: Ic2c99d96d6addcafa00b9f16785c2fe59b1798d3

2016年04月20日 11:20:05 -04:00

rm -rf doc/source/api doc/build api-guide/build api-ref/build

Cleanup bad JSON files - Add missing commas - Replace single quote with double quote - events field contains a list of events (event-create-req.json) - Remove empty files - Adds a JSON validation test to the docs pipeline Co-Authored-By: Nicolas Simonds <nic@metacloud.com> Change-Id: I9a4a9b6b8e2da73b5f25145be3b2faa44ebdb340

2015年01月21日 22:25:10 -05:00

python setup.py build_sphinx

bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'

Gate on nova.conf.sample generation If someone makes a change that breaks "tox -e genconfig" it is not caught today by any of the gate/check jobs. We should fail at least the docs job by running oslo-config-generator to make sure it works. Change-Id: I63fede4a7b5f358f2212383e2870cc64c4f9f1e4

2015年08月21日 13:20:23 -04:00

oslo-config-generator --config-file=etc/nova/nova-config-generator.conf

Add policy sample generation This adds the entry point and config file necessary for using the oslo.policy sample generation script. It also adds a tox target to simplify the usage of it. The command is also run in the docs tox target since the sample file can be considered documentation. Change-Id: I18a1fa567fc04b0e0a37c02f20024b2ce483f060 Partially-Implements: bp policy-in-code

2016年06月21日 16:53:57 -04:00

oslopolicy-sample-generator --config-file=etc/nova/nova-policy-generator.conf

Error on API Guide warnings Error on warnings in building the API guide and fix any problem encountered: * tox.ini: Enable tread warnings as errors * index.rst: Add unreferenced file extra_specs_and_properties as hidden file so that it does not show up in index. It is still built and will be referenced from other files. * general_info.rst: Remove reference to non-existing file * server_concept: Add missing empty line after code directives Also fix a typo and remove extra EOL whitespace. Change-Id: Ie766f8d2f7d82b7b5b02541b342f9829ca4550a0

2016年03月13日 21:08:49 +01:00

sphinx-build -W -b html api-guide/source api-guide/build/html

Final warnings removals for api-ref This removes the final warnings from the api-ref code base, and flips the sphinx switch to enforce warnings as errors. It also adds code to the rest_parameters extension to make it more clear where a problem is when it comes to included parameters. This puts us in a place where we can start doing the file per file look at content. Part of bp:api-ref-in-rst Change-Id: Ic2c99d96d6addcafa00b9f16785c2fe59b1798d3

2016年04月20日 11:20:05 -04:00

sphinx-build -W -b html api-ref/source api-ref/build/html

Rearranges to create new Compute API Guide Uses openstackdocstheme to match other content Has a dependent change in project-config also so that file will build to developer.openstack.org/compute at https://review.openstack.org/#/c/231000/ Change-Id: Ic060a1e79e4b2f8695cb788ff4df018e0cfd3286

2015年10月01日 17:27:50 -05:00

[testenv:api-guide]

# This environment is called from CI scripts to test and publish

# the API Guide to developer.openstack.org.

always use pip constraints This flips the tox.ini to always use constraints installation for all targets. It drops the extra -constraints targets in the process. This makes it so there is no developer change required to operate in our new world order. Change-Id: I857032002c2ca873510ce7c39138e0e35cc5d3b3

2016年01月13日 13:46:40 -05:00

# NOTE(sdague): this target does not use constraints because

# upstream infra does not yet support it. Once that's fixed, we can

# drop the install_command.

install_command = pip install -U --force-reinstall {opts} {packages}

Rearranges to create new Compute API Guide Uses openstackdocstheme to match other content Has a dependent change in project-config also so that file will build to developer.openstack.org/compute at https://review.openstack.org/#/c/231000/ Change-Id: Ic060a1e79e4b2f8695cb788ff4df018e0cfd3286

2015年10月01日 17:27:50 -05:00

commands =

Error on API Guide warnings Error on warnings in building the API guide and fix any problem encountered: * tox.ini: Enable tread warnings as errors * index.rst: Add unreferenced file extra_specs_and_properties as hidden file so that it does not show up in index. It is still built and will be referenced from other files. * general_info.rst: Remove reference to non-existing file * server_concept: Add missing empty line after code directives Also fix a typo and remove extra EOL whitespace. Change-Id: Ie766f8d2f7d82b7b5b02541b342f9829ca4550a0

2016年03月13日 21:08:49 +01:00

sphinx-build -W -b html -d api-guide/build/doctrees api-guide/source api-guide/build/html

Add specific doc build option to tox Add doc venv to align with other OpenStack projects (such as keystone, heat and nova-specs) who are using 'docs' for there doc builds. Change-Id: I37771db339d864b2b938d1c02d15d38b07093493

2014年04月16日 16:56:00 -07:00

Add sample API content This adds sample API content for versions and servers resources, including the parameters.yaml that is needed in both of these cases. It also makes a new tox.ini target 'api-ref' for building these docs, which will be used as part of the publishing pipeline. Change-Id: I310ed352dc5dd81d01f2fd5f1a2fab662c29f0dc

2016年03月29日 11:56:21 -04:00

[testenv:api-ref]

# This environment is called from CI scripts to test and publish

# the API Ref to developer.openstack.org.

# NOTE(sdague): this target does not use constraints because

# upstream infra does not yet support it. Once that's fixed, we can

# drop the install_command.

install_command = pip install -U --force-reinstall {opts} {packages}

commands =

Final warnings removals for api-ref This removes the final warnings from the api-ref code base, and flips the sphinx switch to enforce warnings as errors. It also adds code to the rest_parameters extension to make it more clear where a problem is when it comes to included parameters. This puts us in a place where we can start doing the file per file look at content. Part of bp:api-ref-in-rst Change-Id: Ic2c99d96d6addcafa00b9f16785c2fe59b1798d3

2016年04月20日 11:20:05 -04:00

rm -rf api-ref/build

sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html

Add sample API content This adds sample API content for versions and servers resources, including the parameters.yaml that is needed in both of these cases. It also makes a new tox.ini target 'api-ref' for building these docs, which will be used as part of the publishing pipeline. Change-Id: I310ed352dc5dd81d01f2fd5f1a2fab662c29f0dc

2016年03月29日 11:56:21 -04:00

Add bandit for security static analysis testing This change adds a basic bandit config for Nova. It can be invoked by running the tox environment for bandit; tox -e bandit This is intended as a starting point for using bandit with Nova and it should be revisited to improve the testing as more is learned about the specific needs of the Nova code base. Tox is configured to only show results for high and medium severity results. https://wiki.openstack.org/wiki/Security/Projects/Bandit Change-Id: I3026b81317f0a6322acfc94784899a7453af586f

2015年05月01日 23:52:34 -07:00

[testenv:bandit]

commands = bandit -c bandit.yaml -r nova -n 5 -ll

Add reno for release notes management Since reno is the new tool for Relnotes [1], we need to add it to Nova and provide some Sphinx docs for Liberty and Mitaka. Change-Id: Ibd74e62b6f36076dbec17dd146632fd42aad6eb2

2015年11月05日 12:12:28 +01:00

[testenv:releasenotes]

always use pip constraints This flips the tox.ini to always use constraints installation for all targets. It drops the extra -constraints targets in the process. This makes it so there is no developer change required to operate in our new world order. Change-Id: I857032002c2ca873510ce7c39138e0e35cc5d3b3

2016年01月13日 13:46:40 -05:00

# NOTE(sdague): this target does not use constraints because

# upstream infra does not yet support it. Once that's fixed, we can

# drop the install_command.

install_command = pip install -U --force-reinstall {opts} {packages}

Remove releasenotes/build between releasenotes runs Just like in the docs target, we should remove the releasenotes/build directory between runs of the releasenotes target to avoid stale sphinx results corrupting the current run results. Change-Id: Ia9e0409344671e04148308e08c26e8796227f0f7 Closes-Bug: #1534640

2016年01月18日 12:42:27 -08:00

commands =

rm -rf releasenotes/build

sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html

Add reno for release notes management Since reno is the new tool for Relnotes [1], we need to add it to Nova and provide some Sphinx docs for Liberty and Mitaka. Change-Id: Ibd74e62b6f36076dbec17dd146632fd42aad6eb2

2015年11月05日 12:12:28 +01:00

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

[flake8]

Don't gate on E125 E125 overreaches on what pep8 specifies. See https://github.com/jcrocholl/pep8/issues/126 In practice E125 can be a pain as compliance requires manual indenting if using emacs and refactoring tools don't always get it right. There's a bit of a discussion about it here (on a tempest changeset): https://review.openstack.org/#/c/36788/ Change-Id: Ic73ab3c4a47f33de9145e0c7db2d8674230c2fe0

2013年11月20日 22:35:08 +10:30

# E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126

Cleanup the flake8 section of tox.ini * Stop ignoring F403 as we have no cases of it anyway * Cleanup the comments to make it clear what is ignored on purpose and what is ignored until we clean up the code. Change-Id: I2500e2db70b9c71fbed781d8f7b7c80eee45140f

2013年12月11日 19:18:53 +01:00

# The rest of the ignores are TODOs

Move to hacking 0.10 Release notes: http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0 * Remove references in tox.ini to removed rules * Fix minor changes (H501) * Clarify that H306 (imports in alphabetical order shouldn't be skipped) * Ignore H238: check for old style class declarations * Temporary skip W292, fix in next patch. Change-Id: I6d990a564df6a312bd09b2a152315bbdba732082

2015年01月07日 12:09:54 -08:00

# New from hacking 0.9: E129, E131, H407, H405

Cleanup and gate on pep8 rules that are stricter in hacking 0.9 Fix up pep8 failures for rules we previously gated on, but that are now stricter in there enforcement. Ignore E251 due to https://github.com/jcrocholl/pep8/issues/301 Change-Id: I62b33e97c44c4a5be436b381cfbdaeb31cd2638b

2014年06月09日 14:45:26 -07:00

# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301

Cleanup the flake8 section of tox.ini * Stop ignoring F403 as we have no cases of it anyway * Cleanup the comments to make it clear what is ignored on purpose and what is ignored until we clean up the code. Change-Id: I2500e2db70b9c71fbed781d8f7b7c80eee45140f

2013年12月11日 19:18:53 +01:00

Revert : Switch off oslo.* namespace check temporarily In I7033847bab82b6d3cd8f2bdb66c553fec93d7acb, we disabled N333 to allow changes in flight to still mix up oslo_ and oslo. based imports. We should revert the change and enforce every review use just the oslo_ version from now on. Change-Id: I1db83048c569bcdd62538cce9df076fc355f7b26

2015年02月09日 17:34:09 -05:00

ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405

Nuke cliutils from oslo-incubator Oslo team won't create new libary to include functions of module cliutils. Nova only use two methods in cmd/manage.py, so copy these two methods to nova/utils.py and clean up oslo-incubator related stuff. Note:There is tiny change of method validate_args to make it Python 3 compatible. Change-Id: Ibef5076f9556fa3224c2ca32e8c7fe2c4c1f739b

2016年03月03日 20:13:16 +08:00

exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools/xenserver*,releasenotes

Drop max-complexity to 47 Now that we fixed the two worst offenders, drop the mccabe max-complexity setting in flake8 to 47. Add note explaining how to generate a list of functions that are too 'complex'. Change-Id: I44000e9e95c457ae9000c428460b5825d8ad3f92

2014年10月29日 12:22:29 -07:00

# To get a list of functions that are more complex than 25, set max-complexity

# to 25 and run 'tox -epep8'.

Tox: reduce complexity level to 35 The max-complexity is now set at 35. We are unable to lower this due to the following offenders: ./nova/virt/xenapi/vmops.py:431:1: C901 'VMOps._spawn' is too complex (34) ./nova/network/manager.py:1226:1: C901 'NetworkManager._do_create_networks' is too complex (34) ./nova/network/neutronv2/api.py:370:1: C901 'API.allocate_for_instance' is too complex (34) Change-Id: I6101dcb594b88d346edd72eea2ef2250c4e2891f

2015年03月18日 01:58:30 -07:00

# 34 is currently the most complex thing we have

Put a cap on our cyclomatic complexity flake8 has support for cyclomatic complexity (Mccabe) currently our worst offender has a complexity of 67 (25 is considered very bad). So set our max-complexity to 68 so we at least don't make things any worse. This is the first step in bringing this number down to 25 or so. https://github.com/flintwork/mccabe Change-Id: I5117ca58ad28888e24c16251aa5e92084ead97ca

2014年10月16日 21:04:08 -07:00

# TODO(jogo): get this number down to 25 or so

Tox: reduce complexity level to 35 The max-complexity is now set at 35. We are unable to lower this due to the following offenders: ./nova/virt/xenapi/vmops.py:431:1: C901 'VMOps._spawn' is too complex (34) ./nova/network/manager.py:1226:1: C901 'NetworkManager._do_create_networks' is too complex (34) ./nova/network/neutronv2/api.py:370:1: C901 'API.allocate_for_instance' is too complex (34) Change-Id: I6101dcb594b88d346edd72eea2ef2250c4e2891f

2015年03月18日 01:58:30 -07:00

max-complexity=35

Switch to flake8+hacking. Remove a bunch of local custom scripts. Replace with configurable external tools. Use local hacking checks for nova specifics. Change-Id: I75a01375ba0ec36d2ff05abc47abe0a3f225eda5

2013年05月17日 12:54:12 -07:00

[hacking]

local-check-factory = nova.hacking.checks.factory

Use oslo.i18n oslo.i18n provides the i18n functions that were provided by oslo-incubator's gettextutils module. Some tests that were using internal details of the library were removed. Change-Id: I44cfd5552e0dd86af21073419d31622f5fdb28e0

2014年07月11日 21:03:15 -04:00

import_exceptions = nova.i18n

Check requirements.txt files for missing (used) requirements Invoke the pip-missing-reqs tool to find packages used by nova but not explicitly included in its requirements.txt file. Add simplejson to the requirements to fix the failing check. Change-Id: Ia90416c613c0acea04f3d4ab4898f550cb702a49

2014年08月14日 15:06:00 +10:00

[testenv:pip-missing-reqs]

# do not install test-requirements as that will pollute the virtualenv for

# determining missing packages

# this also means that pip-missing-reqs must be installed separately, outside

# of the requirements.txt files

deps = pip_missing_reqs

2015年05月14日 11:37:28 -07:00

commands=pip-missing-reqs -d --ignore-file=nova/tests/* --ignore-file=nova/test.py nova

openstack/nova - nova - OpenDev: Free Software Needs Free Tools

156 lines 5.7 KiB INI Raw Normal View History Unescape Escape

156 lines

5.7 KiB

INI

Raw Normal View History