openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

This patch adapts the bagpipe driver to the changes committed in
I1fdf260b98d0d1f71d21cfd02636cf014c81c72c
Partially-Implements: blueprint split-association-api
Change-Id: Ieb35afe5599f029963bc85322ef783e57f066e02

The project networking-bagpipe-l2 is hosted under the stackforge
repository not under the openstack repository.
This patch corrects the README links and also moves git links from
github to openstack.
Change-Id: I802760a41f41016d7cce29a87e803cc700ce06fc

Without enforce_policy, the policy is applied on some, but not all
actions (eg. GET but not UPDATE).
This change adds 'enforce_policy' to all attributes.
Closes-Bug: 1494771
Change-Id: Id59b5ae947d4c71ff416f26231b140554d9be1a0

The class inheritance was wrong, resulting in
the empty args2body method from extension.ClientExtensionXXX to
override the more useful one we define in BGPVPNCreateUpdateCommonMixin.
Change-Id: I3779571e97d3c2a9bf274b6de0dc56596786e750

Change-Id: I8cfa499f044ee4ae38a625f87143f533d9bd568d

It is too late to call neutron_service_plugin_class_add at post-config.
Change-Id: Id8140f43daafdd314ad63dd2a39db55b1e7cb8b5

Log a warning on service plugin startup if multiple service
drivers are configured for our plugin.
Change-Id: Ia04f7136acc00b37d386168f3dfde449d0db969c
Closes-bug: 1492323

Devstack will now use the help for adding a service
plugin definition, thus avoiding the definition of
Q_SERVICE_PLUGIN_CLASSES in local.conf.
Change-Id: I3299a5a7f35ea7eff5353cc1028b056da3b0c33f

Now that the new API is merged, it's time to replace
the old spec by a pointer to the new specs, even it is still
in a gerrit change.
Change-Id: Ib46bbf561e342092e3fb07d2dc16dd117cd0f766

This patch adapts neutronclient to the new association API:
- 'BGPVPNConnection' is now 'BGPVPN'
- the network_id attribute of BGPVPNConnection is removed
- new commands for network associate and disassociate
- update examples in README.rst
- make the spec file point to the API currently discussed
Partially-Implements: blueprint split-association-api
Change-Id: Ia624c54a513c6c36183a196601d29993fcf7e023

This patch introduces the new API to associate/disassociate a
network to a bgpvpn object.
A new association table is introduced to manage the many to many
relationship between bgpvpns and networks.
It also changes the resource name from bgpvpn-connection to
bgpvpn.
Partially-Implements: blueprint split-association-api
Change-Id: I1fdf260b98d0d1f71d21cfd02636cf014c81c72c

Bagpipe RPCs are renamed by a pending change in
stackforge/networking-bagpipe-l2.
Change-Id: I2d1751c0d6ae03749a790855ed4d6ad3bd5b727c
Depends-On: Iebae9059a9c44dba327efdf9538660575b8708aa

This change makes the bagpipe driver use the Neutron
registry callbacks instead of a custom ML2 mech driver.
The now obsolete bgpvpn_notify mech driver still exists
to avoid breaking past configs, but it is empty and logs
a warning on startup.
With this change, the bagpipe driver also stops
preventing network deletion, because without a mech driver
we can't, which is good since it fixes bug 1489881.
This change also changes the behavior to ignore DHCP ports.
Implements: blueprint bagpipe-use-neutron-registry
Closes-Bug: 1489881
Partial-Bug: 1492349
Change-Id: I0dcfbadd222ad1f9768f4546118cb311fbfbdb51

This change updates the JSON policy file:
- control the tenant_id resource (RW admin-only)
- do not provide a policy for updating type (which is specified
 as a read-only attribute by the resource map)
- some minor re-ordering for consistency
Change-Id: Ie36b9562403eedb888e66e307a3db58cdc8c1c7c
Closes-bug: 1491466
Closes-bug: 1491040

A typo was in the local.conf example.
Change-Id: Ic2c99e0bcc4aa5a230b5947b91a8d235dee4b35e

Initial commit with route_distinguishers. Affected the DB scheme
and the migration code.
Partially-Implements: blueprint api-optional-rd-list
Change-Id: Idf76c7a71591e3de1043e3b7ca614ba36c470441

The config file for service providers had a "-" instead of a "_".
Change-Id: I312954563c19622871d336fd33e7bc2bebd586f4

With this patch, Neutron will read (/etc/neutron/)networking_bgpvpn.conf
for service_provider definitions, thus allowing the use of
the BGPVPN service plugin additionally to other service relying
on their own neutron_*aas.conf file.
This patch also fixes README and devstack behavior so that
a default networking-bgpvpn.conf file is deployed.
This depends on change Ia4cad678e6c722ca05821dbdbf05d61523246a86
Change-Id: Ifebe4c965448431737d9f0e4c25605b718850460
Closes-bug: 1473119

Need to create neutron/policy.d directory before
copying our policy file there.
Change-Id: I8ffc6950f21163e03ac80633579eb14e3ff56b32

Completes/fixes change 218359.
A portion of code was not tested by the unit test which
does not test whether the context is admin or not, which
is the intent since policy ought to be controlled through
the policy.json framework only.
Change-Id: I3b9a5b60ac47dbb0454c435112fdcb7312a36bdf

This patch follows the change oslo.config into oslo_config.
Change-Id: Ia8a3e8b0955e45424f5fcb3c35bff09d37c76238

This change removes the USER_READABLE_ATTRIBUTES and USER_WRITABLE_ATTRIBUTES,
and skips other checks/subcases that were applied depending on whether the
context was admin or not.
Change-Id: I4a64da35ccede45427bfe79e1bcdd22ed14b401d
Closes-Bug: 1489918

Change-Id: I3d471518647d7aa562160c356a69600f946b6260

This patch adds some unit tests that load the bgpvpn plugin
with its extension and the corresponding dummy service driver.
UTs send Rest requests two test that the dummy service driver
gets called accordingly.
Change-Id: I77d11dc55c27c6fa994563f068dfb737bbaeb97c
Closes-bug: #1484164 

Change-Id: I82a13d54f25fcde95a753255bd1e72707400f3cb

Change-Id: I02f2aedb88fa284376f691c3ffe465274d560274

This commit adds:
* policy.json file
* setup.cfg hooks so that this file is copied into
 /etc/neutron/policy.d
* devstack plugin.sh change to put the file in the
 right place
Change-Id: If605f3fd4113f5e193d95d2d95449939caa8bdea
Closes-bug: #1480165 

addtions => additions
Change-Id: I511c5ef8629c4da25ec3f08b3a303f4a83be7be8
Closes-Bug: #1479787 

* rst fixes
* improved information on bagpipe reference driver
Change-Id: I13e92a3ae6bda1f22310e65825cc1ff9b158e5af

Change-Id: I350158fb9fb6c765b2c267fb9393292fb42b5cb0

Change-Id: I63106e0b190a4a4a0e8b66b2b2db1af146453e8d

The service plugin inherits from a default database model.
For drivers that use a third party to persists BGP/VPN connections,
the service plugin does not need database.
That patch introduces 2 driver interfaces:
- BGPVPNDriver: for drivers that uses third party to persists data
- BGPVPNDriverDB: for drivers that needs the service plugin BGP/VPN
 to persist data
Change-Id: Ic3431dee0283c8b44674356665b039f6689d091f
Closes-bug: #1472203 

Update BagPipe OVS agent to use new Neutron OVS agent library
modfied by patches [1] and [2].
[1] https://review.openstack.org/#/c/160245/
[2] https://review.openstack.org/#/c/195277/
Change-Id: I9b3c4c538178b201b30929ffd3809cfd4a90e4e2
Closes-bug: #1472569 

The Neutron fix [1] removed the service provider constant
COMMON_PREFIXES and that must be defined as a property.
That patch also intorduce a constants file to group all BGPVPN
constants.
[1] https://review.openstack.org/#/c/198113/
Change-Id: Iae5d66bb8ffe6c7eb7825bf35b6f5fbc1d7dfd4a
Closes-bug: #1472619 

Mimic what neutron-lbaas is doing to avoid cloning
neutron repo on each test job, following guidance by
fungi.
Change-Id: I4c3bbaf568ba7ac96caf7534ec4294e18d6c7cee