openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

Update to new PTI:
https://governance.openstack.org/tc/reference/pti/python.html#python-test-running
This change also wraps in a change to requirements.txt that
point pre-rocky neutron pypi release, which is the only
way I found to have the functional job get a fresh-enough
neutron (it's not a tox job and hence does not benefit
from the tox-siblings magic). This also reflects better what
is the real dependency we have (when rocky will ship we will
have neutron>=13.0.0.0).
Change-Id: I868cf65aa5ff0e55d0d45f36808c76286e4e7fd3

* Test many bgpvpn routes association for one port.
 * Number of routes is defined by AMOUNT_LOOPBACKS
 * Test no ping before association
 * Test ping after association
 * Test no ping after removing association
Change-Id: I3b7eec8b4e0003866d14f7a242768b14802f4906

Django 2.0 is now used in tox py35 job, so there is no need for
py35dj20 job. Instead, Django 1.11 with python3 is not covered.
- py35dj20 job is dropped from tox.ini.
- python3-django111 is added to tox.ini.
 python3 is specified to basepython to avoid a specific python version.
- .zuul.yaml is updated to consume horizon-openstack-tox-python3-django111
 and drop horizon-openstack-tox-py35dj20.
Change-Id: Iba72d0bd67d6d6331b1abcfa338d02a8f4070562

Recently horizon test configuration was changed to use
the Django default test runner because nose is in maintenance mode
for the past several years [1]. Django testcase and testtools are
incompatible, so bgpvpn_dashboard testcases now fail.
In addition, bgpvpn_dashboard/test/test.py is unnecessary
and it causes the test failure too, so this file will be
dropped by this commit.
[1] horizon commit 1f80d94459856a8c477310cc0fe4b0e165d8c0c1
Change-Id: I45ff876871d7dcb82f284061b3a7225dd65c771b
Closes-Bug: #1776223 

This is a follow-up on I7d399466f6577e4dd55b1a0fa5a92aab15e6eebb,
which missed a few places were the old method names were still
used.
Change-Id: I9dc5ddf64a968ce433f9dd05b135f4263a12b8a0
Partial-Bug: 1761691

As a follow-up to Ia59fc1978228f9982d3ee447ebcfcb712eebbdb7,
drop the use of the old extension setup method.
Change-Id: Ib784403a6bcacdc4f2cc49b7d0064232bc13c1fe

This adjust the devstack plugin code to work in the case
where new neutron devstack service names (neutron-*) are
used instead of the neutron-legacy devstack services names (q-*).
Change-Id: I557cf268ae12cce3352330ec0d30006f3d598f2e
Depends-On: I55aefa9ac1aaf0f69a7a31365439141633183722
Closes-Bug: 1769601

For some reason I don't understand, api_extension_path ends up
being rewritten between two unit tests.
This is a workaround to unbreak CI.
Change-Id: I930343e7c5d63c02a75bca284be30d5a3df05791
Partial-Bug: 1771107

Replaces django.core.urlresolves with django.urls.
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was deprecated in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3
The arguments of include() has been changed in Django 1.9
and the older style was dropped in Django 2.0.
https://docs.djangoproject.com/en/2.0/releases/1.9/#passing-a-3-tuple-or-an-app-name-to-include
Add py35dj20 job to test Django 2.0 integration.
Change-Id: I1cdfc19c9fae5cad1adac0867f65d2ae15385d87

Source the l2 agent script only in case and in place where functions
from this are going to be used.
Change-Id: If99776166aebf432a6da3b77aa265fec01a64a37

Using decorators has a few benefits:
- readability: what event triggers a callback is described
 next to the method definition
- subclass can cleanly change the event that the mother
 class chose to trigger a callback
- a bit less verbose in the end
Change-Id: Ia5ced2f936add5e5e3387e62273bce626d40b7a6

TrivialFix
Change-Id: Id52db8cf842b814a8827bddd880ec9ec177578a3

This patch add a button "create router association" in bgpvpn panels.
It open a form to add only one network association with optionals parameters.
The bgpvpn overview details is more complete. There is
now a router associations tab which list all the router
associations. It's possible to delete each router
association and to update it.
Change-Id: Idd5af2ce2d4d864882c6191d648d16d9d9bcf35f
Partially-Implements: blueprint routes-control

This patch adds a button "create network association" in bgpvpn panels. It
opens a form to add only one network association.
The bgpvpn overview details is more complete. There is now a
network associations tab which list all the network associations. It's
possible to delete each network association. It's inspired by the network
panel which include subnets and ports tabs on the overview of a network.
It will be easier in the future to add others associations as routers and
ports with the same logical with new tab in bgpvpn overview details.
Change-Id: I6280b53558b6b52081ee6d629e8f3963d8dfc346

This change updates the call to neutronclient to use
the BGPVPN methods natively defined in python-neutronclient,
rather than the ones defined by the dynamic extension to
neutronclient from networking-bgpvpn (which are deprecated).
Also removes use of mox at the same time.
This change also makes the lower constraint job use
neutron, horizon, networking-odl and networking-bagpipe
from git, which is required to unbreak the CI right now.
Change-Id: I7d399466f6577e4dd55b1a0fa5a92aab15e6eebb
Partial-Bug: 1761691

These dependencies are optional dependencies for running
networking-bgpvpn, and real dependency for unit tests
only.
Change-Id: Ib1f06138a86b5a1cedc175477e0962bf9c05ad5d

With this change, heat code will use the BGPVPN API
methods from neutronclient, instead of the ones dynamically
added to neutronclient by the networking-bgpvpn module.
This allows the heat plugin to be installed in an environment
where networking-bgpvpn is not installed.
Partial-Bug: 1761691
Change-Id: Ibea29481662994c8b560bda45d4db534e924d42a

Now that neutron-lib supports sub-resources [1], there's no need for
extension classes to override get_extended_resources to add their
own sub-resources.
This patch removes those methods from the bgpvpn and
bgpvpn-routes-control extensions classes.
(commit message shamelessly stolen from
Ibb66246091fd84e18c56009f5fcb8fdea3aff6b7, thx boden)
[1] I8ae11633962a48de6e8559b85447b8c8c753d705
Change-Id: I2e9901bfced81f680ba078dcbcdbbeb816d79ce0

The documentation was still refering to the
old methods provided by the networking-bgpvpn
dynamic extension to neutronclient instead of
the newer and more complete methods that have
been in neutronclient since Ocata release.
This change updates the documentation and examples,
and adds code to document the method for port
associations.
Partial-Bug: 1761691
Change-Id: Idd572530d64cd65cc0a606515bcf7f056c2b8745

The test as initially written was realizing route leaking
in a way that was not avoiding the leaked routes from being
also imported by the VRF for the intermediate VMs. These
routes competing with direct routes to the ultimate destination
were sometimes (depending on route selection and load balancing)
preventing connectivity.
This change modifies the way leaking is done and the way RTs are
used to avoid this.
Closes-Bug: 1762649
Change-Id: I1b9a8bca500eedbe2c42cb8acfc6f37f12a51a5f

The BGP RTs used in the tests were initially constants, reused
by the different tests. This is safe only if tests are not
run in parallel, but not when they are concurrently run, because
some routes advertised by one test may be imported in routing
tables from another test.
To solve this, we need to dynamic allocation of RTs so that
different tests use different RTs, to ensure isolation
between the different tests.
Change-Id: Ib1b461a7f6d6d949993c07129f24fbffe92990bb

Because they make the code a bit more readable.
Change-Id: I7b2aaadf6e06b2a3ad2ea9f4987855558d39c53f

See I7e2502f8591ad664d20e23e58f33291575f29083.
Change-Id: I4f0f94ce8d526bf6e1012823409582d46402625b

This method does not seem to be used anymore:
http://codesearch.openstack.org/?q=get_plugin_name&i=nope&files=&repos=neutron,neutron-lib
Change-Id: Ib1bd0e3a97705e323aafc65aed268a59bdd92788

Class BgpvpnTable between admin and project panel has
some common code. This patch inherit BgpvpnTable class
from project in BgpvpnTable Admin table.
Change-Id: I6c59f79334ef22afb8160aee44c244c6f5fc9b15

Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I8596b2a4d38c43cfa18e4dfa0c15990326ecc75c
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Change-Id: I27e465649f6b46b6cbfe45683d8779c59db8f99c

Instead of using tox-install.sh, we can install horizon and neutron
etc. now directly from pypi - or use the current branch in CI system using
tox-siblings.
Create doc/requirements.txt for doc requirements as well.
Update tox.ini for this change and add projects to test-requirements
file.
Note this is one step in fixing publishing of docs for this repository.
Depends-On: https://review.openstack.org/552865
Depends-On: https://review.openstack.org/554297
Change-Id: I13e61fffca48b6c004e028f0da8a1d84a2337e10

With recent changes, these need to be moved to requirements to install
correctly.
Note that neutron is still installed from git thanks to tox-siblings in
OpenStack CI.
Change-Id: Icec5980b12d23b7e414750a3eabbb35a88068fe8

Change-Id: I27b2b0dfffb330b487bc539f08db0b93e4088bcb

Change-Id: Ic64fc58108ad540e47363e0aa79e6f51a87b2251

Change-Id: I3f23378142c29a898259fdfce2578c80f3320122

Change-Id: I3903c46a57ca6bdf079da9b42864be00028bafa0

* avoid having the same intro text in two files (use an include)
* avoid giving the impression that EVPN support is a mere possibility
* update some intro and README.rst text
* link to summit presentation videos
Change-Id: If2141d0e876a733b3623049f7ab7fef1a35f0af0

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I47a0f8bf1b85a5b9e666e2d776dc7085a77eae63