openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

TrivialFix
Change-Id: I47c32bdd9928a300176ae36a8e530f99562ee596

... because the service was removed long ago.
Change-Id: I42d6fb39976b7aaf8e24b443dc548d4d110964b2

As the 'all-plugin' tox env is deprecated it is recommended to use
'all' tox env instead.
[1] https://review.opendev.org/#/c/543974/
Change-Id: I827fa6d9a077efd0d3b5792fee6145dc604d371a
Related-Bug: 1862240

This patch switches from legacy jobs to standard jobs
(neutron-functional for functional jobs)
Clean up relevant files from legacy jobs
Remove hook calls in install jobs as they did nothing
TODO: not sure what to do about the install jobs, should we keep them?
Change-Id: If27b989195999d202fb819b01fe085c143b920f4

In commit [1] we removed tempest plugin code from this repo
as it was moved to neutron-tempest-plugin.
This commit changes also tempest regex for bagpipe tempest job to
be valid and run tests from neutron-tempest-plugin repo.
[1] https://review.opendev.org/#/c/657793/
Change-Id: I6d1983e9b9371fe03fd62b1848621581992ff841

Change-Id: Ieb2be8c2466ef762509a644c14fb4e9c26d82253

This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
For more information see the thread at
 http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html
Change-Id: I593cf4b53a44b1deed5bbe2c843df268b68b37cb

This commit converts the existing networking-bgpvpn policy.json
into policy-in-code.
Partially Implements: blueprint neutron-policy-in-code
Change-Id: I7cee0efef016dd8650ccf97686fe680667d52683

Change-Id: Ibd5389d333e46e3f30dd29022932d78c89c85410
Depends-On: https://review.openstack.org/598677
Related-Bug: 1789878

This change temporarily disable some tempests tests until
bug 1789878 is fixed.
It also puts an upper constraints to our networking-odl dependency,
which now draws networking-odl 13+ which requires ceilometer
with a "-e git..." that does not play nice with "pip install -c ...".
Change-Id: I67e8834c09f475b997edf9bf095fa1ac6595e4e0
Related-Bug: 1789878

Beyond their intrinsic marginal usefullness, standard
attributes [1] also include a revision number that helps
avoid some races in OVO-based RPCs for resource updates.
This changes adds standard attributes for the BGPVPN model
and Net/Router/Port Association models.
Note that this change adds something that had been missing
since the removal of toosl/tox_install.sh: having 'neutron'
as a required-project for the functional job. Not having
it, resulted in the use of stable/queens neutron which test
DB migration up to queens, but not any migration script
defined for rocky.
[1] https://docs.openstack.org/neutron/pike/contributor/internals/db_layer.html#the-standard-attribute-table
Partial-Bug: 1765391
Depends-On: I7630aab5e4f38d0fba862adc2426d4a7ca04a679
Change-Id: I77ce46c0f33e2a366076d51ce6586fb3008dc6b1

This adjust the devstack plugin code to work in the case
where new neutron devstack service names (neutron-*) are
used instead of the neutron-legacy devstack services names (q-*).
Change-Id: I557cf268ae12cce3352330ec0d30006f3d598f2e
Depends-On: I55aefa9ac1aaf0f69a7a31365439141633183722
Closes-Bug: 1769601

Source the l2 agent script only in case and in place where functions
from this are going to be used.
Change-Id: If99776166aebf432a6da3b77aa265fec01a64a37

Change I8cef6fc49b95b8a18fcb476da079fbc55fecd802 for bagpipe driver
improves coexistence between BGPVPN and a Neutron router, but requires
using the openvswitch firewall driver for single nodes setups.
Change-Id: I9d63ce7343f0eacc0bdc7eda568cc04586bdb4f8

The behavior of the current "v1" bagpipe driver is to
produce both the old and new RPCs to not prevent rolling
upgrades.
This change introduces a bagpipe v2 driver that does not
produce old RPCs and only relies on OVO push/pull RPCs.
To avoid code duplication of the code for new RPCs,
the current driver is refactored to inherits from the
v2 driver the code for the new OVO push/pull RPCs.
The current v1 driver is also modified to raise a warning
indicating its future removal.
This change also extends the previous unit test
coverage for the production of push-based RPCs.
Change-Id: I708ec1e4d8a8c27ffe8c4be172812e0a9aed54b4

With linuxbridge, the l2population statement is not under
the same section than for OVS.
This was breaking BGPVPN L2 with linuxbridge.
(+ minor cleanups)
Change-Id: Id28617cdf1ac870ae7afd53e0ecbb707ac558cf6

Tempest plugin currently defines a new 'BGPVPN' service.
This change remove this BGPVPN service and check instead
if the bgpvpn extension is activated to run the tempest tests.
Change-Id: I3731dc52793d4566632c3162d4c79d489b0857f1
Closes-Bug: 1646444

This change implements the framework part of the bgpvpn-routes-control
extension related to port associations:
- API extension definition
- service plugin additions for port associations
- driver hooks for port associations
- DB models and DB update code for port associations
 and their attributes
- corresponding unit tests
Partially-Implements: blueprint routes-control
Depends-On: I4cb61481205c3689c41e62670cec113adb2a0362
Change-Id: I263e1ee6cf4e1a91be91a4a78f4a160f64d33cc6

Fixes required so that the devstack plugin behaves nicely
when used in a setup with linuxbridge, and do not assume that the agent
is OVS when its not needed.
Change-Id: I2e7bc4303485ea6a0dd0215c624ee3b0883a6589

The policy check framework is added in the
devstack installation.
Documentation modified for a manuel installation.
Change-Id: I0791e329f41feca79ebe2f31321d1ce02ac44ec3

New os-testr uses stestr under the hood, which creates .stestr but not
.testrepository directory in the current dir. Other than that, it
doesn't seem like there is any difference in the format or names of
files generated in the directory.
(shamelessly stolen from I82d52bf0ad885bd36d2f0782a7c86ac61df532f2)
Co-Authored-By: Ihar Hrachyshka <ihrachys@redhat.com>
This change also wraps up another fix (simultaneous voting test job
breakage) related to a recent change in the neutron repository of
the import statements for ml2 config.
Change-Id: I6bfaca7de99c6ef6834375d4e5b3218a50a60491
Closes-Bug: 1716746

Change-Id: Ic2cfad5b41b96c31586fcc9158b30e5a4c2da195
Depends-On: I09338f8511e657eab5de3cc361b70f70b1490eaa

Sourcing the neutron devstack l2 agent script is only needed
if the q-agt service is enabled.
Sourcing conditionally helps build the devstack fullstack gate jobs
for networking-bagpipe.
Change-Id: I2fed6177eb35749bebd4b75d60b189c2abdb0cdd
Needed-By: I967ba442ef433b7ada5a1a381f1571ec3cf23517

This is done by other service providers devstack plugin,
and mandatory to have the job
gate-rally-dsvm-neutron-extensions-rally-nv passing in
https://review.openstack.org/#/c/386418/
Change-Id: I2b9c0c34fbd2ffbc4695a3b3c440b8f46adb65ed

networking-bagpipe now has a proper way to set BGP peers
to an empty list, which we should use in our devstack gate job config
because our job is single node.
Additionally, we can specify the use of the OVS driver of bagpipe-bgp
in a simpler/shorter way.
Change-Id: I32701b29a3314bcdcfba6ba73d71ddcf3c62afa4

Provide a 'bgpvpn' entrypoint definition, to allow the activation
of the service plugins in a less verbose way.
Change-Id: I751861c25e2e301011d2c1738288660e1286a9a1

See http://lists.openstack.org/pipermail/openstack-dev/2017-January/111295.html
Change-Id: Iede105d4c3d225eca2625afaa98ae007992abf53
Closes-Bug: 1660973

This change contains two changes to fix our CI:
- a reno branch naming issue
- a permission issue in devstack VM functional job
On the reno branch naming issue: something must have
changed somewhere in the way we should name branches
in reno files (old way: origin/stable/newton
new: stable/newton).
...
 ldr = loader.Loader(conf)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/loader.py", line 60, in __init__
 self._load_data()
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/loader.py", line 80, in _load_data
 self._scanner_output = self._scanner.get_notes_by_version()
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 577, in get_notes_by_version
 versions_by_date = self._get_tags_on_branch(branch)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 344, in _get_tags_on_branch
 for c in self._get_walker_for_branch(branch):
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 338, in _get_walker_for_branch
 branch_head = self._get_ref(branch)
 File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/releasenotes/local/lib/python2.7/site-packages/reno/scanner.py", line 334, in _get_ref
 raise ValueError('Unknown reference {!r}'.format(name))
ValueError: Unknown reference 'origin/stable/newton'
Change-Id: I22c09534bc713f4eb00d106285a07acdd6e99730

This reverts commit dd4941459c.
The patch for devstack has merged :
I48c86f94098f1501f0e7f90a265dda7e81440eb0
Related-Bug: 1629133
Change-Id: I69907b256af6218c4cfe7aa2b4ba0508991fe4b9

This patch adds a scenario test that creates an l3 VPN and
assigns two neutron networks/subnets to it. Two nova VMs are
spun up on each network. To verify that the VPN is functional,
i.e., forwards traffic between the two subnets, one of the
VM pings the other one.
Change-Id: Ic38aab48fa364ad53ef061566fe5ebc1a46fec33
Closes-Bug: #1637489 

We need to follow devstack change I3d98692e69d94756e0034c83a247e05d85177f02 or
our tempest config addition comes before the config is completely
reset by devstack tempest setup (lib/tempest:configure_tempest rm -rf at [1]).
[1] 0474b8384a/lib/tempest (L177)
Change-Id: I024effd277b90c20c17ae09d291cbadfe5c03f57

Our tempest test scheduled on osic-cloud1 all get stuck
in requirements installation.
The problem was diagnosed (fungi, tmorin) to be related
to the fact that the neutron devstack code for setting
up routers is installing via br-ex a route to SUBNETPOOL_PREFIX_V4,
which defaults to 10.0.0.0/16, which in the case of
osic-cloud1 contains the gateway IP to reach the Internet
(10.0.0.1):
fungi@ubuntu-xenial-osic-cloud1-s3500-5253075:~$ ip ro sh
default via 10.0.0.1 dev ens3 onlink
10.0.0.0/16 via 172.24.5.11 dev br-ex
10.0.0.0/8 dev ens3 proto kernel scope link src 10.5.131.187
172.24.5.0/24 dev br-ex proto kernel scope link src 172.24.5.1
This change is a temporary fix for networking-bgpvpn that
sets SUBNETPOOL_PREFIX_V4 to a prefix *not* containing 10.0.0.1.
Change-Id: I5e4b99c6eb06837be7e1b5a9ed456f57ab6f9514

- migration tests now have time to execute
- add hooks to have database configured for functional tests.
- add hook to see result of tests.
Change-Id: I0d2406ef10df897fabe44e6fc287ea292843ecce
Closes-Bug: 1632212

Compiling a fresh upstream OVS is not required anymore now
that our tempest job is configured to use xenial.
(Note that the devstack-gate-bagpipe-rc script is only used by the
Openstack CI gate scripts so removing the OVS compilation trigger
does not impact non-gate use of the devstack plugin)
Change-Id: I50f2b6275400877e6e727a435406e362390dad46

The current ovs master is broken [1].
This is a temporary fix.
The target fix should be switching our dsvm jobs to use xenial instead
of trusty as a base distro.
[1] http://openvswitch.org/pipermail/dev/2016-October/080783.html
Change-Id: I900ef9991b9c7fde8252635f23f0afeea4b10756

Most of the changes in d088925891 should
have been made on the branch after it was created. The update to
requirements was the only one that should have been made in master
before the branch.
The change to .gitreview and tox.ini will be made automatically by the
branch script. The other changes should be done by hand in
stable/newton.
Change-Id: Ief5c73ab4d1cd5fd032dede21f6a244bfa5777c2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

This change updates our tree for Newton:
- tell "git review" to push in the stable/newton branch.
- configure tox to use the stable/newton upper constraints file
- let tox test UTs with newton release of networking-bagpipe
- let devstack jobs to use newton branch of networking-bagpipe
Change-Id: I67a1103eae0219e5cefa91fd5848aa0b8986c542
Depends-on: I719a9912ba8e7fe87620850017bdda83431e22da

This is required because the place where plugin_agent_add_l2_agent_extension
is defined is not sourced by default.
Change-Id: Ib1de7cfec457a312319edddd5262cd78c6599f0b

This change is needed to have the OVS agent extension for the bagpipe
driver enabled (because of [1]).
[1] https://github.com/openstack/neutron/blob/stable/newton/devstack/lib/l2_agent#L12
Change-Id: I1f4c86a6ae15985e581d0fd0a03754b2c5a5d571

Add a new panel BGPVPN in project section to display BGPVPN created
for non admin user.
The page allow actions as edit and update associations
networks or routers for BGPVPN resources.
Some part of code has been refactored to put in common methods or
classes between project and admin panels.
Change-Id: I49bfdfe1427c67f6b19a7b4faec0ab77a15ce8a5
Implements: blueprint horizon-tenant-workflow

remove override of DEVSTACK_GATE_TEMPEST that is defined in jenkins job,
and run only bgpvpn's tempest tests using a regex filter.
Change-Id: Iae534db7bd34624fad135dad4f5b6f34fc5143bf

Add a new panel BGPVPN in Admin section to display BGPVPN created. The
page allow actions as create, delete or modify BGPVPN resources.
Add an API file bgpvpn to handle the bgpvpn Python API via
neutronclient.
Change-Id: Iee2de53c8cb9d61f80033ab63485bdcf0e742abb
Implements: blueprint horizon-admin-workflow

Follow changes made in how Neutron devstack handles
compiling a fresh OVS (see Ia7ad1658b95d7404384c7cae833008a57e3e5af1).
The benefit is that our devstack code is simplified.
Change-Id: I3abc2ac4ce2d4710f998e7749d1f5df4303533e2

Change jenkins job rc file to enable bagpipe-bgp service
and configure it with the OVS MPLS dataplane.
This will automatically enable the bagpipe_bgpvpn OVS agent
extension.
It will also compile and install a recent OVS in the gate
(reusing neutron devstack scripts for this purpose).
Fix xtrace restoration.
Change-Id: Idb4fdad0da7bed5eda0c302bc79c5f05d50b44d7

So that the project-config change Ifbd24926013137407107d342576974d3fe5d8f5e
can be merged.
Change-Id: Iea3dcad95416668d741bf6562bd9cbcb8d7e7ac9