openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

This change improves test_delete_port_to_bgpvpn_rpc to
have the callback really generated by ML2 plugin rather
that resynthtizing one.
A few other improvements are made to have more realistic
data flow into the driver.
Change-Id: I8be6c90dacef46e560759a6bd68efdb677666607

We can now test for update_device_down triggering
the right callbacks in bagpipe driver.
Change-Id: I60567cd9df03327141c21de53d04cf76400685eb

Found "networking-bgppvn" instead of "networking-bgpvpn" and also "intalled" instead of "installed" in the installation document.
Link: http://docs.openstack.org/developer/networking-bgpvpn/installation.html
Change-Id: Iadd4488525d47ba9a44bebfe4b49db14d8ac5bef
Closes-Bug: #1583517 

The code in OVSBridgeIntercept was not behaving
as intended:
- the extension cookie was not applied as expected, even
 for the ofctl-based OVSTunnelBridge (interference with
 class inheritance, because __getattr__ does not let us
 override methods existing in a parent class,
 __getattribute__ has to be used instead)
- the extension cookie would never have been applied
 for the native.OVSTunnelBridge that does not use add_flow
This changes corrects the code and adds a test case.
We also now import the neutron constants from neutron-lib.
Change-Id: I779d7a8bf7fc31d936d1e401e4726711c8404ed2
Closes-Bug: 1582598

This fixes (and simplifies a bit) a few unit tests for
bagpipe driver that were failing after the merge of change
Id85ff6de1a14a550ab50baf4f79d3130af3680c8 around ML2 code.
Change-Id: I1848715e03e2cdd69245ddb10f0900cdcb62e67c

Typo in OpenContrail driver documentation manual
Description:
Link: http://docs.openstack.org/developer/networking-bgpvpn/opencontrail/index.html
There is typo in above documentation link it should be dev/test instead of devi/test
Change-Id: I9a48f6abb3c519302345b27986abaf5dab8859dc
Closes-Bug: #1583008 

Add base information on the Nuage Networks driver.
Change-Id: Ifaee145013c56ba289a4b1bea67e4f2ff6a92ed9

Improve installation/config documentation.
Change-Id: Ib1c24d49210ca65670a73187db3eee7733bdc179

Icad59a0d7deda38de3216a3be9ca7e75f6beff55 was introduced to
ignore probe ports but only ignored "compute:probe" but not
"network:probe" ports.
With this change, bagpipe driver ignores all probe ports.
Change-Id: Icdb6355d107c969638521b6ddefd29dd96913016
Closes-Bug: 1575662

Follow changes made in how Neutron devstack handles
compiling a fresh OVS (see Ia7ad1658b95d7404384c7cae833008a57e3e5af1).
The benefit is that our devstack code is simplified.
Change-Id: I3abc2ac4ce2d4710f998e7749d1f5df4303533e2

Change-Id: I0b47e20ee2842ca6dbaa174acf092823a59b8243

4488cf53ed introduced a check
in bagpipe driver to ignore network:* ports, which is the desired
behavior, except for probe ports, which we don't want to ignore
to allow testing with probe ports.
This change relaxes the check to not ignore probe ports.
Przemyslaw Jasek reported this bug and suggested the fix.
Change-Id: Icad59a0d7deda38de3216a3be9ca7e75f6beff55
Closes-Bug: 1575662

In the future we will add one release note file
within each relevant change.
For mitaka I'm doing this in one shot.
Change-Id: Ib6b67f638ccbc894706aa5170bdb12f20f5955a0

Add the missing file to show changes from the "current" branch, allowing
reviewers to see how release notes file render before approving the
patches.
Remove the stray reference to README.rst in the toctree, since there is
no such file.
Add the -W option to the build so that bad notes that break sphinx fail
the release notes job.
Change-Id: I756ec20f85b7ba9f1e5cf713f480611bf8c94bc1
Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Adds following checks to ODL driver:
1. create_bgpvpn: Only type l3 is allowed
2. create_net_assoc: Allow network to be associated with only one bgpvpn
3. create_router_assoc: Allow only one router to be associated with a
bgpvpn
Change-Id: I03859bb457a7eed469d003e13ae855e9ba6b11c6
Closes-bug: 1560842

Change-Id: I5328d724695d1a51d4670e6f9861d0c89706c31e

Change jenkins job rc file to enable bagpipe-bgp service
and configure it with the OVS MPLS dataplane.
This will automatically enable the bagpipe_bgpvpn OVS agent
extension.
It will also compile and install a recent OVS in the gate
(reusing neutron devstack scripts for this purpose).
Fix xtrace restoration.
Change-Id: Idb4fdad0da7bed5eda0c302bc79c5f05d50b44d7

Change-Id: Iba79204a92d948a99b52a82733f4f87d24482f07

With this change, bagpipe driver won't trigger agent
RPCs for any network:* port or port of external networks.
This was already done for DHCP ports, but extended to
router interfaces, gateway interfaces, and external
networks.
The documentation and unit tests are updated accordingly.
Change-Id: Iae071e1bc19f20b38cc380e37366184b15ae7088

So that the project-config change Ifbd24926013137407107d342576974d3fe5d8f5e
can be merged.
Change-Id: Iea3dcad95416668d741bf6562bd9cbcb8d7e7ac9

This change improves bagpipe driver so that no RPC is produced
towards the agent on port update notifications for which the port
status does not change.
Change-Id: I5e831b6bd56bcd04a462957a63ed419840702a09

This change adds precommit checks to bagpipe driver:
- type has to be l3 (create)
- route_distinguishers can't be specified (create and update)
Change-Id: I3c1eccf8daef9bb13d0b0519b01119299389d69e
Closes-bug: 1561419

This files are missing and causing our experimental jobs to
not work at all.
This should have been done in I8d9580b480b1cdd3d185d51f13cd06be26310d17.
Change-Id: Iff18371068b82b341e00b391c0adf77c966967da
Closes-bug: 1561206

With this hook, driver will be able to stop an association request
if they're not able to perform this kind of association.
Change-Id: I41c74adf4ec2b1bd66f7a975ec3c4cd40fad5a97
Closes-bug:bug/1560558

With precommits, bgpvpn drivers will be able to block any change
that a REST request wants to apply to the DB with create/update_bgpvpn.
If the driver raises an exception during its precommit method,
the REST client will have a HTTP 500 error, and nothing will be
commited in the DB.
Change-Id: I1f0e5d4a555fe0802ecc873f7ae0f2ac121fc783
Closes-bug: 1557608

Since bgpvpn might be run with the neutron l2 agent but without
bagpipe, we should only enable the bagpipe l2 agent extension
when devstack is told to use bagpipe.
Change-Id: I4e085f489ed99b72f09e03cffcd2814a1721dfe8
Closes-bug: 1559149

Update to:
- explain how to enable the OVS agent extension
- remove "enable_plugin bagpipe-bgp"
More precision and detail.
Change-Id: I69652dff0fe2788f1e6ce92e55ca50c3c8481ebe

Change-Id: I7ae4b1960443bd0bcec8efe2947e7498adea79f1

This test shows that only admin
tenants can create bgpvpns.
Change-Id: Ie09bb37f787227187c0492bf945f29ee6c082d1b

To support the latest version
of tempest we have to change to use
tempest.lib.
In addition the neutron clinet is
not a dependence for tempest anymore.
So we have to get rid of this
dependence as well.
Change-Id: I0c688a5bbc946ed0b488c6f95a80653e22a8d6e4

Change-Id: If6ca34b64f952271a7ca04935cf91747bb29cbae
Closes-Bug: #1557445 

This change introduces an OVS L2 agent extension that will now be used
instead of the previous agent in ovs_bagpipe_neutron_agent.py which
was inheriting from the Neutron OVS agent in a crude way, requiring
duplicating the main() code.
We also remove mention of the old bagpipe-openvswitch agent
in the documentation and and adapt the devstack plugin so that
old local.conf will still work.
Change-Id: Ibf27e2b028efffa1e49207d39bfc9b13464180ad
Closes-Bug: 1492021
Closes-Bug: 1531459

Adding rc files to allow to control the gate jobs parameters
without having to touch Jenkins job definitions in project-config.
Change-Id: I8d9580b480b1cdd3d185d51f13cd06be26310d17