openstack/manila-tempest-plugin - manila-tempest-plugin - OpenDev: Free Software Needs Free Tools

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_subnet
	* create_networks (not used)
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I516c4bdc5e93ac7521f546102c144bcb1c4d34af

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_security_group
	* _create_loginable_secgroup_rule
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Idd6c9066cec143e358078babf1802dce60265114

Some recent changes introduced a branches variable into our yoga,
xena and wallaby jobs. Manila-tempest-plugin is branchless, so such
jobs should not have the branches variable assigned to them.
Change-Id: I8647d268ccd642def4a003f63ea26d804016c20f

As a continuation of the patch [1]. The required change
was merged in tempest. So we can make the cleanup in
manila_tempest_plugin.
[1] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/836877
Change-Id: I093be875910ef18deebe3e56b83c6992d1a307e5

Adds a new check job to test FIPS compatibility with Manila
upstream CI. We currently only have means to enable FIPS on CentOS
systems. Ubuntu support will come in a later effort.
Starting from CentOS 8, there is no candidate for a quagga package
installation. Our IPv6 setup currently depends on quagga. If we
keep IPv6 enabled, the job won't even start. For now, the job will
only set up IPv4 and run the tests for this specific IP version.
Co-authored-by: Ashley Rodriguez <ashrod98@gmail.com>
Co-authored-by: Vida Haririan <vhariria@redhat.com>
Change-Id: Ica6445c582ceae4c5b9bbce48702c74710e6056f

This changes addresses few comments left in the change that
refactored some of our CI jobs [1], regarding a more suggestive
anchor name and a comment to give more context for code reviewers
in the future.
[1] https: //review.opendev.org/c/openstack/manila-tempest-plugin/+/847366
Change-Id: I4abf0d60e6662c6f409bfa6506ab51ea717dc8cf

In order to switch our manila service image to Ubuntu Jammy, we
needed to get in a couple of changes that Modified the flavor for
the manila service image. After all changes got merged, we switched
to the Ubuntu Jammy image [1].
However, now the manila service image master on Tarballs is using
a Ubuntu Jammy image, which requires more resources. It would not
be ideal to backport the changes that modify the flavor to the
stable branches because it is not an actual requirement for them,
and that also forced us to reduce concurrency of some jobs on the
master branch.
Using the Ubuntu Jammy image broke our stable branches CI, since
with less resources we are not able to successfuly spawn a nova
instance using the Ubuntu Jammy image.
In the stable branches, the jobs that spawn VMs will need to use
Ubuntu focal, so we have a new couple of jobs that will
selectively run against the stable branches and they will use a
pinned version of Ubuntu Focal from Tarballs.
These jobs were grouped into project templates to help us keep our
manifests readable.
Change-Id: I14afe2572c5bc8064417ba7ba3be26751022901d

1) Use the shares_v2_client to make metadata API requests.
This allows us to test v1 proxies as well where appropriate,
and actually test the supported version of the API instead
of the deprecated version
2) Verify key in GET /v2/shares/<share>/metadata/{key} API
the client's _parse_body helper strips out the top
level key allowing us to miss bugs associated with
any key changes from the server [1]. Allow for opt-in
verification of the key and add this verification
to the affected API.
[1] https://bugs.launchpad.net/manila/+bug/1968069
Depends-On: Ib5a62599b84ba55617071f8bcd8e2a1a11b2537b
Change-Id: I7b1af957f08328c642a74ff123deb78e193bbe3a
Related-Bug: #1968069
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Due to some test constraints, we decided to migrate the
manila-service-image to Jammy Jellyfish [1]. In order to have the
jobs passing, we needed to grant more resources to the service VMs,
but it would not be ideal to backport those changes to the stable
branches.
We decided we would pin the manila-service-image to a ubuntu Focal
image in the stable branch, and with that we would not need to
backport the other changes we merged in order to switch the image.
[1] https://review.opendev.org/c/openstack/manila-image-elements/+/841264
Change-Id: I74f81e92297ad58ebd4266511bb62b5fe24f7cb5

As tempest.scenario.manager was announced stable interface
in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _associate_floating_ip
	* check_floating_ip_status
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
The commit also bumps the minimal version of tempest in the
requirements to tempest>=27.0.0.
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Ie17c1d9349e98ce016801bf47c1cb9dba18b51f6

We have been performing some tests using the Ubuntu Jammy image.
While doing such tests, we realized that the newest image would
need more RAM to be spawned successfuly, and that brings the need
to bump the memory for such VMs. While testing with the memory
bump, we realized that the generic driver would face issues with
such change.
We have seen a couple of tests failing due to the share manager
service loosing connection to the database, and this is usually
caused when we have a lack or high consumiption of resources in
a VM. Reducing the concurrency itself should work, and then
we would have the jobs passing. However, in reducing the
concurrency, this job will take longer to run, considering it
will only use one of the available threads, and it can lead to
this job's possibility to hit the 3 hours pre-scheduled limit.
To avoid that, we decided to:
Have this change to reduce the concurrency of the manila generic
driver job to 1, so we can avoid these failures, as well as
split the generic driver job into two jobs:
- manila-tempest-plugin-generic
- manila-tempest-plugin-generic-scenario
The generic one will take care of the API testing as we currently
know and have been doing. The scenario one will run all of the
scenario tests.
Change-Id: Id2d35ce592c73f0c731deb17a5d574f502fe64cb

stable/yoga is the newest stable branch, and needs
a job testing this branch. stable/victoria is in EM
state and we don't support using manila-tempest-plugin's
master branch against EM branches. Tempest is pinned
as well for this EM branch.
Change-Id: I949f6fc960c93084efec7ab36cd9f98b636513e5
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Defining queues at project.pipeline level was deprecated in release
4.1.0 of Zuul [1] and support for it will (probably) be dropped in
release 7.0.0. [2][3]
[1] https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes
[2] https://lists.openstack.org/pipermail/openstack-discuss/2022-May/028603.html
[3] https://lists.zuul-ci.org/pipermail/zuul-discuss/2022-May/001801.html
Signed-off-by: Eduardo Santos <eduardo.experimental@gmail.com>
Change-Id: I63d331e575899fa962daf022eaf6cace96a703c7

This helper method creates an access rule, waiting for it
to be active and delete it at the end of the test.
By using this methos we can reduce lines of code.
Change-Id: If1712cd412d236901232f9a2537f88d775f7d9f1

Since we decoupled ``share:get_all_security_services`` from
``context_is_admin``, we started preventing non-admins to use
the ``all_tenants`` flag for security service listing.
This change enhances one of our tests to ensure that in a
query to list security services using ``all_tenants``,
less-privileged users won't be able to see more security
services than they should.
Related-Bug: #1916102
Change-Id: Idd49e22c8dc534a1fe1e4814f233b079cf14bb72

The usage of sets introduces unneeded randomness, and the
utils.deduplicate function can be used instead.
This is a follow-up to similar past changes, see:
I9cbd26016238c25487ac8104c1188cd2cf4f467e
I15bfbf6e1ca604f2bf2fcf12dcd4e67bc728fe5e
Change-Id: I8fce553d927da6d94471ecdf4040bbbb4377d9cf

Change-Id: Ic07ef12f3f80001e688356bd70738c2b3b68667b
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Share instance show query need additional key 'updated_at'.
Related-Bug: #1965122
Depends-On: Ia69f3615d82e0044e3e9f81556dc8355637ef146
Change-Id: I1dbeee78c864067b8618b76a2929a112bef148e1

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* check_public_network_connectivity
		- not used
	* _get_server_port_id_and_ip4
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I473390048308a9637ead542ed18495cffb320dbc

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Barbican tempest plugin still uses nova-network old interface for floating ip related methods, this patch removes them and use tempests's ones which already use neutron's interface.[2]
Replaced methods:
	* create_floating_ip
	* get_server_ip
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
[2] 6428139de1
Change-Id: I2f6b61d868f9fc68cf000627a5a905083af6ace7

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* create_timestamp
	* get_timestamp
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Ib07791ed0ee2bbf9124e9852e254d384e55c4be1

As tempest.scenario.manager was announced stable interface in Tempest
27.0.0[1] it can be now reused in plugins.
Replaced methods:
 * get_remote_client
 * check_vm_connectivity
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I0911cda7fcf461b9786f9534689083c7ac3a2035

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _disassociate_floating_ip (not used)
	* _create_network
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I083d713c638de50b1549b4c10b9eb38f58b85fab

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* ping_ip_address
	* _log_console_output
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I519fd4de0b9f3ff20c355894c3e797d6c19e1835

This option isn't available in older versions of tempest,
since manila-tempest-plugin is branchless, we will need to
handle this situation gracefully.
Currently, all scenario tests with stable/train are failing.
Sample failure: https://paste.opendev.org/show/b9HiHJHTNbtL1z6Emnpe/
Change-Id: I36d5b5a32f27065c42e31ff231c55fc16bf18fda
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

This change adds negative and positive functional tests
for the new feature add multiple subnets per az. Older
functional tests impacted by the feature are fixed. Finally,
the new flags `run_share_server_multiple_subnets_tests` and
`run_network_allocation_update_tests` are added and configured
in the community jobs for Dummy DHSS=True and Container Driver.
Partially-Implements: blueprint multiple-share-network-subnets
Change-Id: I99547e1873646fb1494a454f67b14c7293342beb

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* create_server
	* rebuild_server
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I0c2fa6d195e1e31ed077bdc4c4e21fa6758dfddb

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_port
	* create_keypair
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Ib78df90a5e21b88d9088b0b6f349261236662923

Test for only_host scheduler hint added and guarded by multiple backends
check. Validated for version >= 2.67 since scheduler_hints are added in
that version.
Depends-on: I603434cac246e2c0946672d3f0fe469ed5423fa4
Depends-on: I2e6d8709fc02df16622bdc910127fa489835db38
Change-Id: I14045d3816f80841508d9e94dbe48addc252590f

Removes test_try_delete_metadata_with_unsupport_format_key
for metadata api refactoring introduced in [1].
This test relates to this bug [2], but fails in the code refactoring
mentioned above. Now that the router handles metadata endpoints, the
stripping of '.html' or '.xml' in the key is unecessary.
For more dicussion see [3].
[1] https://review.opendev.org/c/openstack/manila/+/824648
[2] https://bugs.launchpad.net/manila/+bug/1774353
[3]
https://meetings.opendev.org/meetings/manila/2022/manila.2022年02月03日-15.00.log.html#l-77
Change-Id: I3e7d3a49cec6af347368757f30d4478841dabeaa